From patchwork Fri Jun 11 17:04:40 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Giuliano Procida X-Patchwork-Id: 43838 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 534E53AAB4B7 for ; Fri, 11 Jun 2021 17:06:05 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 534E53AAB4B7 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1623431165; bh=znplhGJR9zYqmIPOhnhkE++QEhfB9rcPp1IRS13V6rA=; h=Date:Subject:To:List-Id:List-Unsubscribe:List-Archive:List-Help: List-Subscribe:From:Reply-To:Cc:From; b=kUTBSY9s87ogcP7kK3pr5XHHo49DKU0tdUAl6pkaVaA0rINbq+loVhl90x396XQXk 3S7nrcPafvG58GBDvqHMbTJBL4EkRbx4ZCE+kjyNK0mDr5U3ydAg2Gcj9Id/ZfIzOU Js3GVdAaJGHx1VBx3+1hbuouIGiIfSuTMYnGgWIo= X-Original-To: libabigail@sourceware.org Delivered-To: libabigail@sourceware.org Received: from mail-qv1-xf4a.google.com (mail-qv1-xf4a.google.com [IPv6:2607:f8b0:4864:20::f4a]) by sourceware.org (Postfix) with ESMTPS id 3D7FF3B8A402 for ; Fri, 11 Jun 2021 17:04:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 3D7FF3B8A402 Received: by mail-qv1-xf4a.google.com with SMTP id i6-20020a0cd8460000b029022689c68e72so16121748qvj.5 for ; Fri, 11 Jun 2021 10:04:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:message-id:mime-version:subject:from:to:cc; bh=znplhGJR9zYqmIPOhnhkE++QEhfB9rcPp1IRS13V6rA=; b=SJPfeG1ICzYUwvqWTjxexZKhZZxOxKQoMaSCXZ+Qn/d3/s0ItglUxOJwn+afFS7gKS bdqFVFuA1Z+RuHralbRJYBFHlbpnZ/d8dXftvVSK0VXQRHQle9jjbp30hE2pWszs6DqN 9J1R9wfP1L3tdmv5TrBhjKNmUxUhq2ZNnsltDB+hfYFFDyI5j7RBartXLMNZgQEJ1z/l 3esr8K7OFo6HRhECCo8qIKyQEEIFPAK4mLV6TOZmaoNJ9Tx3bMr3ySTmR0xjOQRpBarl 6h7AxvgvlostSmFYItNZebkzjv/lErOhiWT1XokfwaBCJMoscirDQTysLOLfelORNbQt GmSA== X-Gm-Message-State: AOAM5326w9y0nPteE0Ztkx8UlZNJIbEYP8AL2KY1aORwH69K56pQN/GS wbIgVD0ud6axnkdUoQ8ZPfKe7DLonjwWuG3l7faZWhdFVOAkvxdvqWPPVWwxUlCWRRPegRP0zUf F6nCM2pdNyRF6Jst8FWZOZ6p5JrqThlO8x+Q6YZkRL5f+4rpkzXZYfB6+zZ2h7j7G6fwEFgU= X-Google-Smtp-Source: ABdhPJzdf6Gg0LPloEt1Bze4lRFYjyUGrPfA7gUGZdJhminkqs8MKA8Ayu4kfQ432Jv/94Xh6YT4ww909scyKw== X-Received: from tef.lon.corp.google.com ([2a00:79e0:d:210:c264:c1f9:cf3c:2c0b]) (user=gprocida job=sendgmr) by 2002:a0c:ba0c:: with SMTP id w12mr5836359qvf.41.1623431086762; Fri, 11 Jun 2021 10:04:46 -0700 (PDT) Date: Fri, 11 Jun 2021 18:04:40 +0100 Message-Id: <20210611170442.845802-1-gprocida@google.com> Mime-Version: 1.0 X-Mailer: git-send-email 2.32.0.272.g935e593368-goog Subject: [PATCH 0/2] Eliminate some duplicate types in XML To: libabigail@sourceware.org X-Spam-Status: No, score=-16.3 required=5.0 tests=BAYES_00, DKIMWL_WL_MED, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libabigail@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Mailing list of the Libabigail project List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-Patchwork-Original-From: Giuliano Procida via Libabigail From: Giuliano Procida Reply-To: Giuliano Procida Cc: maennich@google.com, kernel-team@android.com Errors-To: libabigail-bounces+patchwork=sourceware.org@sourceware.org Sender: "Libabigail" Hi. There were more changes in this series and they had a greater effect, until the commit 1cfbff1b3037d1049bdff7e86de27c3a86af23b3 "rhbz1951526 - SELF CHECK FAILED for 'gimp-2.10'" landed. See https://sourceware.org/pipermail/libabigail/2021q2/003404.html for the original series. The first change is very simple and still eliminates some duplicates from ABI XML. The second change appears to do nothing with regard to the current test suite but eliminated one source of duplicate types through a certain code path. Giuliano. Giuliano Procida (2): XML writer: don't emit already emitted types XML writer: emit enclosing types of scoped declarations src/abg-writer.cc | 37 +++------ .../data/test-annotate/test14-pr18893.so.abi | 2 - .../data/test-annotate/test15-pr18892.so.abi | 8 -- ...19-pr19023-libtcmalloc_and_profiler.so.abi | 4 - .../data/test-annotate/test21-pr19092.so.abi | 79 ------------------- .../test-read-dwarf/test14-pr18893.so.abi | 1 - .../test-read-dwarf/test15-pr18892.so.abi | 4 - .../test-read-dwarf/test16-pr18904.so.abi | 2 - ...19-pr19023-libtcmalloc_and_profiler.so.abi | 2 - .../test-read-dwarf/test21-pr19092.so.abi | 59 -------------- .../test22-pr19097-libstdc++.so.6.0.17.so.abi | 1 - .../test9-pr18818-clang.so.abi | 18 ----- 12 files changed, 13 insertions(+), 204 deletions(-)