From patchwork Mon Mar 15 16:04:17 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Giuliano Procida X-Patchwork-Id: 42559 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 83C0D385800F; Mon, 15 Mar 2021 16:04:25 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 83C0D385800F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1615824265; bh=FGWEMRWZ2m4lvoIaw4ADrrKDxqkT/NOYtciH+NFSZdI=; h=Date:Subject:To:List-Id:List-Unsubscribe:List-Archive:List-Help: List-Subscribe:From:Reply-To:Cc:From; b=Vxgc5gaSNPVAhwYohWK37hdyG2quj6Vif6wfU+4ar0+i5iTds9MU5n/ET955ioLmS m7mpEO4kkjTw/DlEwUea/6JyO6VyQIjXPx90qviW6/w83G47ut3KUA+OE/Slu9hPDL jtXISxlWDHIWWOd5mRwSvGVuuh0sW1iSNeI72Pe4= X-Original-To: libabigail@sourceware.org Delivered-To: libabigail@sourceware.org Received: from mail-qt1-x84a.google.com (mail-qt1-x84a.google.com [IPv6:2607:f8b0:4864:20::84a]) by sourceware.org (Postfix) with ESMTPS id D4A5E385800F for ; Mon, 15 Mar 2021 16:04:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org D4A5E385800F Received: by mail-qt1-x84a.google.com with SMTP id o20so21453849qtx.22 for ; Mon, 15 Mar 2021 09:04:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:message-id:mime-version:subject:from:to:cc; bh=FGWEMRWZ2m4lvoIaw4ADrrKDxqkT/NOYtciH+NFSZdI=; b=cv57GBZMnId95bOEozfafeZMupYXxnomgLIlngrtVFai5lsO4DsPSGGhOMMa2sovJK GM33Vj7521Fow0g78WrGIBwb99m457IZ6vNw2Oi07UE4I+XHpU28s6jsf8LTIIns0S30 hLdYBhP7KQdLAQI9gsBmqASerkbRUzvSoKbpWriBxcNWi+MhHMZ8LItxNzK8Jj04i1KO 9RTuDMoc4HoB3fwGh2u7lu1oCCLpdhm5hyoP/YwVXupoaN0Yd8l9vebufEFWyTIwrtdr 9XA2gdCM+6YP5PY5bllkJiapZn+97cwM8CZreOnN+UbbnzpGcX3VcFw5bKmI0GK6CV1G 3Xcg== X-Gm-Message-State: AOAM532gnUfqNi8ffonJ6BAXjX8w9eOMgYGNLNXyVvzhInOKuQvcqheJ fMo86b1xTw0rcR/Pe35KmUpg0/EmgIf0cwBFruViFmbzpJAe/TT7pb+mYtFjFQuuAXBSHCieoGi oP41U7MPd8zNHQYCpW/s1uEBzb32LMIQjTqKSVtW6bbfrRo8lQOL/yFv7hckkRlNiJ6lrohw= X-Google-Smtp-Source: ABdhPJwS0hBzlEEz+3xU8OCR7P9lGKnhq86cwGA3myVC1G1G8T6k/Kz0g9oAsNFiAgm+x77uPPJAWqaWJD8BAg== X-Received: from tef.lon.corp.google.com ([2a00:79e0:d:110:d410:9d31:dea0:7e08]) (user=gprocida job=sendgmr) by 2002:a05:6214:18d2:: with SMTP id cy18mr25452495qvb.50.1615824262319; Mon, 15 Mar 2021 09:04:22 -0700 (PDT) Date: Mon, 15 Mar 2021 16:04:17 +0000 Message-Id: <20210315160418.153481-1-gprocida@google.com> Mime-Version: 1.0 X-Mailer: git-send-email 2.31.0.rc2.261.g7f71774620-goog Subject: [PATCH 0/1] Fix union member access specifiers To: libabigail@sourceware.org X-Spam-Status: No, score=-16.6 required=5.0 tests=BAYES_00, DKIMWL_WL_MED, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_FILL_THIS_FORM_SHORT, USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libabigail@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Mailing list of the Libabigail project List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-Patchwork-Original-From: Giuliano Procida via Libabigail From: Giuliano Procida Reply-To: Giuliano Procida Cc: maennich@google.com, kernel-team@android.com Errors-To: libabigail-bounces@sourceware.org Sender: "Libabigail" Hi Dodji. I found a few places in the code that that appeared to be doing the wrong things for unions which (like structs) should have members as public by default. Each of the 3 changes affected some tests. Only one of them affected a small test case I put together, so I've omitted that from the patch. FTR it's: union U { int public_0; void public_1() { } public: int public_2; void public_3() { } protected: int protected_4; void protected_5() { } private: int private_6; void private_7() { } }; struct S { int public_0; void public_1() { } public: int public_2; void public_3() { } protected: int protected_4; void protected_5() { } private: int private_6; void private_7() { } }; class C { int private_0; void private_1() { } public: int public_2; void public_3() { } protected: int protected_4; void protected_5() { } private: int private_6; void private_7() { } }; void fun(U, S, C) { } Please do double-check I've touched all the right bits of code. Thanks! Giuliano. Giuliano Procida (1): abidw: Treat union members as public by default. src/abg-dwarf-reader.cc | 20 +- .../test-annotate/libtest24-drop-fns-2.so.abi | 4 +- .../test-annotate/libtest24-drop-fns.so.abi | 4 +- .../test-anonymous-members-0.o.abi | 8 +- .../data/test-annotate/test13-pr18894.so.abi | 4 +- .../data/test-annotate/test14-pr18893.so.abi | 8 +- .../data/test-annotate/test15-pr18892.so.abi | 40 +- .../data/test-annotate/test17-pr19027.so.abi | 282 ++-- ...st18-pr19037-libvtkRenderingLIC-6.1.so.abi | 12 +- ...19-pr19023-libtcmalloc_and_profiler.so.abi | 84 +- ...st20-pr19025-libvtkParallelCore-6.1.so.abi | 12 +- .../data/test-annotate/test21-pr19092.so.abi | 118 +- .../PR25409-librte_bus_dpaa.so.20.0.abi | 238 +-- .../test0-pr19026-libvtkIOSQL-6.1.so.1.abi | 1384 ++++++++--------- .../PR22015-libboost_iostreams.so.abi | 4 +- .../data/test-read-dwarf/PR25007-sdhci.ko.abi | 208 +-- .../libtest24-drop-fns-2.so.abi | 4 +- .../test-read-dwarf/libtest24-drop-fns.so.abi | 4 +- .../data/test-read-dwarf/test-PR26568-1.o.abi | 4 +- .../data/test-read-dwarf/test-PR26568-2.o.abi | 4 +- .../test-read-dwarf/test-libandroid.so.abi | 240 +-- .../test-read-dwarf/test10-pr18818-gcc.so.abi | 8 +- .../test-read-dwarf/test11-pr18828.so.abi | 52 +- .../test-read-dwarf/test12-pr18844.so.abi | 106 +- .../test-read-dwarf/test13-pr18894.so.abi | 4 +- .../test-read-dwarf/test14-pr18893.so.abi | 8 +- .../test-read-dwarf/test15-pr18892.so.abi | 40 +- .../test-read-dwarf/test16-pr18904.so.abi | 58 +- .../test-read-dwarf/test17-pr19027.so.abi | 282 ++-- ...st18-pr19037-libvtkRenderingLIC-6.1.so.abi | 12 +- ...19-pr19023-libtcmalloc_and_profiler.so.abi | 84 +- ...st20-pr19025-libvtkParallelCore-6.1.so.abi | 12 +- .../test-read-dwarf/test21-pr19092.so.abi | 118 +- .../test22-pr19097-libstdc++.so.6.0.17.so.abi | 80 +- .../test9-pr18818-clang.so.abi | 12 +- 35 files changed, 1781 insertions(+), 1781 deletions(-)