From patchwork Fri Jul 24 17:09:51 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Giuliano Procida X-Patchwork-Id: 40173 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 4585F3857C64; Fri, 24 Jul 2020 17:09:59 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 4585F3857C64 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1595610599; bh=Cwq5wAYa1EfR+JkScUsFzJKCsIiP4YoQYtw2W734X4M=; h=Date:Subject:To:List-Id:List-Unsubscribe:List-Archive:List-Help: List-Subscribe:From:Reply-To:Cc:From; b=CbiqwTgLUc2xf/P7yLqVDZMoBK6iUeJYjTftCHbIizuxWdRZoFQkiD/mISz+X9ijR yk7MHqttCVA16cbnJqmdst5PfvWHEGW+uaMs1Q9iGqe943GZl0nk2MearcuzDzK9MT U7VJz+fQX+2b1hPeCJSwFsNQSnOeC7J7DpVl6SXY= X-Original-To: libabigail@sourceware.org Delivered-To: libabigail@sourceware.org Received: from mail-qk1-x749.google.com (mail-qk1-x749.google.com [IPv6:2607:f8b0:4864:20::749]) by sourceware.org (Postfix) with ESMTPS id 1C8403857C64 for ; Fri, 24 Jul 2020 17:09:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 1C8403857C64 Received: by mail-qk1-x749.google.com with SMTP id q3so6699551qkj.10 for ; Fri, 24 Jul 2020 10:09:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:message-id:mime-version:subject:from:to:cc; bh=Cwq5wAYa1EfR+JkScUsFzJKCsIiP4YoQYtw2W734X4M=; b=egzLMiFrLd6bQgIrDkK3nph/OyJKn0LmiNQndQmGGUFsaUcMYxR5DgsFpJEbjxKiZW A1walvRRLtyl34WibJp4vH41wUCFH8kGwXg9YgWDSO32Brv/An/WdqB1cmTFUCjfZ6Gt vgny3qTsr5zmvulN+fZaSbfAaP1ZYRwA0sV+16HgEqJyY83pA284ysPStgPExXTBw7+d K3fL0l/EFKfwTylP3amfQPs1Xmmqt3im/CsxnvJe5AaXBeR0Cxk2ReXvKJton25GtIhZ pKRi6vfnTFc856UaXgTLeYvYyQEfMCUQuDN7nhwTUEDWD4HqtJct7y7JahYL5pQQ7nuD TyDA== X-Gm-Message-State: AOAM530wmGcNTjrrVQo2WQ8pWf+OCllZwIXMyUgOc7Fq8QaBxU8ohtRE kqRB4wAkbhpV5VIiDsV94pJ86pp6dRqMlwqsCqqRcyBfeq9yyF3AUowcLJ+dymFUJD26djPJE43 vmWvMftrsLl6CwiQw/iUi9snshyqnpuwJtgNNyHSMwWAfw1Jqv//hd9PnPdIHQ1Iyk8tdFo0= X-Google-Smtp-Source: ABdhPJwK9RxK3q/OwE+b054rGX14l27TjHKPHwyVnAU08OGA1pWv+3tqGEiQei7R9gzUS+K+BJsbM7ACU2Vv2w== X-Received: by 2002:a0c:f683:: with SMTP id p3mr10672565qvn.39.1595610596469; Fri, 24 Jul 2020 10:09:56 -0700 (PDT) Date: Fri, 24 Jul 2020 18:09:51 +0100 Message-Id: <20200724170953.4069948-1-gprocida@google.com> Mime-Version: 1.0 X-Mailer: git-send-email 2.28.0.rc0.142.g3c755180ce-goog Subject: [PATCH 0/2] Fix determination of DIE declaration-only status To: libabigail@sourceware.org X-Spam-Status: No, score=-17.6 required=5.0 tests=BAYES_00, DKIMWL_WL_MED, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libabigail@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Mailing list of the Libabigail project List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-Patchwork-Original-From: Giuliano Procida via Libabigail From: Giuliano Procida Reply-To: Giuliano Procida Cc: maennich@google.com, kernel-team@android.com Errors-To: libabigail-bounces@sourceware.org Sender: "Libabigail" Hi. These two patches should consistute a fix for Bug 26297: "Possible misinterpretation of DW_AT_declaration via DW_AT_specification". A chain of DIEs linked by the DW_AT_specification and/or DW_AT_abstract_origin attributes should only be considered "declaration only" if every DIE in the chain has the DW_AT_declaration attribute. The first commit changes the behaviour of die_is_declaration_only to not search for DW_AT_declaration across links and then second adjusts code so that this function called for every DIE in a chain with the results combined together sensibly. I couldn't see any way of avoiding the extra plumbing without restructuring a lot of code or adding a separate pass over the DWARF info. Regards, Giuliano. Giuliano Procida (2): DWARF: look up DW_AT_declaration non-recursively DWARF: track chained DIE declaration-only status src/abg-dwarf-reader.cc | 160 +- .../data/test-annotate/test15-pr18892.so.abi | 431 ---- .../data/test-annotate/test17-pr19027.so.abi | 18 +- ...st18-pr19037-libvtkRenderingLIC-6.1.so.abi | 2102 +++++++++-------- ...19-pr19023-libtcmalloc_and_profiler.so.abi | 112 +- ...st20-pr19025-libvtkParallelCore-6.1.so.abi | 174 +- ...-pr19026-libvtkIOSQL-6.1.so.1-report-0.txt | 3 + .../test-read-dwarf/test15-pr18892.so.abi | 241 -- .../test-read-dwarf/test17-pr19027.so.abi | 18 +- ...st18-pr19037-libvtkRenderingLIC-6.1.so.abi | 2067 ++++++++-------- ...19-pr19023-libtcmalloc_and_profiler.so.abi | 110 +- ...st20-pr19025-libvtkParallelCore-6.1.so.abi | 174 +- .../test22-pr19097-libstdc++.so.6.0.17.so.abi | 88 +- 13 files changed, 2526 insertions(+), 3172 deletions(-)