mbox series

[0/3] Bug 21485 - problems compiling with clang

Message ID 20200709182250.1677238-1-gprocida@google.com
Headers show
Series Bug 21485 - problems compiling with clang | expand

Message

Giuliano Procida July 9, 2020, 6:22 p.m. UTC
Hi.

This short series fixes a known issue with Clang compilation of
libabigail and error-overloaded-virtual warnings.

The first patch removes an unused function.
The second patch fixes a latent bug detected by the warning.
The third patch enables the warning.

Regards,
Giuliano.

Giuliano Procida (3):
  Drop traversable_base::traverse method.
  Fix inheritance of scope_decl::insert_member_decl
  Enable Clang's -Werror-overloaded-virtual.

 configure.ac           |  6 ------
 include/abg-ir.h       |  3 +--
 include/abg-traverse.h | 21 ++++++---------------
 src/Makefile.am        |  1 -
 src/abg-ir.cc          |  2 +-
 src/abg-traverse.cc    | 43 ------------------------------------------
 6 files changed, 8 insertions(+), 68 deletions(-)
 delete mode 100644 src/abg-traverse.cc

Comments

Dodji Seketeli July 27, 2020, 4:27 p.m. UTC | #1
Giuliano Procida <gprocida@google.com> a écrit:

> Hi.
>
> This short series fixes a known issue with Clang compilation of
> libabigail and error-overloaded-virtual warnings.
>
> The first patch removes an unused function.
> The second patch fixes a latent bug detected by the warning.
> The third patch enables the warning.

This should hopefully be addressed now.  So I guess the bug can be
closed now.

Thanks!

Cheers,