Message ID | 20200619163924.207852-1-gprocida@google.com |
---|---|
Headers |
Return-Path: <libabigail-bounces@sourceware.org> X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 07F7C3840C23; Fri, 19 Jun 2020 16:39:35 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 07F7C3840C23 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1592584775; bh=T4CJcC+b6dJXlDQh1K7bz0a/iL1adCnV1+gKu3NNZUI=; h=Date:Subject:To:List-Id:List-Unsubscribe:List-Archive:List-Help: List-Subscribe:From:Reply-To:Cc:From; b=NBa71sLZWlzHYtWeKk+czGQdrPxncM6iFpPJoU/iYJfeCeR89vrx1TS6gEgVVHOGs hEdB6MwncEL14hZjIBjUmigo0+B4SxTr7Eql8kKSKADK3dmQm4ySAKk1iuAcIeAX/5 VYkJ3X4Mt8oaiUrkbtC3MCXnx9mx9hOIkqqT/T6Y= X-Original-To: libabigail@sourceware.org Delivered-To: libabigail@sourceware.org Received: from mail-yb1-xb49.google.com (mail-yb1-xb49.google.com [IPv6:2607:f8b0:4864:20::b49]) by sourceware.org (Postfix) with ESMTPS id 19CE5386F80C for <libabigail@sourceware.org>; Fri, 19 Jun 2020 16:39:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 19CE5386F80C Received: by mail-yb1-xb49.google.com with SMTP id 186so10518823yby.19 for <libabigail@sourceware.org>; Fri, 19 Jun 2020 09:39:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:message-id:mime-version:subject:from:to:cc; bh=T4CJcC+b6dJXlDQh1K7bz0a/iL1adCnV1+gKu3NNZUI=; b=sIxnjqQJuKKKmYGyZ6HwOOM1HRBUYpHV3GQ0M1+neQIVzjOm4kKhXKIF2AtuT1vfyC nsf3ADbC9X/Q0N+ZgqZeBBG3iEiCscuRtDcI/sMHR+Q2pjYwB30yY/9CafLh5aQPmN6t 7+j771EcS8Expbg8v3niMCm4MYkQolwBU+lFXPkiS8KS4kiCHQUPuYozkZy7mWgivzwW XosgDmGllxMeuNi/gNMzKDBgnLYYJIBQaEMfvp07NO9H01eTvjH5gIkqaaj0F4qRMzVS lu/ABg0Y3E8pxOvMFz4HjvUZGS+bDugRFx6FmgSJ/uA8shM7DGD4ksLk4fkZd21+5Z2F 76sw== X-Gm-Message-State: AOAM531WlqC/RZwnUEVfNwZ/VStcpHFPRV5Luhe8G7IB4C34muPRTUIY 6cfByEWrU93NJ0zw2NbuTTcewUH4gG19s3834U+T15c8Qhg/WCNXRfXclygOMIME6V59AN1XTtU 1Te49TamLdnns+L/ludkyTHnT1WhnAAlB0yLPY/CzlEqcaZodfhKGiFlicjUsV4EQ6TzYjmI= X-Google-Smtp-Source: ABdhPJxRYUtLdBIuzN9N+W+2Q52px6l3Xh6B0tTGMM+hdBrhEyoTovjDrh2Dtayhsb13Un7eM94ldg8dI5jGVQ== X-Received: by 2002:a25:7bc1:: with SMTP id w184mr7317762ybc.240.1592584772566; Fri, 19 Jun 2020 09:39:32 -0700 (PDT) Date: Fri, 19 Jun 2020 17:39:22 +0100 Message-Id: <20200619163924.207852-1-gprocida@google.com> Mime-Version: 1.0 X-Mailer: git-send-email 2.27.0.111.gc72c7da667-goog Subject: [PATCH 0/2] Type identity clean-ups To: libabigail@sourceware.org Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-18.9 required=5.0 tests=BAYES_00, DKIMWL_WL_MED, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libabigail@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Mailing list of the Libabigail project <libabigail.sourceware.org> List-Unsubscribe: <http://sourceware.org/mailman/options/libabigail>, <mailto:libabigail-request@sourceware.org?subject=unsubscribe> List-Archive: <https://sourceware.org/pipermail/libabigail/> List-Help: <mailto:libabigail-request@sourceware.org?subject=help> List-Subscribe: <http://sourceware.org/mailman/listinfo/libabigail>, <mailto:libabigail-request@sourceware.org?subject=subscribe> From: Giuliano Procida via Libabigail <libabigail@sourceware.org> Reply-To: Giuliano Procida <gprocida@google.com> Cc: maennich@google.com, kernel-team@android.com, gprocida@google.com Errors-To: libabigail-bounces@sourceware.org Sender: "Libabigail" <libabigail-bounces@sourceware.org> |
Series |
Type identity clean-ups
|
|
Message
Giuliano Procida
June 19, 2020, 4:39 p.m. UTC
Hi Dodji. I've been looking at how libabigail compares types and decides two types are the same. These are a couple of incidental commits prompted by this investigation. The commit message of the second patch below makes a couple of statements as if they were true, but they are in fact somewhat speculative. Please review with this in mind. Thanks! Regards, Giuliano. Giuliano Procida (2): abg-ir.cc: Remove unused re_canonicalize function. Use pointers not strings in type graph comparison. include/abg-fwd.h | 3 - include/abg-ir.h | 5 - src/abg-ir.cc | 37 +- .../PR25058-liblttng-ctl-report-1.txt | 239 +++++- ....el7.x86_64-multiple-sym-vers-report-0.txt | 2 +- ...l7.x86_64-0.12.8-1.el7.x86_64-report-2.txt | 734 ++++++++++++------ ...l7.x86_64-0.12.8-1.el7.x86_64-report-3.txt | 162 +++- 7 files changed, 909 insertions(+), 273 deletions(-)
Comments
On Fri, Jun 19, 2020 at 05:39:22PM +0100, Giuliano Procida wrote: >Hi Dodji. > >I've been looking at how libabigail compares types and decides two >types are the same. These are a couple of incidental commits prompted >by this investigation. > >The commit message of the second patch below makes a couple of >statements as if they were true, but they are in fact somewhat >speculative. Please review with this in mind. Thanks! > >Regards, >Giuliano. Those look generally fine to me, would defer to Dodji for final judgement. Acked-by: Matthias Maennich <maennich@google.com> Cheers, Matthias > >Giuliano Procida (2): > abg-ir.cc: Remove unused re_canonicalize function. > Use pointers not strings in type graph comparison. > > include/abg-fwd.h | 3 - > include/abg-ir.h | 5 - > src/abg-ir.cc | 37 +- > .../PR25058-liblttng-ctl-report-1.txt | 239 +++++- > ....el7.x86_64-multiple-sym-vers-report-0.txt | 2 +- > ...l7.x86_64-0.12.8-1.el7.x86_64-report-2.txt | 734 ++++++++++++------ > ...l7.x86_64-0.12.8-1.el7.x86_64-report-3.txt | 162 +++- > 7 files changed, 909 insertions(+), 273 deletions(-) > >-- >2.27.0.111.gc72c7da667-goog >