mbox series

[00/11] Add incomplete enum support.

Message ID 20200610115940.26035-1-gprocida@google.com
Headers show
Series Add incomplete enum support. | expand

Message

Giuliano Procida June 10, 2020, 11:59 a.m. UTC
Hi. This is my latest iteration of incomplete enum support. I think
more help is needed for abg-reader.cc.

Mirror: https://github.com/myxoid/libabigail/commits/incomplete-enums.

Dodji Seketeli (2):
  Add invariant to enum_type_decl::set_is_declaration_only
  Support constructing opaque types for enums

Giuliano Procida (9):
  Missing initialisation of source local variable.
  Improve code comments and whitespace.
  Refactor d.context() as ctxt in report(enum_diff).
  Tidy build_enum_type state variables.
  Rename declaration-definition change category.
  Support incomplete enums in core and diff code.
  Support declaration-only enums in DWARF reader.
  Add declaration-only enums to XML reader/writer.
  Add tests for declaration-only enums.

 include/abg-comp-filter.h                     |   7 +
 include/abg-comparison.h                      |  10 +-
 include/abg-fwd.h                             |  26 +-
 include/abg-ir.h                              |  15 +
 src/abg-comp-filter.cc                        |  80 +++-
 src/abg-comparison.cc                         |  18 +-
 src/abg-default-reporter.cc                   |  32 +-
 src/abg-dwarf-reader.cc                       | 390 ++++++++++++++++--
 src/abg-ir.cc                                 | 200 ++++++++-
 src/abg-leaf-reporter.cc                      |   2 +-
 src/abg-reader.cc                             |   4 +
 src/abg-writer.cc                             |  17 +
 tests/data/Makefile.am                        |   5 +
 .../test-decl-enum-report.txt                 |  17 +
 .../test-abidiff-exit/test-decl-enum-v0.c     |   5 +
 .../test-abidiff-exit/test-decl-enum-v0.o     | Bin 0 -> 3048 bytes
 .../test-abidiff-exit/test-decl-enum-v1.c     |   5 +
 .../test-abidiff-exit/test-decl-enum-v1.o     | Bin 0 -> 3048 bytes
 tests/test-abidiff-exit.cc                    |   9 +
 19 files changed, 775 insertions(+), 67 deletions(-)
 create mode 100644 tests/data/test-abidiff-exit/test-decl-enum-report.txt
 create mode 100644 tests/data/test-abidiff-exit/test-decl-enum-v0.c
 create mode 100644 tests/data/test-abidiff-exit/test-decl-enum-v0.o
 create mode 100644 tests/data/test-abidiff-exit/test-decl-enum-v1.c
 create mode 100644 tests/data/test-abidiff-exit/test-decl-enum-v1.o

Comments

Dodji Seketeli July 1, 2020, 1:36 p.m. UTC | #1
Hello,

Giuliano Procida <gprocida@google.com> a écrit:

> Hi. This is my latest iteration of incomplete enum support. I think
> more help is needed for abg-reader.cc.
>
> Mirror: https://github.com/myxoid/libabigail/commits/incomplete-enums.

Thank you for working on this.

I am looking at this patchset at the moment.  At this point, patches of
the set that are good to be applied are going to be applied
independantly.  When they lack a ChangeLog part in the commit log, I am
adding that.  If I see changes that are trivial, I'll make them and
apply the patch.  If there are more discussions to be held on a patch,
well, we'll do that.

I hope that is okay.

Thanks!

[...]

Cheers,
Giuliano Procida July 1, 2020, 3:18 p.m. UTC | #2
Hi Dodji.

On Wed, 1 Jul 2020 at 14:36, Dodji Seketeli <dodji@seketeli.org> wrote:
>
> Hello,
>
> Giuliano Procida <gprocida@google.com> a écrit:
>
> > Hi. This is my latest iteration of incomplete enum support. I think
> > more help is needed for abg-reader.cc.
> >
> > Mirror: https://github.com/myxoid/libabigail/commits/incomplete-enums.
>
> Thank you for working on this.
>
> I am looking at this patchset at the moment.  At this point, patches of
> the set that are good to be applied are going to be applied
> independantly.  When they lack a ChangeLog part in the commit log, I am
> adding that.  If I see changes that are trivial, I'll make them and
> apply the patch.  If there are more discussions to be held on a patch,
> well, we'll do that.
>
> I hope that is okay.

That's fine with me. I don't think I've made any other changes since I
posted this.

I've just been rebasing (and updating the mirror) as other changes come in.

Regards,
Giuliano.

> Thanks!
>
> [...]
>
> Cheers,
>
> --
>                 Dodji