Message ID | 20200610115940.26035-1-gprocida@google.com |
---|---|
Headers |
Return-Path: <libabigail-bounces@sourceware.org> X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 6C94B386EC42; Wed, 10 Jun 2020 11:59:46 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 6C94B386EC42 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1591790386; bh=TkY0xC9KocVEXULPE48qAXDITiTVMpoGs63b29wSR88=; h=Date:Subject:To:List-Id:List-Unsubscribe:List-Archive:List-Help: List-Subscribe:From:Reply-To:Cc:From; b=JRxIQd1v3Y2qkUMoenaS1iGN3wc863Ecu1PkwoJ9q5HJDzuChwxblAH8XaygrNKwK ZKhdpU6KifJBO0oXqAeYF/kseaGojtSdT1T8mbtpb/MMTnCwXiamV9AP/ezfAXpN1I InB1V1+buVLG/HeZ82O/Q7g4ztMp9DH7hEJHhX3w= X-Original-To: libabigail@sourceware.org Delivered-To: libabigail@sourceware.org Received: from mail-qt1-x849.google.com (mail-qt1-x849.google.com [IPv6:2607:f8b0:4864:20::849]) by sourceware.org (Postfix) with ESMTPS id 0D6A83858D35 for <libabigail@sourceware.org>; Wed, 10 Jun 2020 11:59:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 0D6A83858D35 Received: by mail-qt1-x849.google.com with SMTP id p9so1632198qtn.5 for <libabigail@sourceware.org>; Wed, 10 Jun 2020 04:59:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:message-id:mime-version:subject:from:to:cc; bh=TkY0xC9KocVEXULPE48qAXDITiTVMpoGs63b29wSR88=; b=GUvV1xmT7M0yb4rmVlbJotgtmfjESeZYbBChVb0ngJ+hvn8atQDQC2I8aWt/Ot3KFK +HJrG0TgL8I02EuWKDZcgpAQ2eFm7y42sWkRhFV+rHjsuT2Df0rSa6bRRUAljZ8hZ6En nhXL62HHPKOVN/H94rPQyil2bHud6mKDaZuby9ejRsnmuT4HpJV5oH7QBXboH2Xg7ZL5 9iy4Hl+uu7HhD/1n/zotvY2/Mw3XZjIrgVDDaobL328MbIn5TZPCAN/3Xy8Nw5IplxMU 6KMigw1Bgd5fEEJZUdJoQR9BfAcBc5dFNMXJiuNVX1RJkSPlf/R4ItxlUCC48o7NJQVh huMQ== X-Gm-Message-State: AOAM532owtEEidd0DSGD5zkhGZZGshYA0WHzEq+cZYYUh+z4DbeDzMHO 5ECOnQi+cu9eL+GyzwiOK3UqaoMtTQ3XCrpRykna3IkQNhxoxATA9KAYApmnkhoC9EQ9mDQezHW wfrgold7S0XAdy8MPf9Wrg86n7rfq9AUIZk8Eyw7373aPTIhRkTWSIoFmc+8Cp9IS7vv4jNo= X-Google-Smtp-Source: ABdhPJzOCCj1ZPxlO1E5W5DGMyU0JMsL81TGoIcq0+7Mbd1/k/zpMviiuGnBE47LvsAlUSgZ5i/YTtYIf9ux7w== X-Received: by 2002:ad4:4725:: with SMTP id l5mr2873088qvz.120.1591790383416; Wed, 10 Jun 2020 04:59:43 -0700 (PDT) Date: Wed, 10 Jun 2020 12:59:29 +0100 Message-Id: <20200610115940.26035-1-gprocida@google.com> Mime-Version: 1.0 X-Mailer: git-send-email 2.27.0.278.ge193c7cf3a9-goog Subject: [PATCH 00/11] Add incomplete enum support. To: libabigail@sourceware.org Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-18.3 required=5.0 tests=BAYES_00, DKIMWL_WL_MED, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libabigail@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Mailing list of the Libabigail project <libabigail.sourceware.org> List-Unsubscribe: <http://sourceware.org/mailman/options/libabigail>, <mailto:libabigail-request@sourceware.org?subject=unsubscribe> List-Archive: <https://sourceware.org/pipermail/libabigail/> List-Help: <mailto:libabigail-request@sourceware.org?subject=help> List-Subscribe: <http://sourceware.org/mailman/listinfo/libabigail>, <mailto:libabigail-request@sourceware.org?subject=subscribe> From: Giuliano Procida via Libabigail <libabigail@sourceware.org> Reply-To: Giuliano Procida <gprocida@google.com> Cc: kernel-team@android.com, gprocida@google.com Errors-To: libabigail-bounces@sourceware.org Sender: "Libabigail" <libabigail-bounces@sourceware.org> |
Series |
Add incomplete enum support.
|
|
Message
Giuliano Procida
June 10, 2020, 11:59 a.m. UTC
Hi. This is my latest iteration of incomplete enum support. I think more help is needed for abg-reader.cc. Mirror: https://github.com/myxoid/libabigail/commits/incomplete-enums. Dodji Seketeli (2): Add invariant to enum_type_decl::set_is_declaration_only Support constructing opaque types for enums Giuliano Procida (9): Missing initialisation of source local variable. Improve code comments and whitespace. Refactor d.context() as ctxt in report(enum_diff). Tidy build_enum_type state variables. Rename declaration-definition change category. Support incomplete enums in core and diff code. Support declaration-only enums in DWARF reader. Add declaration-only enums to XML reader/writer. Add tests for declaration-only enums. include/abg-comp-filter.h | 7 + include/abg-comparison.h | 10 +- include/abg-fwd.h | 26 +- include/abg-ir.h | 15 + src/abg-comp-filter.cc | 80 +++- src/abg-comparison.cc | 18 +- src/abg-default-reporter.cc | 32 +- src/abg-dwarf-reader.cc | 390 ++++++++++++++++-- src/abg-ir.cc | 200 ++++++++- src/abg-leaf-reporter.cc | 2 +- src/abg-reader.cc | 4 + src/abg-writer.cc | 17 + tests/data/Makefile.am | 5 + .../test-decl-enum-report.txt | 17 + .../test-abidiff-exit/test-decl-enum-v0.c | 5 + .../test-abidiff-exit/test-decl-enum-v0.o | Bin 0 -> 3048 bytes .../test-abidiff-exit/test-decl-enum-v1.c | 5 + .../test-abidiff-exit/test-decl-enum-v1.o | Bin 0 -> 3048 bytes tests/test-abidiff-exit.cc | 9 + 19 files changed, 775 insertions(+), 67 deletions(-) create mode 100644 tests/data/test-abidiff-exit/test-decl-enum-report.txt create mode 100644 tests/data/test-abidiff-exit/test-decl-enum-v0.c create mode 100644 tests/data/test-abidiff-exit/test-decl-enum-v0.o create mode 100644 tests/data/test-abidiff-exit/test-decl-enum-v1.c create mode 100644 tests/data/test-abidiff-exit/test-decl-enum-v1.o
Comments
Hello, Giuliano Procida <gprocida@google.com> a écrit: > Hi. This is my latest iteration of incomplete enum support. I think > more help is needed for abg-reader.cc. > > Mirror: https://github.com/myxoid/libabigail/commits/incomplete-enums. Thank you for working on this. I am looking at this patchset at the moment. At this point, patches of the set that are good to be applied are going to be applied independantly. When they lack a ChangeLog part in the commit log, I am adding that. If I see changes that are trivial, I'll make them and apply the patch. If there are more discussions to be held on a patch, well, we'll do that. I hope that is okay. Thanks! [...] Cheers,
Hi Dodji. On Wed, 1 Jul 2020 at 14:36, Dodji Seketeli <dodji@seketeli.org> wrote: > > Hello, > > Giuliano Procida <gprocida@google.com> a écrit: > > > Hi. This is my latest iteration of incomplete enum support. I think > > more help is needed for abg-reader.cc. > > > > Mirror: https://github.com/myxoid/libabigail/commits/incomplete-enums. > > Thank you for working on this. > > I am looking at this patchset at the moment. At this point, patches of > the set that are good to be applied are going to be applied > independantly. When they lack a ChangeLog part in the commit log, I am > adding that. If I see changes that are trivial, I'll make them and > apply the patch. If there are more discussions to be held on a patch, > well, we'll do that. > > I hope that is okay. That's fine with me. I don't think I've made any other changes since I posted this. I've just been rebasing (and updating the mirror) as other changes come in. Regards, Giuliano. > Thanks! > > [...] > > Cheers, > > -- > Dodji