From patchwork Mon May 4 16:24:36 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Giuliano Procida X-Patchwork-Id: 39214 From: gprocida@google.com (Giuliano Procida) Date: Mon, 4 May 2020 17:24:36 +0100 Subject: [PATCH 0/3] Add an option to give finer-grained control of offset reporting. Message-ID: <20200504162439.74028-1-gprocida@google.com> This is from an internal request. I'm pretty happy with the core changes. The new command line option and plumbing are what I think deserve more scrutiny. Do we want a more generic way of manipulating the change categories? This change takes us up to 3 flags. Regards, Giuliano. Giuliano Procida (3): abidiff.cc: tidy using directives and declarations Allow offset changes to be considered harmless. Add abidiff --offset-changes-are-harmless tests. include/abg-comparison.h | 35 ++++++---- src/abg-comp-filter.cc | 14 ++-- src/abg-comparison.cc | 15 +++- src/abg-reporter-priv.cc | 17 +++-- tests/data/Makefile.am | 8 +++ .../test-offset-harm-report0.txt | 15 ++++ .../test-offset-harm-report1.txt | 20 ++++++ .../test-offset-harm-report2.txt | 3 + .../test-offset-harm-report3.txt | 14 ++++ .../test-abidiff-exit/test-offset-harm-v0.c | 7 ++ .../test-abidiff-exit/test-offset-harm-v0.o | Bin 0 -> 2872 bytes .../test-abidiff-exit/test-offset-harm-v1.c | 7 ++ .../test-abidiff-exit/test-offset-harm-v1.o | Bin 0 -> 2864 bytes tests/test-abidiff-exit.cc | 36 ++++++++++ tools/abidiff.cc | 64 +++++++++++------- 15 files changed, 202 insertions(+), 53 deletions(-) create mode 100644 tests/data/test-abidiff-exit/test-offset-harm-report0.txt create mode 100644 tests/data/test-abidiff-exit/test-offset-harm-report1.txt create mode 100644 tests/data/test-abidiff-exit/test-offset-harm-report2.txt create mode 100644 tests/data/test-abidiff-exit/test-offset-harm-report3.txt create mode 100644 tests/data/test-abidiff-exit/test-offset-harm-v0.c create mode 100644 tests/data/test-abidiff-exit/test-offset-harm-v0.o create mode 100644 tests/data/test-abidiff-exit/test-offset-harm-v1.c create mode 100644 tests/data/test-abidiff-exit/test-offset-harm-v1.o