mbox series

[0/6] Clean-ups

Message ID 20200429175133.19814-1-gprocida@google.com
Headers show
Series Clean-ups | expand

Message

Giuliano Procida April 29, 2020, 5:51 p.m. UTC
These are almost all independent. There's just 1 line of code ending:

? true : false;;

Regards,
Giuliano.

Giuliano Procida (6):
  Tabify code indentation.
  Remove excess whitespace.
  Remove stray semicolons.
  Eliminate redundant conditional operators.
  Make set_drops_artifact_from_ir non-const.
  Hoist some common expressions evaluating offsets.

 include/abg-diff-utils.h    |   2 +-
 include/abg-fwd.h           |   2 +-
 include/abg-suppression.h   |   2 +-
 src/abg-comparison.cc       |   6 +-
 src/abg-corpus.cc           |   4 +-
 src/abg-default-reporter.cc |   2 +-
 src/abg-dwarf-reader.cc     | 143 +++++++++++++++++-----------------
 src/abg-ir.cc               |   4 +-
 src/abg-reader.cc           |  20 ++---
 src/abg-suppression.cc      |  30 +++-----
 src/abg-tools-utils.cc      |  12 +--
 src/abg-writer.cc           |  42 +++++-----
 tools/abidiff.cc            |   2 +-
 tools/abipkgdiff.cc         | 148 ++++++++++++++++++------------------
 14 files changed, 205 insertions(+), 214 deletions(-)

Comments

Matthias Maennich April 30, 2020, 9:34 p.m. UTC | #1
On Wed, Apr 29, 2020 at 06:51:27PM +0100, Android Kernel Team wrote:
>These are almost all independent. There's just 1 line of code ending:
>
>? true : false;;
>
>Regards,
>Giuliano.

Hi Giuliano!

Those patches look all good to me and surely give my OCD a soothing
feeling :-)

Yet I would like to hold back at least 1/6 as it will collide with the
refactoring work I am currently doing in and around abg-corpus and
abg-dwarf-reader.

Nevertheless, for the whole series:
Reviewed-by: Matthias Maennich <maennich@google.com>

Cheers,
Matthias

>
>Giuliano Procida (6):
>  Tabify code indentation.
>  Remove excess whitespace.
>  Remove stray semicolons.
>  Eliminate redundant conditional operators.
>  Make set_drops_artifact_from_ir non-const.
>  Hoist some common expressions evaluating offsets.
>
> include/abg-diff-utils.h    |   2 +-
> include/abg-fwd.h           |   2 +-
> include/abg-suppression.h   |   2 +-
> src/abg-comparison.cc       |   6 +-
> src/abg-corpus.cc           |   4 +-
> src/abg-default-reporter.cc |   2 +-
> src/abg-dwarf-reader.cc     | 143 +++++++++++++++++-----------------
> src/abg-ir.cc               |   4 +-
> src/abg-reader.cc           |  20 ++---
> src/abg-suppression.cc      |  30 +++-----
> src/abg-tools-utils.cc      |  12 +--
> src/abg-writer.cc           |  42 +++++-----
> tools/abidiff.cc            |   2 +-
> tools/abipkgdiff.cc         | 148 ++++++++++++++++++------------------
> 14 files changed, 205 insertions(+), 214 deletions(-)
>
>-- 
>2.26.2.303.gf8c07b1a785-goog
>
>
Giuliano Procida May 1, 2020, 3:45 p.m. UTC | #2
I'll drop the tabify patch and repost the other with any review updates.

Thanks,
Giuliano.

On Thu, 30 Apr 2020 at 22:34, Matthias Maennich <maennich@google.com> wrote:
>
> On Wed, Apr 29, 2020 at 06:51:27PM +0100, Android Kernel Team wrote:
> >These are almost all independent. There's just 1 line of code ending:
> >
> >? true : false;;
> >
> >Regards,
> >Giuliano.
>
> Hi Giuliano!
>
> Those patches look all good to me and surely give my OCD a soothing
> feeling :-)
>
> Yet I would like to hold back at least 1/6 as it will collide with the
> refactoring work I am currently doing in and around abg-corpus and
> abg-dwarf-reader.
>
> Nevertheless, for the whole series:
> Reviewed-by: Matthias Maennich <maennich@google.com>
>
> Cheers,
> Matthias
>
> >
> >Giuliano Procida (6):
> >  Tabify code indentation.
> >  Remove excess whitespace.
> >  Remove stray semicolons.
> >  Eliminate redundant conditional operators.
> >  Make set_drops_artifact_from_ir non-const.
> >  Hoist some common expressions evaluating offsets.
> >
> > include/abg-diff-utils.h    |   2 +-
> > include/abg-fwd.h           |   2 +-
> > include/abg-suppression.h   |   2 +-
> > src/abg-comparison.cc       |   6 +-
> > src/abg-corpus.cc           |   4 +-
> > src/abg-default-reporter.cc |   2 +-
> > src/abg-dwarf-reader.cc     | 143 +++++++++++++++++-----------------
> > src/abg-ir.cc               |   4 +-
> > src/abg-reader.cc           |  20 ++---
> > src/abg-suppression.cc      |  30 +++-----
> > src/abg-tools-utils.cc      |  12 +--
> > src/abg-writer.cc           |  42 +++++-----
> > tools/abidiff.cc            |   2 +-
> > tools/abipkgdiff.cc         | 148 ++++++++++++++++++------------------
> > 14 files changed, 205 insertions(+), 214 deletions(-)
> >
> >--
> >2.26.2.303.gf8c07b1a785-goog
> >
> >
Giuliano Procida May 1, 2020, 3:51 p.m. UTC | #3
Hi.

These are almost all independent. There's just 1 line of code ending
"? true : false;;" so patches and 2 and 3 cannot be reordered without
manual intervention.

This is a repost without the tabification commit, to avoid colliding
with ongoing work by Matthias.

Regards,
Giuliano.

Giuliano Procida (5):
  Remove excess whitespace.
  Remove stray semicolons.
  Eliminate redundant conditional operators.
  Make set_drops_artifact_from_ir non-const.
  Hoist some common expressions evaluating offsets.

 include/abg-diff-utils.h    |  2 +-
 include/abg-fwd.h           |  2 +-
 include/abg-suppression.h   |  2 +-
 src/abg-comparison.cc       |  6 +++---
 src/abg-corpus.cc           |  4 ++--
 src/abg-default-reporter.cc |  2 +-
 src/abg-dwarf-reader.cc     |  5 ++---
 src/abg-ir.cc               |  4 ++--
 src/abg-reader.cc           | 20 ++++++++++----------
 src/abg-suppression.cc      | 30 +++++++++++-------------------
 10 files changed, 34 insertions(+), 43 deletions(-)