diff mbox

gnu: hurd: Remove inputs no longer needed and move configure flags.

Message ID e33375f5-0440-19c5-c4cd-da401e4c94b3@gmail.com
State New
Headers show

Commit Message

Manolis Ragkousis June 7, 2016, noon UTC
Hello,

This is another patch from wip-hurd modified for core-updates.

Thank you,
Manolis

Comments

Efraim Flashner June 7, 2016, 12:19 p.m. UTC | #1
On Tue, Jun 07, 2016 at 03:00:44PM +0300, Manolis Ragkousis wrote:
> Hello,
> 
> This is another patch from wip-hurd modified for core-updates.
> 
> Thank you,
> Manolis

> From 984de2d0e26b1ddd860d0468453ee8679ced756d Mon Sep 17 00:00:00 2001
> From: Manolis Ragkousis <manolis837@gmail.com>
> Date: Tue, 7 Jun 2016 14:45:55 +0300
> Subject: [PATCH] gnu: hurd: Remove inputs no longer needed and move configure
>  flags.
> 
> * gnu/packages/hurd.scm (hurd-minimal)[arguments]: Move configure-flags from here..
>   (hurd-headers)[arguments]: ..to here.
>   (hurd-headers, hurd-minimal)[native-inputs]: Remove "autoconf".
> ---
>  gnu/packages/hurd.scm | 82 ++++++++++++++++++++++-----------------------------
>  1 file changed, 35 insertions(+), 47 deletions(-)
> 
> diff --git a/gnu/packages/hurd.scm b/gnu/packages/hurd.scm
> index 2b2e162..72e4061 100644
> --- a/gnu/packages/hurd.scm
> +++ b/gnu/packages/hurd.scm
> @@ -21,12 +21,12 @@
>    #:use-module (guix download)
>    #:use-module (guix packages)
>    #:use-module (gnu packages)
> +  #:use-module (guix utils)
>    #:use-module (guix build-system gnu)
>    #:use-module (guix build-system trivial)
>    #:use-module (gnu packages flex)
>    #:use-module (gnu packages bison)
>    #:use-module (gnu packages perl)
> -  #:use-module (gnu packages autotools)
>    #:use-module (gnu packages base)
>    #:use-module (guix git-download))
>  
> @@ -108,11 +108,7 @@ communication.")
>                  "1pbc4aqgzxvkgivw80ghp3w755cl0fwxmg357vq7chimj64jk78d"))))
>      (build-system gnu-build-system)
>      (native-inputs
> -     `(;; Autoconf shouldn't be necessary but there seems to be a bug in the
> -       ;; build system triggering its use.
> -       ("autoconf" ,autoconf)
> -
> -       ("mig" ,mig)))
> +     `(("mig" ,mig)))
>      (arguments
>       `(#:phases (alist-replace
>                   'install
> @@ -122,10 +118,20 @@ communication.")
>  
>         #:configure-flags '(;; Pretend we're on GNU/Hurd; 'configure' wants
>                             ;; that.
> -                           "--build=i686-pc-gnu"
> +                           ,@(if (%current-target-system)
> +                                  '()
> +                                  '("--host=i586-pc-gnu"))
>  
>                             ;; Reduce set of dependencies.
> -                           "--without-parted")
> +                           "--without-parted"
> +                           "--disable-ncursesw"
> +                           "--disable-test"
> +                           "--without-libbz2"
> +                           "--without-libz"
> +                           "--without-parted"

you have "--withput-parted" twice in this list

> +                           ;; Skip the clnt_create check because it expects
> +                           ;; a working glibc causing a circular dependency.
> +                           "ac_cv_search_clnt_create=no")
>  
> 

That's all I have from the quick look-through
Manolis Ragkousis June 7, 2016, 12:42 p.m. UTC | #2
Hello Efraim,

On 06/07/16 15:19, Efraim Flashner wrote:
>>                             ;; Reduce set of dependencies.
>> -                           "--without-parted")
>> +                           "--without-parted"
>> +                           "--disable-ncursesw"
>> +                           "--disable-test"
>> +                           "--without-libbz2"
>> +                           "--without-libz"
>> +                           "--without-parted"
> 
> you have "--withput-parted" twice in this list

Oops, I missed that. I will update it and push the patch to core-updates
as it will not cause any rebuilds.

Thank you,
Manolis
Ludovic Courtès June 7, 2016, 1:43 p.m. UTC | #3
Manolis Ragkousis <manolis837@gmail.com> skribis:

> From 984de2d0e26b1ddd860d0468453ee8679ced756d Mon Sep 17 00:00:00 2001
> From: Manolis Ragkousis <manolis837@gmail.com>
> Date: Tue, 7 Jun 2016 14:45:55 +0300
> Subject: [PATCH] gnu: hurd: Remove inputs no longer needed and move configure
>  flags.
>
> * gnu/packages/hurd.scm (hurd-minimal)[arguments]: Move configure-flags from here..
>   (hurd-headers)[arguments]: ..to here.

They are not just moved, there’s also the change for --host.  It would
be great if, for clarity, you made one patch for the --host change (like
you did before), one for the actual move, and…

>   (hurd-headers, hurd-minimal)[native-inputs]: Remove "autoconf".

… another one for this.

Does that sound reasonable?

Apart from this nitpicking, it looks good to me, thanks!

Ludo’.
diff mbox

Patch

From 984de2d0e26b1ddd860d0468453ee8679ced756d Mon Sep 17 00:00:00 2001
From: Manolis Ragkousis <manolis837@gmail.com>
Date: Tue, 7 Jun 2016 14:45:55 +0300
Subject: [PATCH] gnu: hurd: Remove inputs no longer needed and move configure
 flags.

* gnu/packages/hurd.scm (hurd-minimal)[arguments]: Move configure-flags from here..
  (hurd-headers)[arguments]: ..to here.
  (hurd-headers, hurd-minimal)[native-inputs]: Remove "autoconf".
---
 gnu/packages/hurd.scm | 82 ++++++++++++++++++++++-----------------------------
 1 file changed, 35 insertions(+), 47 deletions(-)

diff --git a/gnu/packages/hurd.scm b/gnu/packages/hurd.scm
index 2b2e162..72e4061 100644
--- a/gnu/packages/hurd.scm
+++ b/gnu/packages/hurd.scm
@@ -21,12 +21,12 @@ 
   #:use-module (guix download)
   #:use-module (guix packages)
   #:use-module (gnu packages)
+  #:use-module (guix utils)
   #:use-module (guix build-system gnu)
   #:use-module (guix build-system trivial)
   #:use-module (gnu packages flex)
   #:use-module (gnu packages bison)
   #:use-module (gnu packages perl)
-  #:use-module (gnu packages autotools)
   #:use-module (gnu packages base)
   #:use-module (guix git-download))
 
@@ -108,11 +108,7 @@  communication.")
                 "1pbc4aqgzxvkgivw80ghp3w755cl0fwxmg357vq7chimj64jk78d"))))
     (build-system gnu-build-system)
     (native-inputs
-     `(;; Autoconf shouldn't be necessary but there seems to be a bug in the
-       ;; build system triggering its use.
-       ("autoconf" ,autoconf)
-
-       ("mig" ,mig)))
+     `(("mig" ,mig)))
     (arguments
      `(#:phases (alist-replace
                  'install
@@ -122,10 +118,20 @@  communication.")
 
        #:configure-flags '(;; Pretend we're on GNU/Hurd; 'configure' wants
                            ;; that.
-                           "--build=i686-pc-gnu"
+                           ,@(if (%current-target-system)
+                                  '()
+                                  '("--host=i586-pc-gnu"))
 
                            ;; Reduce set of dependencies.
-                           "--without-parted")
+                           "--without-parted"
+                           "--disable-ncursesw"
+                           "--disable-test"
+                           "--without-libbz2"
+                           "--without-libz"
+                           "--without-parted"
+                           ;; Skip the clnt_create check because it expects
+                           ;; a working glibc causing a circular dependency.
+                           "ac_cv_search_clnt_create=no")
 
        #:tests? #f))
     (home-page "http://www.gnu.org/software/hurd/hurd.html")
@@ -140,46 +146,28 @@  Library and other user programs.")
     (name "hurd-minimal")
     (inputs `(("glibc-hurd-headers" ,glibc/hurd-headers)))
     (native-inputs
-     `(("autoconf" ,(autoconf-wrapper))
-       ("mig" ,mig)))
-
+     `(("mig" ,mig)))
     (arguments
-     `(#:phases (alist-replace
-                 'install
-                 (lambda* (#:key outputs #:allow-other-keys)
-                   (let ((out (assoc-ref outputs "out")))
-                     ;; We need to copy libihash.a to the output directory manually,
-                     ;; since there is no target for that in the makefile.
-                     (mkdir-p (string-append out "/include"))
-                     (copy-file "libihash/ihash.h"
-                                (string-append out "/include/ihash.h"))
-                     (mkdir-p (string-append out "/lib"))
-                     (copy-file "libihash/libihash.a"
-                                (string-append out "/lib/libihash.a"))
-                     #t))
-                 (alist-replace
-                  'build
-                  (lambda _
-                    (zero? (system* "make" "-Clibihash" "libihash.a")))
-                  (alist-cons-before
-                   'configure 'bootstrap
-                   (lambda _
-                     (zero? (system* "autoreconf" "-vfi")))
-                   %standard-phases)))
-       #:configure-flags '(;; Pretend we're on GNU/Hurd; 'configure' wants
-                           ;; that.
-                           "--host=i686-pc-gnu"
-
-                           ;; Reduce set of dependencies.
-                           "--disable-ncursesw"
-                           "--disable-test"
-                           "--without-libbz2"
-                           "--without-libz"
-                           "--without-parted"
-                           ;; Skip the clnt_create check because it expects
-                           ;; a working glibc causing a circular dependency.
-                           "ac_cv_search_clnt_create=no")
-       #:tests? #f))
+     (substitute-keyword-arguments (package-arguments hurd-headers)
+       ((#:phases _)
+        '(alist-replace
+          'install
+          (lambda* (#:key outputs #:allow-other-keys)
+            (let ((out (assoc-ref outputs "out")))
+              ;; We need to copy libihash.a to the output directory manually,
+              ;; since there is no target for that in the makefile.
+              (mkdir-p (string-append out "/include"))
+              (copy-file "libihash/ihash.h"
+                         (string-append out "/include/ihash.h"))
+              (mkdir-p (string-append out "/lib"))
+              (copy-file "libihash/libihash.a"
+                         (string-append out "/lib/libihash.a"))
+              #t))
+          (alist-replace
+           'build
+           (lambda _
+             (zero? (system* "make" "-Clibihash" "libihash.a")))
+           %standard-phases)))))
     (home-page "http://www.gnu.org/software/hurd/hurd.html")
     (synopsis "GNU Hurd libraries")
     (description
-- 
2.8.2