diff mbox

gnu: mesa: Enable floating point textures.

Message ID CAJ=RwfYaog43Hw10DkosXDeswTgs-i8FFbVhKWZBRR9Kb340bA@mail.gmail.com
State New
Headers show

Commit Message

David Thompson Nov. 13, 2016, 6:06 a.m. UTC
With this patch, I'm finally able to run programs that require OpenGL
3.0 when using a Nouveau powered GPU.  Floating point textures are
disabled by default in Mesa due to patent concerns.  I assume that
it's okay to include this in Guix because it's similar to how we
include lame despite MP3 being patent encumbered.  Please correct me
if I'm wrong! ;)

- Dave

Comments

Ludovic Courtès Nov. 13, 2016, 12:10 p.m. UTC | #1
"Thompson, David" <dthompson2@worcester.edu> skribis:

> With this patch, I'm finally able to run programs that require OpenGL
> 3.0 when using a Nouveau powered GPU.  Floating point textures are
> disabled by default in Mesa due to patent concerns.  I assume that
> it's okay to include this in Guix because it's similar to how we
> include lame despite MP3 being patent encumbered.  Please correct me
> if I'm wrong! ;)

The FSDG leaves it up to us to decide what to do:

  https://www.gnu.org/distros/free-system-distribution-guidelines.html#patents

I’d argue that it’s fine to enable the code in question, as was
discussed recently for another package.

> From 1a8de1631ec4d538bdb9caa8b623e8bb62a6c203 Mon Sep 17 00:00:00 2001
> From: David Thompson <davet@gnu.org>
> Date: Sat, 12 Nov 2016 17:59:16 -0500
> Subject: [PATCH] gnu: mesa: Enable floating point textures.
>
> * gnu/packages/gl.scm (mesa): Add --enable-texture-float to configure flags.

So if there are no objections, I think this can go in.

Per
<https://lists.gnu.org/archive/html/guix-devel/2016-10/msg00933.html>,
this would go to a new ‘staging’ branch.

Thanks,
Ludo’.
diff mbox

Patch

From 1a8de1631ec4d538bdb9caa8b623e8bb62a6c203 Mon Sep 17 00:00:00 2001
From: David Thompson <davet@gnu.org>
Date: Sat, 12 Nov 2016 17:59:16 -0500
Subject: [PATCH] gnu: mesa: Enable floating point textures.

* gnu/packages/gl.scm (mesa): Add --enable-texture-float to configure flags.
---
 gnu/packages/gl.scm | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/gnu/packages/gl.scm b/gnu/packages/gl.scm
index 50b474c..a663b3b 100644
--- a/gnu/packages/gl.scm
+++ b/gnu/packages/gl.scm
@@ -5,6 +5,7 @@ 
 ;;; Copyright © 2014, 2015, 2016 Mark H Weaver <mhw@netris.org>
 ;;; Copyright © 2016 ng0 <ng0@we.make.ritual.n0.is>
 ;;; Copyright © 2016 Ricardo Wurmus <rekado@elephly.net>
+;;; Copyright © 2016 David Thompson <davet@gnu.org>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -257,6 +258,9 @@  also known as DXTn or DXTC) for Mesa.")
          "--enable-gles2"
          "--enable-gbm"
          "--enable-shared-glapi"
+         ;; Without floating point texture support, drivers such as Nouveau
+         ;; are stuck at OpenGL 2.1 instead of OpenGL 3.0+.
+         "--enable-texture-float"
 
          ;; on non-intel systems, drop i915 and i965
          ;; from the default dri drivers
-- 
2.6.3