| Message ID | CAEwRq=p9kNUXzk+qiU61W_Xgj+Y-vd553Ld3PH_FcQAm5_Qr_w@mail.gmail.com |
|---|---|
| State | Dropped, archived |
| Headers | show |
On Sat, Jul 30, 2016 at 3:46 PM, Vincent Legoll <vincent.legoll@gmail.com> wrote: > Here is the accompanying patch for sinit to build properly under guix > > It will be submitted alongside the scm modifs. > > I may even try to make it upstream, as it's fairly straightforward... DONE: http://lists.suckless.org/hackers/1607/11719.html Dunno the responsiveness, so no ETA for an upstream release fixing this...
On Sat, Jul 30, 2016 at 06:19:47PM +0200, Vincent Legoll wrote: > On Sat, Jul 30, 2016 at 3:46 PM, Vincent Legoll > <vincent.legoll@gmail.com> wrote: > > Here is the accompanying patch for sinit to build properly under guix > > > > It will be submitted alongside the scm modifs. > > > > I may even try to make it upstream, as it's fairly straightforward... > > DONE: > http://lists.suckless.org/hackers/1607/11719.html > > Dunno the responsiveness, so no ETA for an upstream release fixing this... I noticed they replied with another suggestion: http://lists.suckless.org/hackers/1607/11720.html What happens if you set those variables in #:make-flags? There is an example in (gnu packages dvtm).
Leo Famulari <leo@famulari.name> writes: > On Sat, Jul 30, 2016 at 06:19:47PM +0200, Vincent Legoll wrote: >> On Sat, Jul 30, 2016 at 3:46 PM, Vincent Legoll >> <vincent.legoll@gmail.com> wrote: >> > Here is the accompanying patch for sinit to build properly under guix >> > >> > It will be submitted alongside the scm modifs. >> > >> > I may even try to make it upstream, as it's fairly straightforward... >> >> DONE: >> http://lists.suckless.org/hackers/1607/11719.html >> >> Dunno the responsiveness, so no ETA for an upstream release fixing this... > > I noticed they replied with another suggestion: > > http://lists.suckless.org/hackers/1607/11720.html > > What happens if you set those variables in #:make-flags? There is an > example in (gnu packages dvtm). > This should just work, Vincent. See the 'ii' package I sent today.
> This should just work, Vincent. See the 'ii' package I sent today.
D'oh !
It (#:make-flags?) was already there in the scm I submitted, but that
wasn't working when I tested it first time, maybe because I did not
know about guix environment at that time and tried the build it outside
of one...
I'll clean that up and resubmit properly...
Vincent Legoll <vincent.legoll@gmail.com> writes: > It (#:make-flags?) was already there in the scm I submitted, but that > wasn't working when I tested it first time, maybe because I did not > know about guix environment at that time and tried the build it outside > of one... > > I'll clean that up and resubmit properly... Thanks. When you resubmit this could you please give it a try to send it as a patch? If you’re using a git clone of the Guix repository you can make a local commit (in a separate branch) and then run git format-patch -1 to create a patch from the last commit. You could then attach the patch file to an email (or use “git send-email …” if you already have email sending configured on your machine). This would make things a little easier for us and make it more likely that your contribution is reviewed and merged sooner. Thanks again! ~~ Ricardo
diff -Nur sinit-1.0-orig/config.mk sinit-1.0/config.mk --- sinit-1.0-orig/config.mk 2015-06-16 11:37:07.000000000 +0200 +++ sinit-1.0/config.mk 2016-07-13 10:24:25.952000000 +0200 @@ -2,10 +2,10 @@ VERSION = 1.0 # paths -PREFIX = /usr/local +PREFIX ?= /usr/local MANPREFIX = $(PREFIX)/share/man -CC = cc +CC ?= cc LD = $(CC) CPPFLAGS = CFLAGS = -Wextra -Wall -Os