Message ID | CAEwRq=p9kNUXzk+qiU61W_Xgj+Y-vd553Ld3PH_FcQAm5_Qr_w@mail.gmail.com |
---|---|
State | Dropped, archived |
Headers |
Received: (qmail 74210 invoked by uid 89); 30 Jul 2016 13:46:30 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Checked: by ClamAV 0.99.1 on sourceware.org X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=BAYES_00, FREEMAIL_FROM, RP_MATCHES_RCVD, SPF_PASS autolearn=ham version=3.3.2 spammy=alongside, nur X-Spam-Status: No, score=-3.2 required=5.0 tests=BAYES_00, FREEMAIL_FROM, RP_MATCHES_RCVD, SPF_PASS autolearn=ham version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on sourceware.org X-Spam-Level: X-HELO: lists.gnu.org Received: from lists.gnu.org (HELO lists.gnu.org) (208.118.235.17) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Sat, 30 Jul 2016 13:46:20 +0000 Received: from localhost ([::1]:35648 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from <guix-devel-bounces+patchwork=sourceware.org@gnu.org>) id 1bTUao-0007NE-Bk for patchwork@sourceware.org; Sat, 30 Jul 2016 09:46:18 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34959) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from <vincent.legoll@gmail.com>) id 1bTUai-0007KE-2t for guix-devel@gnu.org; Sat, 30 Jul 2016 09:46:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from <vincent.legoll@gmail.com>) id 1bTUaf-0000ov-Qk for guix-devel@gnu.org; Sat, 30 Jul 2016 09:46:11 -0400 Received: from mail-qt0-x22e.google.com ([2607:f8b0:400d:c0d::22e]:34430) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <vincent.legoll@gmail.com>) id 1bTUaf-0000or-LE for guix-devel@gnu.org; Sat, 30 Jul 2016 09:46:09 -0400 Received: by mail-qt0-x22e.google.com with SMTP id u25so82396561qtb.1 for <guix-devel@gnu.org>; Sat, 30 Jul 2016 06:46:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to; bh=Bsq6VYmxTM5RdG2gVEIuhPAFovJbjCaOqmeVr2imoFA=; b=CjzeH8ga8nvmjxRJlE0Iri4LPETEiWRhHTR5HjPvns41Me6SnmngMjkNvxt3t8l4Ln 7xt1NxyJMjwSIkwmOOhJdwPV9+ovDDNEN9APHenY/qBHFg3a6BwZeKGf8hTy1uvrnEmh GdU9sJUHnKqNNYLIr/Csfe+mktCDyh2NDgqbHIVMzGP7g6QodKOSZ5HJqdRSIv+jTn6R ew7NkXL7f9AX31a7vWYEKzZeUM9ViHc3sggExclz+KIcrP4T5TcLL/QPoVWBPYHHTxu+ cRCL/cx2MObu0ebxibNVDgcysQHkoCTY14ZYB+6o0O6TRVrNsGmP3t18qihNHFwoUOj5 UE1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to; bh=Bsq6VYmxTM5RdG2gVEIuhPAFovJbjCaOqmeVr2imoFA=; b=R11OhL8LXobKHaVfS+Tja6ehYr8QOQ9QblLPTpptfOR61wm7K5qzAlytceiiKkVuqa ZcZrl07ixobsKLpXNiuTG9+i2GoPErPE6muYHrTKnQtlFKO1EcSuO8sP69atfgImJ+aw I4F0zOUrAggHtItr1oG9sYSETi4RItFG/59rCDijPiowTAniWnk9OFjKpErn+cHwW/Vp Lq5O7Jpl8Ev45+9m59jH8nPXF1MzmkRjXYfT+wSxF2euV3RVZPPU5rjOz/pwWFN3vAoG IJGtMoscmbpxWsDbjKfzatczfkUibFmk6SpV2aFJwh7l+rrQtx3qnVwGKXSc9Wd+iln2 tNng== X-Gm-Message-State: AEkoouv5Qtn8wfz5feX4v0EiLnnpvnF7Q8obEE1u5xPApgA7a/L/0IAMeOnbq7lnodbfE+wW1fdzqLcEbiq/CQ== X-Received: by 10.200.56.253 with SMTP id g58mr74293686qtc.28.1469886369030; Sat, 30 Jul 2016 06:46:09 -0700 (PDT) MIME-Version: 1.0 Received: by 10.237.34.44 with HTTP; Sat, 30 Jul 2016 06:46:08 -0700 (PDT) In-Reply-To: <CAEwRq=rhE0pZ8_1LphqD1Tu=SWBygjKuF0FDLbSTPbx1k_uEJw@mail.gmail.com> References: <CAEwRq=rhE0pZ8_1LphqD1Tu=SWBygjKuF0FDLbSTPbx1k_uEJw@mail.gmail.com> From: Vincent Legoll <vincent.legoll@gmail.com> Date: Sat, 30 Jul 2016 15:46:08 +0200 Message-ID: <CAEwRq=p9kNUXzk+qiU61W_Xgj+Y-vd553Ld3PH_FcQAm5_Qr_w@mail.gmail.com> Subject: Re: [PACKAGE] sinit To: guix-devel <guix-devel@gnu.org> Content-Type: multipart/mixed; boundary=001a113b820ee300490538da9695 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2607:f8b0:400d:c0d::22e X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." <guix-devel.gnu.org> List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>, <mailto:guix-devel-request@gnu.org?subject=unsubscribe> List-Archive: <http://lists.gnu.org/archive/html/guix-devel/> List-Post: <mailto:guix-devel@gnu.org> List-Help: <mailto:guix-devel-request@gnu.org?subject=help> List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>, <mailto:guix-devel-request@gnu.org?subject=subscribe> Errors-To: guix-devel-bounces+patchwork=sourceware.org@gnu.org Sender: "Guix-devel" <guix-devel-bounces+patchwork=sourceware.org@gnu.org> |
Commit Message
Vincent Legoll
July 30, 2016, 1:46 p.m. UTC
Here is the accompanying patch for sinit to build properly under guix It will be submitted alongside the scm modifs. I may even try to make it upstream, as it's fairly straightforward...
Comments
On Sat, Jul 30, 2016 at 3:46 PM, Vincent Legoll <vincent.legoll@gmail.com> wrote: > Here is the accompanying patch for sinit to build properly under guix > > It will be submitted alongside the scm modifs. > > I may even try to make it upstream, as it's fairly straightforward... DONE: http://lists.suckless.org/hackers/1607/11719.html Dunno the responsiveness, so no ETA for an upstream release fixing this...
On Sat, Jul 30, 2016 at 06:19:47PM +0200, Vincent Legoll wrote: > On Sat, Jul 30, 2016 at 3:46 PM, Vincent Legoll > <vincent.legoll@gmail.com> wrote: > > Here is the accompanying patch for sinit to build properly under guix > > > > It will be submitted alongside the scm modifs. > > > > I may even try to make it upstream, as it's fairly straightforward... > > DONE: > http://lists.suckless.org/hackers/1607/11719.html > > Dunno the responsiveness, so no ETA for an upstream release fixing this... I noticed they replied with another suggestion: http://lists.suckless.org/hackers/1607/11720.html What happens if you set those variables in #:make-flags? There is an example in (gnu packages dvtm).
Leo Famulari <leo@famulari.name> writes: > On Sat, Jul 30, 2016 at 06:19:47PM +0200, Vincent Legoll wrote: >> On Sat, Jul 30, 2016 at 3:46 PM, Vincent Legoll >> <vincent.legoll@gmail.com> wrote: >> > Here is the accompanying patch for sinit to build properly under guix >> > >> > It will be submitted alongside the scm modifs. >> > >> > I may even try to make it upstream, as it's fairly straightforward... >> >> DONE: >> http://lists.suckless.org/hackers/1607/11719.html >> >> Dunno the responsiveness, so no ETA for an upstream release fixing this... > > I noticed they replied with another suggestion: > > http://lists.suckless.org/hackers/1607/11720.html > > What happens if you set those variables in #:make-flags? There is an > example in (gnu packages dvtm). > This should just work, Vincent. See the 'ii' package I sent today.
> This should just work, Vincent. See the 'ii' package I sent today.
D'oh !
It (#:make-flags?) was already there in the scm I submitted, but that
wasn't working when I tested it first time, maybe because I did not
know about guix environment at that time and tried the build it outside
of one...
I'll clean that up and resubmit properly...
Vincent Legoll <vincent.legoll@gmail.com> writes: > It (#:make-flags?) was already there in the scm I submitted, but that > wasn't working when I tested it first time, maybe because I did not > know about guix environment at that time and tried the build it outside > of one... > > I'll clean that up and resubmit properly... Thanks. When you resubmit this could you please give it a try to send it as a patch? If you’re using a git clone of the Guix repository you can make a local commit (in a separate branch) and then run git format-patch -1 to create a patch from the last commit. You could then attach the patch file to an email (or use “git send-email …” if you already have email sending configured on your machine). This would make things a little easier for us and make it more likely that your contribution is reviewed and merged sooner. Thanks again! ~~ Ricardo
diff -Nur sinit-1.0-orig/config.mk sinit-1.0/config.mk --- sinit-1.0-orig/config.mk 2015-06-16 11:37:07.000000000 +0200 +++ sinit-1.0/config.mk 2016-07-13 10:24:25.952000000 +0200 @@ -2,10 +2,10 @@ VERSION = 1.0 # paths -PREFIX = /usr/local +PREFIX ?= /usr/local MANPREFIX = $(PREFIX)/share/man -CC = cc +CC ?= cc LD = $(CC) CPPFLAGS = CFLAGS = -Wextra -Wall -Os