From patchwork Wed Jun 8 17:34:00 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Patrick Hetu X-Patchwork-Id: 12884 Received: (qmail 6666 invoked by uid 89); 8 Jun 2016 17:34:26 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Checked: by ClamAV 0.99.1 on sourceware.org X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.3 required=5.0 tests=BAYES_00, RP_MATCHES_RCVD, SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:2735, his X-Spam-Status: No, score=-3.3 required=5.0 tests=BAYES_00, RP_MATCHES_RCVD, SPF_PASS autolearn=ham version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on sourceware.org X-Spam-Level: X-HELO: lists.gnu.org Received: from lists.gnu.org (HELO lists.gnu.org) (208.118.235.17) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Wed, 08 Jun 2016 17:34:16 +0000 Received: from localhost ([::1]:58657 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bAhMr-00078U-TF for patchwork@sourceware.org; Wed, 08 Jun 2016 13:34:13 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54361) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bAhMm-00078L-Oi for guix-devel@gnu.org; Wed, 08 Jun 2016 13:34:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bAhMh-0004lz-6z for guix-devel@gnu.org; Wed, 08 Jun 2016 13:34:08 -0400 Received: from smtp.ca.auf.org ([199.84.140.5]:47094) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bAhMh-0004l4-1h for guix-devel@gnu.org; Wed, 08 Jun 2016 13:34:03 -0400 Received: from smtp-sortant.ca.auf.org (smtp-sortant.ca.auf.org [199.84.140.10]) by smtp.ca.auf.org (Postfix) with ESMTP id 6F78218E0 for ; Wed, 8 Jun 2016 13:34:01 -0400 (EDT) Received: from localhost (amavis-montreal.ca.auf.org [199.84.140.2]) by smtp-sortant.ca.auf.org (Postfix) with ESMTP id ABC3CB77B for ; Wed, 8 Jun 2016 13:34:01 -0400 (EDT) X-Virus-Scanned: par amavis-montreal.ca.auf.org Received: from smtp-sortant.ca.auf.org ([199.84.140.10]) by localhost (amavis-montreal.ca.auf.org [199.84.140.2]) (amavisd-new, port 10024) with ESMTP id jIeXq7toAlFU for ; Wed, 8 Jun 2016 13:34:00 -0400 (EDT) Received: from sans-nom.auf.org (unknown [10.36.1.102]) by smtp-sortant.ca.auf.org (Postfix) with ESMTPSA id 8BF884D2 for ; Wed, 8 Jun 2016 13:34:00 -0400 (EDT) References: <1464375363-31718-1-git-send-email-patrick.hetu@auf.org> <87y46ui2uk.fsf@gnu.org> <87ziqwkhkw.fsf@auf.org> <87vb1jhl7w.fsf@gnu.org> From: Patrick Hetu To: guix-devel@gnu.org Subject: Re: [PATCH] gnu: Add guile-gnome In-reply-to: <87vb1jhl7w.fsf@gnu.org> Date: Wed, 08 Jun 2016 13:34:00 -0400 Message-ID: <87y46fk2k7.fsf@auf.org> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 199.84.140.5 X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+patchwork=sourceware.org@gnu.org Sender: "Guix-devel" Ludovic Courtès @ 2016-06-08 09:19 EDT: > Patr ick Hetu skribis: > >> Ludovic Courtès @ 2016-05-28 12:06 EDT: >> >>> Pushed as 9b381643f009025d97dfc0b82d2c00800c204380 with a few minor >>> changes: >> [...] >> Still, the current g-wrap package needs a new patch to fix his Makefile.in >> because the native-search-paths hooks won't find it for Guile 2.0. > > But it works well to build guile-gnome AFAICS. When is it a problem? I'm getting this error in a simple test script: In ice-9/boot-9.scm: 2951: 3 [define-module* (gnome gw gtk) #:filename ...] 2926: 2 [resolve-imports ((#) (#) (#) (#) ...)] 2867: 1 [resolve-interface (g-wrap gw standard) #:select ...] In unknown file: ?: 0 [scm-error misc-error #f ...] ERROR: In procedure scm-error: ERROR: no code for module (g-wrap gw standard) because the g-wrap code is under: /gnu/store/...-g-wrap-1.9.15/share/guile/site /gnu/store/...-g-wrap-1.9.15/share/guile/site/g-wrap.scm /gnu/store/...-g-wrap-1.9.15/share/guile/site/g-wrap /gnu/store/...-g-wrap-1.9.15/share/guile/site/g-wrap/compat.scm /gnu/store/...-g-wrap-1.9.15/share/guile/site/g-wrap/config.scm and not /gnu/..../share/guile/2.0/g-wrap/... > But yeah, patching it to match the native-search-paths is a good idea. ok, I've attached the patch. >> Also, should I rename it to guile-g-wrap at the same time? > > I don’t think so, because it’s both a program and a library, not just a > library (I see that this rule mine and is not spelled out in “Packaging > Guidelines”; it probably should, if there’s consensus.) ok. Patrick From 66baa02e5683a309588ae0a68a7d1b918ad72d8e Mon Sep 17 00:00:00 2001 From: Patrick Hetu Date: Wed, 8 Jun 2016 13:18:07 -0400 Subject: [PATCH] gnu: g-wrap: Fix installation path * gnu/packages/guile.scm (g-wrap): Add 2.0/ to the installation path --- gnu/packages/guile.scm | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/gnu/packages/guile.scm b/gnu/packages/guile.scm index 74e58c4..04c3f03 100644 --- a/gnu/packages/guile.scm +++ b/gnu/packages/guile.scm @@ -939,6 +939,16 @@ capabilities.") ("guile-lib" ,guile-lib))) (inputs `(("libffi" ,libffi))) + (arguments + `(#:phases + (modify-phases %standard-phases + (add-before 'configure 'pre-configure + (lambda* (#:key outputs #:allow-other-keys) + (let ((out (assoc-ref outputs "out"))) + (substitute* (find-files "." "^Makefile.in$") + (("guilemoduledir =.*guile/site" all) + (string-append all "/2.0"))) + #t)))))) (synopsis "Generate C bindings for Guile") (description "G-Wrap is a tool and Guile library for generating function wrappers for inter-language calls. It currently only supports generating Guile -- 2.7.4