diff mbox

gnu: Add libicns

Message ID 87vaycpx6k.fsf@ike.i-did-not-set--mail-host-address--so-tickle-me
State New
Headers show

Commit Message

Marius Bakke Sept. 3, 2016, 8:04 p.m. UTC 
Brendan Tildesley <brendan.tildesley@openmailbox.org> writes:

> I just notice the configure script wasn't looking for any newer version.

[...]

> checking libpng/png.h usability... no
> checking libpng/png.h presence... no
> checking for libpng/png.h... no
> checking libpng10/png.h usability... no
> checking libpng10/png.h presence... no
> checking for libpng10/png.h... no
> checking libpng12/png.h usability... yes
> checking libpng12/png.h presence... yes
> checking for libpng12/png.h... yes

You cut off the important lines! Here is how it looks with the latest
libpng in inputs:

checking for png_create_read_struct in -lpng... yes
checking png.h usability... yes                      <---
checking png.h presence... yes                       <---
checking for png.h... yes                            <---
checking libpng/png.h usability... no
checking libpng/png.h presence... no
checking for libpng/png.h... no
checking libpng10/png.h usability... no
checking libpng10/png.h presence... no
checking for libpng10/png.h... no
checking libpng12/png.h usability... no
checking libpng12/png.h presence... no
checking for libpng12/png.h... no

>>
>> The rest of the patch looks good to me.
>>
>> Thanks again!
>> Marius
>
> Thanks. If I posted a fix, I'd just end up making some new mistakes, so
> I'll just leave it to be added!

I did the mentioned adjustments and attached a new patch.

Hope I did not scare you off! :)

~marius

Comments

David Craven Sept. 4, 2016, 11:05 a.m. UTC | #1 
Thanks Marius and Brendan!

I removed the autotools inputs and build-phase, since the release
tarball already contains a configure script and fixed some
indentation.

Pushed as f5e4229a075e7aca255ab54d4e98526409520c62.
diff mbox

Patch

From 0efb2e7cb5c3344b49e30af57efcdd5b1136ac7f Mon Sep 17 00:00:00 2001
From: Brendan Tildesley <brendan.tildesley@openmailbox.org>
Date: Sat, 3 Sep 2016 05:53:56 +1000
Subject: [PATCH] gnu: Add libicns.

* gnu/packages/image.scm (libicns): New variable.
---
 gnu/packages/image.scm | 38 ++++++++++++++++++++++++++++++++++++++
 1 file changed, 38 insertions(+)

diff --git a/gnu/packages/image.scm b/gnu/packages/image.scm
index 4fdc4ae..c1b79f3 100644
--- a/gnu/packages/image.scm
+++ b/gnu/packages/image.scm
@@ -147,6 +147,44 @@  maximum quality factor.")
    (license license:gpl2+)
    (home-page "http://www.kokkonen.net/tjko/projects.html#jpegoptim")))
 
+(define-public libicns
+  (package
+    (name "libicns")
+    (version "0.8.1")
+    (source (origin
+             (method url-fetch)
+             (uri (string-append
+                   "mirror://sourceforge/icns/libicns-" version ".tar.gz"))
+             (sha256 (base32
+                      "1hjm8lwap7bjyyxsyi94fh5817xzqhk4kb5y0b7mb6675xw10prk"))))
+    (build-system gnu-build-system)
+    (inputs
+     `(("libpng" ,libpng)
+       ("jasper" ,jasper)))
+    (native-inputs
+     `(("autoconf" ,autoconf)
+       ("automake" ,automake)
+       ("libtool" ,libtool)))
+    (arguments
+     `(#:tests? #t ; No tests.
+       #:phases
+       (modify-phases %standard-phases
+         (add-before 'configure 'autoreconf
+           (lambda _
+             (zero? (system* "autoreconf" "-vfi")))))))
+    (home-page "http://icns.sourceforge.net/")
+    (synopsis "Library for handling Mac OS icns resource files")
+    (description
+     "Libicns is a library for the manipulation of Mac OS IconFamily resource
+type files (ICNS).  @command{icns2png} and @command{png2icns} are provided to
+convert between PNG and ICNS. @command{icns2png} will extract image files from
+ICNS files under names like \"Foo_48x48x32.png\" useful for installing for use
+with .desktop files.  Additionally, @command{icontainer2png} is provided for
+extracting icontainer icon files.")
+    (license (list license:lgpl2.1+     ; libicns
+                   license:lgpl2.0+     ; src/apidocs.*
+                   license:gpl2+))))    ; icns2png, png2icns, icontainer2png
+
 (define-public libtiff
   (package
    (name "libtiff")
-- 
2.9.3