Message ID | 87por0fmkl.fsf@gmail.com |
---|---|
State | New |
Headers | show |
Alex Kost <alezost@gmail.com> skribis: > Add "site-ccache" since it's a directory where .go files of guile > packages should go (for example, 'guile-ssh' installs *.go there). Indeed. > I suppose this patch should go to 'core-updates-next', right? Yes. > From 489a54be23753f61fa9c3a318d411eb48fb75bf6 Mon Sep 17 00:00:00 2001 > From: Alex Kost <alezost@gmail.com> > Date: Wed, 29 Jun 2016 10:51:26 +0300 > Subject: [PATCH] gnu: guile: Add "site-ccache" to the search path. > > * gnu/packages/guile.scm (guile-2.0)[native-search-paths]: Add > "lib/guile/2.0/site-ccache" to GUILE_LOAD_COMPILED_PATH. > (guile-next): Likewise. [...] > --- a/gnu/packages/guile.scm > +++ b/gnu/packages/guile.scm > @@ -180,6 +180,7 @@ without requiring the source code to be rewritten.") > (search-path-specification > (variable "GUILE_LOAD_COMPILED_PATH") > (files '("lib/guile/2.0/ccache" > + "lib/guile/2.0/site-ccache" > "share/guile/site/2.0"))))) I wonder if it makes sense to keep lib/guile/2.0/ccache since that is (meant to be) used exclusively by Guile itself, I think. Andy, WDYT? Thanks, Ludo’.
On Wed 29 Jun 2016 15:14, ludo@gnu.org (Ludovic Courtès) writes: >> --- a/gnu/packages/guile.scm >> +++ b/gnu/packages/guile.scm >> @@ -180,6 +180,7 @@ without requiring the source code to be rewritten.") >> (search-path-specification >> (variable "GUILE_LOAD_COMPILED_PATH") >> (files '("lib/guile/2.0/ccache" >> + "lib/guile/2.0/site-ccache" >> "share/guile/site/2.0"))))) > > I wonder if it makes sense to keep lib/guile/2.0/ccache since that is > (meant to be) used exclusively by Guile itself, I think. > > Andy, WDYT? Removing Guile's own compiled paths from GUILE_LOAD_COMPILED_PATH sounds like a good idea to me, since these are implicitly included via GUILE_SYSTEM_COMPILED_PATH or whatever that is. Similarly for Scheme files if that is possible! Andy
Andy Wingo <wingo@igalia.com> skribis: > On Wed 29 Jun 2016 15:14, ludo@gnu.org (Ludovic Courtès) writes: > >>> --- a/gnu/packages/guile.scm >>> +++ b/gnu/packages/guile.scm >>> @@ -180,6 +180,7 @@ without requiring the source code to be rewritten.") >>> (search-path-specification >>> (variable "GUILE_LOAD_COMPILED_PATH") >>> (files '("lib/guile/2.0/ccache" >>> + "lib/guile/2.0/site-ccache" >>> "share/guile/site/2.0"))))) >> >> I wonder if it makes sense to keep lib/guile/2.0/ccache since that is >> (meant to be) used exclusively by Guile itself, I think. >> >> Andy, WDYT? > > Removing Guile's own compiled paths from GUILE_LOAD_COMPILED_PATH sounds > like a good idea to me, since these are implicitly included via > GUILE_SYSTEM_COMPILED_PATH or whatever that is. OK. Alex, could you update the patch to not only add 2.x/site-ccache, but also remove 2.x/ccache? Thanks, Ludo’.
Ludovic Courtès (2016-06-30 13:31 +0300) wrote: > Andy Wingo <wingo@igalia.com> skribis: > >> On Wed 29 Jun 2016 15:14, ludo@gnu.org (Ludovic Courtès) writes: >> >>>> --- a/gnu/packages/guile.scm >>>> +++ b/gnu/packages/guile.scm >>>> @@ -180,6 +180,7 @@ without requiring the source code to be rewritten.") >>>> (search-path-specification >>>> (variable "GUILE_LOAD_COMPILED_PATH") >>>> (files '("lib/guile/2.0/ccache" >>>> + "lib/guile/2.0/site-ccache" >>>> "share/guile/site/2.0"))))) >>> >>> I wonder if it makes sense to keep lib/guile/2.0/ccache since that is >>> (meant to be) used exclusively by Guile itself, I think. >>> >>> Andy, WDYT? >> >> Removing Guile's own compiled paths from GUILE_LOAD_COMPILED_PATH sounds >> like a good idea to me, since these are implicitly included via >> GUILE_SYSTEM_COMPILED_PATH or whatever that is. > > OK. Alex, could you update the patch to not only add 2.x/site-ccache, > but also remove 2.x/ccache? Done, committed to 'core-updates-next' as a08539dd1f. ... or did you mean to *send* the updated patch at first? oops :-)
Alex Kost <alezost@gmail.com> skribis: > Ludovic Courtès (2016-06-30 13:31 +0300) wrote: > >> Andy Wingo <wingo@igalia.com> skribis: >> >>> On Wed 29 Jun 2016 15:14, ludo@gnu.org (Ludovic Courtès) writes: >>> >>>>> --- a/gnu/packages/guile.scm >>>>> +++ b/gnu/packages/guile.scm >>>>> @@ -180,6 +180,7 @@ without requiring the source code to be rewritten.") >>>>> (search-path-specification >>>>> (variable "GUILE_LOAD_COMPILED_PATH") >>>>> (files '("lib/guile/2.0/ccache" >>>>> + "lib/guile/2.0/site-ccache" >>>>> "share/guile/site/2.0"))))) >>>> >>>> I wonder if it makes sense to keep lib/guile/2.0/ccache since that is >>>> (meant to be) used exclusively by Guile itself, I think. >>>> >>>> Andy, WDYT? >>> >>> Removing Guile's own compiled paths from GUILE_LOAD_COMPILED_PATH sounds >>> like a good idea to me, since these are implicitly included via >>> GUILE_SYSTEM_COMPILED_PATH or whatever that is. >> >> OK. Alex, could you update the patch to not only add 2.x/site-ccache, >> but also remove 2.x/ccache? > > Done, committed to 'core-updates-next' as a08539dd1f. > > ... or did you mean to *send* the updated patch at first? oops :-) That’s fine. :-) Thanks! Ludo’.
From 489a54be23753f61fa9c3a318d411eb48fb75bf6 Mon Sep 17 00:00:00 2001 From: Alex Kost <alezost@gmail.com> Date: Wed, 29 Jun 2016 10:51:26 +0300 Subject: [PATCH] gnu: guile: Add "site-ccache" to the search path. * gnu/packages/guile.scm (guile-2.0)[native-search-paths]: Add "lib/guile/2.0/site-ccache" to GUILE_LOAD_COMPILED_PATH. (guile-next): Likewise. --- gnu/packages/guile.scm | 2 ++ 1 file changed, 2 insertions(+) diff --git a/gnu/packages/guile.scm b/gnu/packages/guile.scm index 2d8ca0c..5453e78 100644 --- a/gnu/packages/guile.scm +++ b/gnu/packages/guile.scm @@ -180,6 +180,7 @@ without requiring the source code to be rewritten.") (search-path-specification (variable "GUILE_LOAD_COMPILED_PATH") (files '("lib/guile/2.0/ccache" + "lib/guile/2.0/site-ccache" "share/guile/site/2.0"))))) (synopsis "Scheme implementation intended especially for extensions") @@ -223,6 +224,7 @@ without requiring the source code to be rewritten.") (search-path-specification (variable "GUILE_LOAD_COMPILED_PATH") (files '("lib/guile/2.2/ccache" + "lib/guile/2.2/site-ccache" "share/guile/site/2.2"))))))) (define-public guile-for-guile-emacs -- 2.8.3