diff mbox

gnu: cross-gcc-arguments: Add Hurd-core-headers lib directory to the "CROSS_LIBRARY_PATH".

Message ID 5a5a117f-6e70-2aef-ec02-d9702f8b7208@gmail.com
State New
Headers show

Commit Message

Manolis Ragkousis June 8, 2016, 2:55 p.m. UTC
Hello everyone,

Thanks to the previous patch for cross-libc, this patch is the only
change needed for cross-gcc to work properly when targeting GNU/Hurd.

Thank you,
Manolis

Comments

Ludovic Courtès June 12, 2016, 4:42 p.m. UTC | #1
Hi!

Manolis Ragkousis <manolis837@gmail.com> skribis:

> From 77b12cc2aa1a79a2f15b96d80a14d76e3501aeb1 Mon Sep 17 00:00:00 2001
> From: Manolis Ragkousis <manolis837@gmail.com>
> Date: Wed, 8 Jun 2016 17:46:19 +0300
> Subject: [PATCH] gnu: cross-gcc-arguments: Add Hurd-core-headers lib directory
>  to the "CROSS_LIBRARY_PATH".

Subject too long; what about: “gnu: cross-gcc: Allow Hurd libraries to
be found.”?

> * gnu/packages/cross-base.scm (cross-gcc-arguments)[arguments]: Add Hurd-core-headers lib
> directory to the "CROSS_LIBRARY_PATH".

Rather “Add ‘KERNEL/lib’ to ‘CROSS_LIBRARY_PATH’.”

> -                            (string-append libc "/lib"))
> +                            (string-append libc "/lib"
> +                                           ;; We need this for GNU/Hurd.
> +                                           ":" kernel "/lib"))

Maybe write it as:

  (string-append libc "/lib:"
                 kernel "/lib")  ;for Hurd’s libihash

OK with these changes.

What’s confusing is that the hurd-core-headers package actually contains
libihash.a (and libstore.a?) in addition to headers, right?

Thanks!

Ludo’.
diff mbox

Patch

From 77b12cc2aa1a79a2f15b96d80a14d76e3501aeb1 Mon Sep 17 00:00:00 2001
From: Manolis Ragkousis <manolis837@gmail.com>
Date: Wed, 8 Jun 2016 17:46:19 +0300
Subject: [PATCH] gnu: cross-gcc-arguments: Add Hurd-core-headers lib directory
 to the "CROSS_LIBRARY_PATH".

* gnu/packages/cross-base.scm (cross-gcc-arguments)[arguments]: Add Hurd-core-headers lib
directory to the "CROSS_LIBRARY_PATH".
---
 gnu/packages/cross-base.scm | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/cross-base.scm b/gnu/packages/cross-base.scm
index db2e104..fd2fc4e 100644
--- a/gnu/packages/cross-base.scm
+++ b/gnu/packages/cross-base.scm
@@ -187,7 +187,9 @@  may be either a libc package or #f.)"
                                   "CROSS_OBJC_INCLUDE_PATH"
                                   "CROSS_OBJCPLUS_INCLUDE_PATH")))
                     (setenv "CROSS_LIBRARY_PATH"
-                            (string-append libc "/lib"))
+                            (string-append libc "/lib"
+                                           ;; We need this for GNU/Hurd.
+                                           ":" kernel "/lib"))
                     (for-each
                      (lambda (var)
                        (and=> (getenv var)
-- 
2.8.2