From patchwork Sun Nov 13 03:20:28 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Patterson X-Patchwork-Id: 17438 Received: (qmail 55776 invoked by uid 89); 13 Nov 2016 03:21:04 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Checked: by ClamAV 0.99.2 on sourceware.org X-Virus-Found: No X-Spam-SWARE-Status: No, score=-4.8 required=5.0 tests=BAYES_00, RP_MATCHES_RCVD, SPF_PASS autolearn=ham version=3.3.2 spammy=1008 X-Spam-Status: No, score=-4.8 required=5.0 tests=BAYES_00, RP_MATCHES_RCVD, SPF_PASS autolearn=ham version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on sourceware.org X-Spam-Level: X-HELO: lists.gnu.org Received: from lists.gnu.org (HELO lists.gnu.org) (208.118.235.17) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 13 Nov 2016 03:20:53 +0000 Received: from localhost ([::1]:60471 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c5lLg-00066S-00 for patchwork@sourceware.org; Sat, 12 Nov 2016 22:20:52 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40409) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c5lLV-00063R-9z for guix-devel@gnu.org; Sat, 12 Nov 2016 22:20:42 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c5lLO-00083C-UA for guix-devel@gnu.org; Sat, 12 Nov 2016 22:20:38 -0500 Received: from mailchk-m03.uwaterloo.ca ([129.97.128.240]:41976) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1c5lLO-000834-QE for guix-devel@gnu.org; Sat, 12 Nov 2016 22:20:34 -0500 Received: from localhost (bas1-jockvale05-70-26-161-141.dsl.bell.ca [70.26.161.141]) (authenticated bits=0) by mailchk-m03.uwaterloo.ca (8.14.4/8.14.4) with ESMTP id uAD3KTMt000829 (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256 verify=NO) for ; Sat, 12 Nov 2016 22:20:33 -0500 Date: Sat, 12 Nov 2016 22:20:28 -0500 From: Andy Patterson To: guix-devel@gnu.org Subject: [PATCH] tests: Don't check file-systems in container tests. Message-ID: <20161112222028.235925fb@uwaterloo.ca> X-Mailer: Claws Mail 3.14.0 (GTK+ 2.24.31; x86_64-unknown-linux-gnu) MIME-Version: 1.0 X-UUID: 51ed0927-7c78-46d1-a80f-fe0a7821b035 X-Miltered: at mailchk-m03 with ID 5827DBFD.003 by Joe's j-chkmail (http://j-chkmail.ensmp.fr)! X-Virus-Scanned: clamav-milter 0.99.2 at mailchk-m03 X-Virus-Status: Clean X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.9 (mailchk-m03.uwaterloo.ca [129.97.128.141]); Sat, 12 Nov 2016 22:20:33 -0500 (EST) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 129.97.128.240 X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+patchwork=sourceware.org@gnu.org Sender: "Guix-devel" Hello, The containers test was hanging for me, and this patch fixed the problem. --- Andy From 945ad44acf489b7f3a398d4ab739ec2b48477502 Mon Sep 17 00:00:00 2001 From: Andy Patterson Date: Sat, 12 Nov 2016 22:10:01 -0500 Subject: [PATCH] tests: Don't check file-systems in container tests. * tests/containers.scm ("call-with-container, mnt namespace"): Don't check file-system in 'call-with-container' call. * tests/containers.scm ("call-with-container, mnt namespace, wrong bindmount"): Likewise. --- tests/containers.scm | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/tests/containers.scm b/tests/containers.scm index ccd122a..745b56b 100644 --- a/tests/containers.scm +++ b/tests/containers.scm @@ -84,7 +84,8 @@ (call-with-container (list (file-system (device "none") (mount-point "/testing") - (type "tmpfs"))) + (type "tmpfs") + (check? #f))) (lambda () (assert-exit (file-exists? "/testing"))) #:namespaces '(user mnt)))) @@ -99,7 +100,8 @@ (device "/does-not-exist") (mount-point "/foo") (type "none") - (flags '(bind-mount)))) + (flags '(bind-mount)) + (check? #f))) (const #t) #:namespaces '(user mnt))) (lambda args