diff mbox

gnu: Add irctest.

Message ID 20161018134224.24053-2-ng0@we.make.ritual.n0.is
State New
Headers show

Commit Message

non such Oct. 18, 2016, 1:42 p.m. UTC 
* gnu/packages/irc.scm (irctest): New variable.
---
 gnu/packages/irc.scm | 37 ++++++++++++++++++++++++++++++++++++-
 1 file changed, 36 insertions(+), 1 deletion(-)

Comments

Leo Famulari Oct. 19, 2016, 8:18 p.m. UTC | #1 
On Tue, Oct 18, 2016 at 01:42:24PM +0000, ng0 wrote:
> * gnu/packages/irc.scm (irctest): New variable.

Cool!

> +      (version (string-append "0.1-" revision "." (string-take commit 7)))

0.1 should be 0.0.0.

> +      (inputs
> +       `(("python-ecdsa" ,python-ecdsa)
> +         ("python-psutil" ,python-psutil)
> +         ("limnoria" ,limnoria)))

The output does not refer to limnoria:

$ guix gc --references $(./pre-inst-env guix build irctest)
/gnu/store/pn0lc8cl2c7ja8vgkxs2ka8w9vras8i5-python-ecdsa-0.13
/gnu/store/qvmmdi87vypfz90n76ph5knca188wrv8-python-psutil-4.3.0
/gnu/store/z4r53nxw185s5an6kkvs7cgdkwrl1p8l-irctest-0.1-1.548ddb5

Is it just used for building? If so, it should be a native-input.
Otherwise irctest will stop working after garbage collection.
non such Oct. 19, 2016, 8:48 p.m. UTC | #2 
Hi,

thanks for reviewing

Leo Famulari <leo@famulari.name> writes:

> On Tue, Oct 18, 2016 at 01:42:24PM +0000, ng0 wrote:
>> * gnu/packages/irc.scm (irctest): New variable.
>
> Cool!
>
>> +      (version (string-append "0.1-" revision "." (string-take commit 7)))
>
> 0.1 should be 0.0.0.

No, the setup.py has version: 0.1

>> +      (inputs
>> +       `(("python-ecdsa" ,python-ecdsa)
>> +         ("python-psutil" ,python-psutil)
>> +         ("limnoria" ,limnoria)))
>
> The output does not refer to limnoria:
>
> $ guix gc --references $(./pre-inst-env guix build irctest)
> /gnu/store/pn0lc8cl2c7ja8vgkxs2ka8w9vras8i5-python-ecdsa-0.13
> /gnu/store/qvmmdi87vypfz90n76ph5knca188wrv8-python-psutil-4.3.0
> /gnu/store/z4r53nxw185s5an6kkvs7cgdkwrl1p8l-irctest-0.1-1.548ddb5
>
> Is it just used for building? If so, it should be a native-input.
> Otherwise irctest will stop working after garbage collection.

I think this has to be propagated, I'm not really sure. I need to look
at this when I can focus again
diff mbox

Patch

diff --git a/gnu/packages/irc.scm b/gnu/packages/irc.scm
index db398de..fd5be13 100644
--- a/gnu/packages/irc.scm
+++ b/gnu/packages/irc.scm
@@ -3,7 +3,7 @@ 
 ;;; Copyright © 2014 Kevin Lemonnier <lemonnierk@ulrar.net>
 ;;; Copyright © 2015 Ludovic Courtès <ludo@gnu.org>
 ;;; Copyright © 2015, 2016 Efraim Flashner <efraim@flashner.co.il>
-;;; Copyright © 2016 ng0 <ngillmann@runbox.com>
+;;; Copyright © 2016 ng0 <ng0@we.make.ritual.n0.is>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -23,6 +23,7 @@ 
 (define-module (gnu packages irc)
   #:use-module ((guix licenses) #:prefix license:)
   #:use-module (guix download)
+  #:use-module (guix git-download)
   #:use-module (guix packages)
   #:use-module (guix build-system cmake)
   #:use-module (guix build-system gnu)
@@ -329,3 +330,37 @@  and extensible with plugins and scripts.")
 embedded web server, translations (fr, fi, it, hu, de), and many
 other enhancements and bug fixes.")
     (license license:bsd-3)))
+
+;; No release tarball so far
+(define-public irctest
+  (let ((commit "548ddb57b08584004a07d8e07f409341e7f4c321")
+        (revision "1"))
+    (package
+      (name "irctest")
+      (version (string-append "0.1-" revision "." (string-take commit 7)))
+      (source
+       (origin
+         (method git-fetch)
+         (uri (git-reference
+               (url "https://github.com/ProgVal/irctest")
+               (commit commit)))
+         (file-name (string-append name "-" version "-checkout"))
+         (sha256
+          (base32
+           "1g3xmdiwcb5pjhll2gp7bcbnxc8h0g3hmis3xnvbcvbkrqm75r4w"))))
+      (build-system python-build-system)
+      (inputs
+       `(("python-ecdsa" ,python-ecdsa)
+         ("python-psutil" ,python-psutil)
+         ("limnoria" ,limnoria)))
+      (arguments
+       `(#:tests? #f)) ; No tests
+      (home-page "https://github.com/ProgVal/irctest")
+      (synopsis "IRC (1459/2812/v3.1/v3.2) software conformance testing tool")
+      (description
+       "Irctest aims at testing interoperability of software using the
+IRC protocol, by running them against test suites and making different
+software communicate with each other.  It contains IRC protocol test
+cases and small wrappers around existing software to run tests on them.
+Wrappers run software in temporary directories.")
+      (license license:expat))))