gnu: Add whois.

  * gnu/packages/networking.scm (whois): New variable.
---
 gnu/packages/networking.scm | 38 ++++++++++++++++++++++++++++++++++++++
 1 file changed, 38 insertions(+)
  

ng0 <ng0@we.make.ritual.n0.is> writes:

> * gnu/packages/networking.scm (whois): New variable.

Thanks! This works for me. I have a couple of remarks that can be added
before committing if you agree, no need to send an updated patch.

* The source headers seems to indicate that this is GPL2+.
* The only reference to this program on the home page is a link to
  GitHub, do you think we should use that as home-page?
* Gettext only seems used for building locales and is not referenced at
  runtime, perhaps it should be a native-input?
* The Debian package is built with HAVE_ICONV=1, should we set that too?

Additionally it installs locales, but looks for /usr/share/locale at
runtime. Fixing this would probably require upstream help, I don't want
to hardcode either "/run/current-system/locale" or ~/.guix-profile. The
current version probably works on foreign distros, if nothing else.

Are these changes sensible?
  

Marius Bakke <mbakke@fastmail.com> writes:

> ng0 <ng0@we.make.ritual.n0.is> writes:
>
>> * gnu/packages/networking.scm (whois): New variable.
>
> Thanks! This works for me. I have a couple of remarks that can be added
> before committing if you agree, no need to send an updated patch.
>
> * The source headers seems to indicate that this is GPL2+.
> * The only reference to this program on the home page is a link to
>   GitHub, do you think we should use that as home-page?
> * Gettext only seems used for building locales and is not referenced at
>   runtime, perhaps it should be a native-input?

Ok.

> * The Debian package is built with HAVE_ICONV=1, should we set that too?

I can send an updated patch with libiconv in the inputs. This is when
you use a libc which does not provide a (usable) iconv, which is why
Gentoo provides the option to build it with this too. As we are
_currently_ only providing options to do one libc globally this is not
so inmportant. I will even build uclibc-ng (I am working on that) with
an outside iconv because reportedly their iconv is in bad shape.

So with this information, should I send a new patch which adds libiconv
and the build option?

> Additionally it installs locales, but looks for /usr/share/locale at
> runtime. Fixing this would probably require upstream help, I don't want
> to hardcode either "/run/current-system/locale" or ~/.guix-profile. The
> current version probably works on foreign distros, if nothing else.

If you know how to fix it, try to bring it to upstream or include a
patch / substitute phase at our end?

> Are these changes sensible?
>
  

ng0 <ng0@we.make.ritual.n0.is> writes:

>> * The Debian package is built with HAVE_ICONV=1, should we set that too?
>
> I can send an updated patch with libiconv in the inputs. This is when
> you use a libc which does not provide a (usable) iconv, which is why
> Gentoo provides the option to build it with this too. As we are
> _currently_ only providing options to do one libc globally this is not
> so inmportant. I will even build uclibc-ng (I am working on that) with
> an outside iconv because reportedly their iconv is in bad shape.
>
> So with this information, should I send a new patch which adds libiconv
> and the build option?

Since we only support glibc at the moment, I don't think adding a
package for libiconv first is necessary. On the other hand, if it can
cause problems on other libc's, it's nice to use an external one.

IMO adding libiconv as input is something that can be done later, when
there is an actual need for it. I guess there are more packages that
will require it. But I don't really mind either way :)

>> Additionally it installs locales, but looks for /usr/share/locale at
>> runtime. Fixing this would probably require upstream help, I don't want
>> to hardcode either "/run/current-system/locale" or ~/.guix-profile. The
>> current version probably works on foreign distros, if nothing else.
>
> If you know how to fix it, try to bring it to upstream or include a
> patch / substitute phase at our end?

I tried patching whois.c to use the glibc default in the call to
bindtextdomain(3), instead of the LOCALEDIR build option. That almost
worked: it searches the system locales, but also expect to find the
translation files there. I'll see if I can cook up a fix for upstream,
but don't think this should hold back the package.
  

Marius Bakke <mbakke@fastmail.com> writes:

> ng0 <ng0@we.make.ritual.n0.is> writes:
>
>>> * The Debian package is built with HAVE_ICONV=1, should we set that too?
>>
>> I can send an updated patch with libiconv in the inputs. This is when
>> you use a libc which does not provide a (usable) iconv, which is why
>> Gentoo provides the option to build it with this too. As we are
>> _currently_ only providing options to do one libc globally this is not
>> so inmportant. I will even build uclibc-ng (I am working on that) with
>> an outside iconv because reportedly their iconv is in bad shape.
>>
>> So with this information, should I send a new patch which adds libiconv
>> and the build option?
>
> Since we only support glibc at the moment, I don't think adding a
> package for libiconv first is necessary. On the other hand, if it can
> cause problems on other libc's, it's nice to use an external one.
>
> IMO adding libiconv as input is something that can be done later, when
> there is an actual need for it. I guess there are more packages that
> will require it. But I don't really mind either way :)
>
>>> Additionally it installs locales, but looks for /usr/share/locale at
>>> runtime. Fixing this would probably require upstream help, I don't want
>>> to hardcode either "/run/current-system/locale" or ~/.guix-profile. The
>>> current version probably works on foreign distros, if nothing else.
>>
>> If you know how to fix it, try to bring it to upstream or include a
>> patch / substitute phase at our end?
>
> I tried patching whois.c to use the glibc default in the call to
> bindtextdomain(3), instead of the LOCALEDIR build option. That almost
> worked: it searches the system locales, but also expect to find the
> translation files there. I'll see if I can cook up a fix for upstream,
> but don't think this should hold back the package.
>

I think we can bundle the patch until it/if gets accepts at all by
upstream.
  

ng0 <ng0@we.make.ritual.n0.is> writes:

> Marius Bakke <mbakke@fastmail.com> writes:
>
>> ng0 <ng0@we.make.ritual.n0.is> writes:
>>
>>> * gnu/packages/networking.scm (whois): New variable.
>>
>> Thanks! This works for me. I have a couple of remarks that can be added
>> before committing if you agree, no need to send an updated patch.
>>
>> * The source headers seems to indicate that this is GPL2+.
>> * The only reference to this program on the home page is a link to
>>   GitHub, do you think we should use that as home-page?
>> * Gettext only seems used for building locales and is not referenced at
>>   runtime, perhaps it should be a native-input?
>
> Ok.
>
>> * The Debian package is built with HAVE_ICONV=1, should we set that too?
>
> I can send an updated patch with libiconv in the inputs. This is when
> you use a libc which does not provide a (usable) iconv, which is why
> Gentoo provides the option to build it with this too. As we are
> _currently_ only providing options to do one libc globally this is not
> so inmportant. I will even build uclibc-ng (I am working on that) with
> an outside iconv because reportedly their iconv is in bad shape.

I have my uclibc-ng system not booted: When I specify libiconv in the
inputs, shouldn't it get reported by ldd?

ng0@shadowwalker /gnu/store/fkkvgiqa0x01j6cxipddmn7k20hax1xn-whois-5.2.12/bin$ ls
mkpasswd  whois
ng0@shadowwalker /gnu/store/fkkvgiqa0x01j6cxipddmn7k20hax1xn-whois-5.2.12/bin$ ldd whois 
        linux-vdso.so.1 (0x00007ffcd84fe000)
        libidn.so.11 => /gnu/store/sbj1kgn8bs91bn7ba9qk4n3l2rr7dxbr-libidn-1.32/lib/libidn.so.11 (0x00007f311084e000)
        libgcc_s.so.1 => /gnu/store/9nifwk709wajpyfwa0jzaa3p6mf10vxs-gcc-4.9.3-lib/lib/libgcc_s.so.1 (0x00007f3110638000)
        libc.so.6 => /gnu/store/m9vxvhdj691bq1f85lpflvnhcvrdilih-glibc-2.23/lib/libc.so.6 (0x00007f3110296000)
        /gnu/store/m9vxvhdj691bq1f85lpflvnhcvrdilih-glibc-2.23/lib/ld-linux-x86-64.so.2 (0x00007f3110a81000)
ng0@shadowwalker /gnu/store/fkkvgiqa0x01j6cxipddmn7k20hax1xn-whois-5.2.12/bin$ ldd mkpasswd 
        linux-vdso.so.1 (0x00007ffed81c7000)
        libcrypt.so.1 => /gnu/store/m9vxvhdj691bq1f85lpflvnhcvrdilih-glibc-2.23/lib/libcrypt.so.1 (0x00007fc0328e5000)
        libgcc_s.so.1 => /gnu/store/9nifwk709wajpyfwa0jzaa3p6mf10vxs-gcc-4.9.3-lib/lib/libgcc_s.so.1 (0x00007fc0326cf000)
        libc.so.6 => /gnu/store/m9vxvhdj691bq1f85lpflvnhcvrdilih-glibc-2.23/lib/libc.so.6 (0x00007fc03232d000)
        /gnu/store/m9vxvhdj691bq1f85lpflvnhcvrdilih-glibc-2.23/lib/ld-linux-x86-64.so.2 (0x00007fc032b1c000)

> So with this information, should I send a new patch which adds libiconv
> and the build option?
>
>> Additionally it installs locales, but looks for /usr/share/locale at
>> runtime. Fixing this would probably require upstream help, I don't want
>> to hardcode either "/run/current-system/locale" or ~/.guix-profile. The
>> current version probably works on foreign distros, if nothing else.
>
> If you know how to fix it, try to bring it to upstream or include a
> patch / substitute phase at our end?
>
>> Are these changes sensible?
>>
>
>
  

ng0 <ng0@we.make.ritual.n0.is> writes:


> I have my uclibc-ng system not booted: When I specify libiconv in the
> inputs, shouldn't it get reported by ldd?
>
> ng0@shadowwalker /gnu/store/fkkvgiqa0x01j6cxipddmn7k20hax1xn-whois-5.2.12/bin$ ls
> mkpasswd  whois
> ng0@shadowwalker /gnu/store/fkkvgiqa0x01j6cxipddmn7k20hax1xn-whois-5.2.12/bin$ ldd whois 
>         linux-vdso.so.1 (0x00007ffcd84fe000)
>         libidn.so.11 => /gnu/store/sbj1kgn8bs91bn7ba9qk4n3l2rr7dxbr-libidn-1.32/lib/libidn.so.11 (0x00007f311084e000)
>         libgcc_s.so.1 => /gnu/store/9nifwk709wajpyfwa0jzaa3p6mf10vxs-gcc-4.9.3-lib/lib/libgcc_s.so.1 (0x00007f3110638000)
>         libc.so.6 => /gnu/store/m9vxvhdj691bq1f85lpflvnhcvrdilih-glibc-2.23/lib/libc.so.6 (0x00007f3110296000)
>         /gnu/store/m9vxvhdj691bq1f85lpflvnhcvrdilih-glibc-2.23/lib/ld-linux-x86-64.so.2 (0x00007f3110a81000)
> ng0@shadowwalker /gnu/store/fkkvgiqa0x01j6cxipddmn7k20hax1xn-whois-5.2.12/bin$ ldd mkpasswd 
>         linux-vdso.so.1 (0x00007ffed81c7000)
>         libcrypt.so.1 => /gnu/store/m9vxvhdj691bq1f85lpflvnhcvrdilih-glibc-2.23/lib/libcrypt.so.1 (0x00007fc0328e5000)
>         libgcc_s.so.1 => /gnu/store/9nifwk709wajpyfwa0jzaa3p6mf10vxs-gcc-4.9.3-lib/lib/libgcc_s.so.1 (0x00007fc0326cf000)
>         libc.so.6 => /gnu/store/m9vxvhdj691bq1f85lpflvnhcvrdilih-glibc-2.23/lib/libc.so.6 (0x00007fc03232d000)
>         /gnu/store/m9vxvhdj691bq1f85lpflvnhcvrdilih-glibc-2.23/lib/ld-linux-x86-64.so.2 (0x00007fc032b1c000)

I'm guessing it silently picks the glibc one. FWIW the Gentoo ebuild
does the same thing. Does uclibc-ng provide an iconv interface at all?
Maybe it can be circumvented by having [libc implementation] propagate
libiconv, instead of adding it as a direct input to packages.
  

Marius Bakke <mbakke@fastmail.com> writes:

> ng0 <ng0@we.make.ritual.n0.is> writes:
>
>
>> I have my uclibc-ng system not booted: When I specify libiconv in the
>> inputs, shouldn't it get reported by ldd?
>>
>> ng0@shadowwalker /gnu/store/fkkvgiqa0x01j6cxipddmn7k20hax1xn-whois-5.2.12/bin$ ls
>> mkpasswd  whois
>> ng0@shadowwalker /gnu/store/fkkvgiqa0x01j6cxipddmn7k20hax1xn-whois-5.2.12/bin$ ldd whois 
>>         linux-vdso.so.1 (0x00007ffcd84fe000)
>>         libidn.so.11 => /gnu/store/sbj1kgn8bs91bn7ba9qk4n3l2rr7dxbr-libidn-1.32/lib/libidn.so.11 (0x00007f311084e000)
>>         libgcc_s.so.1 => /gnu/store/9nifwk709wajpyfwa0jzaa3p6mf10vxs-gcc-4.9.3-lib/lib/libgcc_s.so.1 (0x00007f3110638000)
>>         libc.so.6 => /gnu/store/m9vxvhdj691bq1f85lpflvnhcvrdilih-glibc-2.23/lib/libc.so.6 (0x00007f3110296000)
>>         /gnu/store/m9vxvhdj691bq1f85lpflvnhcvrdilih-glibc-2.23/lib/ld-linux-x86-64.so.2 (0x00007f3110a81000)
>> ng0@shadowwalker /gnu/store/fkkvgiqa0x01j6cxipddmn7k20hax1xn-whois-5.2.12/bin$ ldd mkpasswd 
>>         linux-vdso.so.1 (0x00007ffed81c7000)
>>         libcrypt.so.1 => /gnu/store/m9vxvhdj691bq1f85lpflvnhcvrdilih-glibc-2.23/lib/libcrypt.so.1 (0x00007fc0328e5000)
>>         libgcc_s.so.1 => /gnu/store/9nifwk709wajpyfwa0jzaa3p6mf10vxs-gcc-4.9.3-lib/lib/libgcc_s.so.1 (0x00007fc0326cf000)
>>         libc.so.6 => /gnu/store/m9vxvhdj691bq1f85lpflvnhcvrdilih-glibc-2.23/lib/libc.so.6 (0x00007fc03232d000)
>>         /gnu/store/m9vxvhdj691bq1f85lpflvnhcvrdilih-glibc-2.23/lib/ld-linux-x86-64.so.2 (0x00007fc032b1c000)
>
> I'm guessing it silently picks the glibc one. FWIW the Gentoo ebuild
> does the same thing.

That is if your toolchain is glibc based. I have no uclibc-ng or musl
gentoo system at the moment to check this.

> Does uclibc-ng provide an iconv interface at all?

Yes, but so far I wasn't able to get a response by the hardened project
to get a comment on their "the iconv of uclibc and uclibc-ng is horrible
at the moment" comment.. so I'll ask on gentoo-dev list about this, irc
didn't work.

> Maybe it can be circumvented by having [libc implementation] propagate
> libiconv, instead of adding it as a direct input to packages.

Possibly. I'm not yet at the point where I can build a system I like
with this.
  

ng0 <ng0@we.make.ritual.n0.is> writes:

> Marius Bakke <mbakke@fastmail.com> writes:
>
>> ng0 <ng0@we.make.ritual.n0.is> writes:
>>
>>
>>> I have my uclibc-ng system not booted: When I specify libiconv in the
>>> inputs, shouldn't it get reported by ldd?
>>>
>>> ng0@shadowwalker /gnu/store/fkkvgiqa0x01j6cxipddmn7k20hax1xn-whois-5.2.12/bin$ ls
>>> mkpasswd  whois
>>> ng0@shadowwalker /gnu/store/fkkvgiqa0x01j6cxipddmn7k20hax1xn-whois-5.2.12/bin$ ldd whois 
>>>         linux-vdso.so.1 (0x00007ffcd84fe000)
>>>         libidn.so.11 => /gnu/store/sbj1kgn8bs91bn7ba9qk4n3l2rr7dxbr-libidn-1.32/lib/libidn.so.11 (0x00007f311084e000)
>>>         libgcc_s.so.1 => /gnu/store/9nifwk709wajpyfwa0jzaa3p6mf10vxs-gcc-4.9.3-lib/lib/libgcc_s.so.1 (0x00007f3110638000)
>>>         libc.so.6 => /gnu/store/m9vxvhdj691bq1f85lpflvnhcvrdilih-glibc-2.23/lib/libc.so.6 (0x00007f3110296000)
>>>         /gnu/store/m9vxvhdj691bq1f85lpflvnhcvrdilih-glibc-2.23/lib/ld-linux-x86-64.so.2 (0x00007f3110a81000)
>>> ng0@shadowwalker /gnu/store/fkkvgiqa0x01j6cxipddmn7k20hax1xn-whois-5.2.12/bin$ ldd mkpasswd 
>>>         linux-vdso.so.1 (0x00007ffed81c7000)
>>>         libcrypt.so.1 => /gnu/store/m9vxvhdj691bq1f85lpflvnhcvrdilih-glibc-2.23/lib/libcrypt.so.1 (0x00007fc0328e5000)
>>>         libgcc_s.so.1 => /gnu/store/9nifwk709wajpyfwa0jzaa3p6mf10vxs-gcc-4.9.3-lib/lib/libgcc_s.so.1 (0x00007fc0326cf000)
>>>         libc.so.6 => /gnu/store/m9vxvhdj691bq1f85lpflvnhcvrdilih-glibc-2.23/lib/libc.so.6 (0x00007fc03232d000)
>>>         /gnu/store/m9vxvhdj691bq1f85lpflvnhcvrdilih-glibc-2.23/lib/ld-linux-x86-64.so.2 (0x00007fc032b1c000)
>>
>> I'm guessing it silently picks the glibc one. FWIW the Gentoo ebuild
>> does the same thing.
>
> That is if your toolchain is glibc based. I have no uclibc-ng or musl
> gentoo system at the moment to check this.
>
>> Does uclibc-ng provide an iconv interface at all?
>
> Yes, but so far I wasn't able to get a response by the hardened project
> to get a comment on their "the iconv of uclibc and uclibc-ng is horrible
> at the moment" comment.. so I'll ask on gentoo-dev list about this, irc
> didn't work.
>
>> Maybe it can be circumvented by having [libc implementation] propagate
>> libiconv, instead of adding it as a direct input to packages.
>
> Possibly. I'm not yet at the point where I can build a system I like
> with this.

I'm happy to commit this package now with the changes mentioned earlier,
if that's okay with you. Making it use an external iconv library feels
like "premature optimization", since it works fine with what we have.
  

Marius Bakke <mbakke@fastmail.com> writes:

> ng0 <ng0@we.make.ritual.n0.is> writes:
>
>> Marius Bakke <mbakke@fastmail.com> writes:
>>
>>> ng0 <ng0@we.make.ritual.n0.is> writes:
>>>
>>>
>>>> I have my uclibc-ng system not booted: When I specify libiconv in the
>>>> inputs, shouldn't it get reported by ldd?
>>>>
>>>> ng0@shadowwalker /gnu/store/fkkvgiqa0x01j6cxipddmn7k20hax1xn-whois-5.2.12/bin$ ls
>>>> mkpasswd  whois
>>>> ng0@shadowwalker /gnu/store/fkkvgiqa0x01j6cxipddmn7k20hax1xn-whois-5.2.12/bin$ ldd whois 
>>>>         linux-vdso.so.1 (0x00007ffcd84fe000)
>>>>         libidn.so.11 => /gnu/store/sbj1kgn8bs91bn7ba9qk4n3l2rr7dxbr-libidn-1.32/lib/libidn.so.11 (0x00007f311084e000)
>>>>         libgcc_s.so.1 => /gnu/store/9nifwk709wajpyfwa0jzaa3p6mf10vxs-gcc-4.9.3-lib/lib/libgcc_s.so.1 (0x00007f3110638000)
>>>>         libc.so.6 => /gnu/store/m9vxvhdj691bq1f85lpflvnhcvrdilih-glibc-2.23/lib/libc.so.6 (0x00007f3110296000)
>>>>         /gnu/store/m9vxvhdj691bq1f85lpflvnhcvrdilih-glibc-2.23/lib/ld-linux-x86-64.so.2 (0x00007f3110a81000)
>>>> ng0@shadowwalker /gnu/store/fkkvgiqa0x01j6cxipddmn7k20hax1xn-whois-5.2.12/bin$ ldd mkpasswd 
>>>>         linux-vdso.so.1 (0x00007ffed81c7000)
>>>>         libcrypt.so.1 => /gnu/store/m9vxvhdj691bq1f85lpflvnhcvrdilih-glibc-2.23/lib/libcrypt.so.1 (0x00007fc0328e5000)
>>>>         libgcc_s.so.1 => /gnu/store/9nifwk709wajpyfwa0jzaa3p6mf10vxs-gcc-4.9.3-lib/lib/libgcc_s.so.1 (0x00007fc0326cf000)
>>>>         libc.so.6 => /gnu/store/m9vxvhdj691bq1f85lpflvnhcvrdilih-glibc-2.23/lib/libc.so.6 (0x00007fc03232d000)
>>>>         /gnu/store/m9vxvhdj691bq1f85lpflvnhcvrdilih-glibc-2.23/lib/ld-linux-x86-64.so.2 (0x00007fc032b1c000)
>>>
>>> I'm guessing it silently picks the glibc one. FWIW the Gentoo ebuild
>>> does the same thing.
>>
>> That is if your toolchain is glibc based. I have no uclibc-ng or musl
>> gentoo system at the moment to check this.
>>
>>> Does uclibc-ng provide an iconv interface at all?
>>
>> Yes, but so far I wasn't able to get a response by the hardened project
>> to get a comment on their "the iconv of uclibc and uclibc-ng is horrible
>> at the moment" comment.. so I'll ask on gentoo-dev list about this, irc
>> didn't work.
>>
>>> Maybe it can be circumvented by having [libc implementation] propagate
>>> libiconv, instead of adding it as a direct input to packages.
>>
>> Possibly. I'm not yet at the point where I can build a system I like
>> with this.
>
> I'm happy to commit this package now with the changes mentioned earlier,
> if that's okay with you. Making it use an external iconv library feels
> like "premature optimization", since it works fine with what we have.

Yes, okay for me.
  

ng0 <ng0@we.make.ritual.n0.is> writes:

> * gnu/packages/networking.scm (whois): New variable.

I pushed the updated version of this as
9c798f9036d2d3f90e567052efb06b269c08ed14 with a minor modification to
the description.