diff mbox

[4/4] gnu: node: Use compression: prefix.

Message ID 20160827112333.1759-5-jlicht@fsfe.org
State New
Headers

Commit Message

Jelle Licht Aug. 27, 2016, 11:23 a.m. UTC 
  * gnu/packages/node.scm (define-module): Import gnu packages compression
  with a prefix
(node): Likewise.
---
 gnu/packages/node.scm | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Alex Kost Aug. 27, 2016, 8:42 p.m. UTC | #1 
Jelle Licht (2016-08-27 14:23 +0300) wrote:

> * gnu/packages/node.scm (define-module): Import gnu packages compression
>   with a prefix
> (node): Likewise.
> ---
>  gnu/packages/node.scm | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
>
> diff --git a/gnu/packages/node.scm b/gnu/packages/node.scm
> index 7c020e6..351e988 100644
> --- a/gnu/packages/node.scm
> +++ b/gnu/packages/node.scm
> @@ -27,7 +27,8 @@
>    #:use-module (guix build-system gnu)
>    #:use-module (gnu packages adns)
>    #:use-module (gnu packages base)
> -  #:use-module (gnu packages compression)
> +  #:use-module ((gnu packages compression) #:prefix compression:)
> +  #:use-module (gnu packages curl)
>    #:use-module (gnu packages gcc)
>    #:use-module (gnu packages libevent)
>    #:use-module (gnu packages linux)

This patch is incomplete: you introduce 'compression' prefix, but you
use it in the previous patch.

Actually, why is this prefix needed?

Also why did you add curl module if it's not used at all?
Ludovic Courtès Sept. 1, 2016, 12:43 p.m. UTC | #2 
Howdy!

Jelle Licht <jlicht@fsfe.org> skribis:

> --- a/gnu/packages/node.scm
> +++ b/gnu/packages/node.scm
> @@ -27,7 +27,8 @@
>    #:use-module (guix build-system gnu)
>    #:use-module (gnu packages adns)
>    #:use-module (gnu packages base)
> -  #:use-module (gnu packages compression)
> +  #:use-module ((gnu packages compression) #:prefix compression:)
> +  #:use-module (gnu packages curl)

We must not use #:prefix or #:select for (gnu packages …) modules,
because of <http://bugs.gnu.org/15540> (the same applies to patch #1 in
this series.)

Ludo’.
diff mbox

Patch

diff --git a/gnu/packages/node.scm b/gnu/packages/node.scm
index 7c020e6..351e988 100644
--- a/gnu/packages/node.scm
+++ b/gnu/packages/node.scm
@@ -27,7 +27,8 @@ 
   #:use-module (guix build-system gnu)
   #:use-module (gnu packages adns)
   #:use-module (gnu packages base)
-  #:use-module (gnu packages compression)
+  #:use-module ((gnu packages compression) #:prefix compression:)
+  #:use-module (gnu packages curl)
   #:use-module (gnu packages gcc)
   #:use-module (gnu packages libevent)
   #:use-module (gnu packages linux)