[01/31] gnu: qtbase: Add native search paths.

Message ID 20160826215300.12913-2-david@craven.ch
State New
Headers

Commit Message

David Craven Aug. 26, 2016, 9:52 p.m. UTC
  * gnu/packages/qt.scm (qtbase)[native-search-paths]:
Add QML2_IMPORT_PATH.
Add QT_PLUGIN_PATH.
Add XDG_DATA_DIRS.
Add XDG_CONFIG_DIRS.
---
 gnu/packages/qt.scm | 14 +++++++++++++-
 1 file changed, 13 insertions(+), 1 deletion(-)
  

Comments

Ricardo Wurmus Aug. 27, 2016, 6:21 a.m. UTC | #1
David Craven <david@craven.ch> writes:

> * gnu/packages/qt.scm (qtbase)[native-search-paths]:
> Add QML2_IMPORT_PATH.
> Add QT_PLUGIN_PATH.
> Add XDG_DATA_DIRS.
> Add XDG_CONFIG_DIRS.

This looks good to me.  Thank you!

Will this result in mass rebuilds?  If so this should be pushed to
core-updates.

~~ Ricardo
  
Efraim Flashner Aug. 28, 2016, 5:36 a.m. UTC | #2
On Sat, Aug 27, 2016 at 08:21:55AM +0200, Ricardo Wurmus wrote:
> 
> David Craven <david@craven.ch> writes:
> 
> > * gnu/packages/qt.scm (qtbase)[native-search-paths]:
> > Add QML2_IMPORT_PATH.
> > Add QT_PLUGIN_PATH.
> > Add XDG_DATA_DIRS.
> > Add XDG_CONFIG_DIRS.
> 
> This looks good to me.  Thank you!
> 
> Will this result in mass rebuilds?  If so this should be pushed to
> core-updates.
> 
> ~~ Ricardo
> 

qtbase is "parent" to ~100 packages, 15-20 of which are more qt modules,
and a bunch are lower kde tiers. My number is inflated, but for me `guix
refresh -l qtbase' says 62 packages with 101 dependants, so its almost
entirely leaf packages at this point. I'd say its fine to push to
master.
  
David Craven Aug. 28, 2016, 1:16 p.m. UTC | #3
> Will this result in mass rebuilds?  If so this should be pushed to
> core-updates.

I too think that it's below the core updates threshold...
  

Patch

diff --git a/gnu/packages/qt.scm b/gnu/packages/qt.scm
index a7eee7c..5a93ea2 100644
--- a/gnu/packages/qt.scm
+++ b/gnu/packages/qt.scm
@@ -474,7 +474,19 @@  developers using C++ or QML, a CSS & JavaScript like language.")
     (native-search-paths
      (list (search-path-specification
             (variable "QMAKEPATH")
-            (files '("")))))
+            (files '("")))
+           (search-path-specification
+            (variable "QML2_IMPORT_PATH")
+            (files '("qml")))
+           (search-path-specification
+            (variable "QT_PLUGIN_PATH")
+            (files '("plugins")))
+           (search-path-specification
+            (variable "XDG_DATA_DIRS")
+            (files '("share")))
+           (search-path-specification
+            (variable "XDG_CONFIG_DIRS")
+            (files '("etc/xdg")))))
     (home-page "https://www.qt.io/")
     (synopsis "Cross-platform GUI library")
     (description "Qt is a cross-platform application and UI framework for