diff mbox

gnu: python: add pyserial.

Message ID 20160815122501.2433-1-dannym@scratchpost.org
State New
Headers show

Commit Message

Danny Milosavljevic Aug. 15, 2016, 12:25 p.m. UTC 
* gnu/packages/python.scm (python-pyserial, python-pyserial2): New variables.
---
 gnu/packages/python.scm | 34 ++++++++++++++++++++++++++++++++++
 1 file changed, 34 insertions(+)

Comments

Leo Famulari Aug. 16, 2016, 12:29 a.m. UTC | #1 
On Mon, Aug 15, 2016 at 02:25:01PM +0200, Danny Milosavljevic wrote:
> 
> * gnu/packages/python.scm (python-pyserial, python-pyserial2): New variables.

Thank for this package!

> +      (uri (string-append
> +             "https://pypi.python.org/packages/"
> +             "3c/d8/a9fa247ca60b02b3bebbd61766b4f321393b57b13c53b18f6f62cf172c08/"
> +             "pyserial-" version ".tar.gz"))

It's much shorter to use pypi-uri.

> +  (inputs
> +    `(("python-setuptools" ,python-setuptools)))

Was this left in from some previous version of the package? If so, it
should be removed, and you will need to add a (properties ...) field to
make the python2-variant system work for python2-pyserial. See the
package definition of python-pythondialog for an example.

> +  (license license:bsd-3)))

The "license:" prefix should be removed. The package can't be built with
it.

Can you send an updated patch?
diff mbox

Patch

diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
index 5cc54d0..36c5d52 100644
--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -9886,3 +9886,37 @@  relays publish about themselves.")
 
 (define-public python2-stem
   (package-with-python2 python-stem))
+
+(define-public python-pyserial
+ (package
+  (name "python-pyserial")
+  (version "3.1.1")
+  (source
+    (origin
+      (method url-fetch)
+      (uri (string-append
+             "https://pypi.python.org/packages/"
+             "3c/d8/a9fa247ca60b02b3bebbd61766b4f321393b57b13c53b18f6f62cf172c08/"
+             "pyserial-" version ".tar.gz"))
+      (sha256
+        (base32
+          "0k1nfdrxxkdlv4zgaqsdv8li0pj3gbh2pyxw8q2bsg6f9490amyn"))))
+  (build-system python-build-system)
+  (inputs
+    `(("python-setuptools" ,python-setuptools)))
+  (home-page
+    "https://github.com/pyserial/pyserial")
+  (synopsis "Python Serial Port Bindings")
+  (description "@code{pyserial} provide serial port bindings for Python. 
+It supports different byte sizes, stop bits, parity and flow control with
+RTS/CTS and/or Xon/Xoff. 
+The port is accessed in RAW mode.")
+  (license license:bsd-3)))
+
+(define-public python2-pyserial
+  (let ((base (package-with-python2 (strip-python2-variant python-pyserial))))
+    (package
+      (inherit base)
+      (native-inputs
+       `(("python2-setuptools" ,python2-setuptools)
+         ,@(package-native-inputs base))))))