From patchwork Fri Aug 5 19:36:08 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andreas Enge X-Patchwork-Id: 14359 Received: (qmail 6151 invoked by uid 89); 5 Aug 2016 19:36:36 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Checked: by ClamAV 0.99.1 on sourceware.org X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=AWL, BAYES_00, KAM_ASCII_DIVIDERS, RP_MATCHES_RCVD, SPF_PASS autolearn=ham version=3.3.2 spammy=UD:jpg, 8117, resist, 507 X-Spam-Status: No, score=-2.6 required=5.0 tests=AWL, BAYES_00, KAM_ASCII_DIVIDERS, RP_MATCHES_RCVD, SPF_PASS autolearn=ham version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on sourceware.org X-Spam-Level: X-HELO: lists.gnu.org Received: from lists.gnu.org (HELO lists.gnu.org) (208.118.235.17) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Fri, 05 Aug 2016 19:36:26 +0000 Received: from localhost ([::1]:46891 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bVkuu-0002No-KX for patchwork@sourceware.org; Fri, 05 Aug 2016 15:36:24 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53591) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bVkuo-0002NV-UV for guix-devel@gnu.org; Fri, 05 Aug 2016 15:36:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bVkuj-0004YT-UC for guix-devel@gnu.org; Fri, 05 Aug 2016 15:36:17 -0400 Received: from mailrelay6.public.one.com ([91.198.169.200]:57221) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bVkuj-0004YF-EN for guix-devel@gnu.org; Fri, 05 Aug 2016 15:36:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=enge.fr; s=20140924; h=from:subject:date:message-id:to:cc:mime-version:content-type:in-reply-to: references; bh=RHj65yAFuIaKze+yUr2+81fgOmF6u+e3p9R1em13W8U=; b=Xz6iraRQEXZNSC00/xBQlhw8tamgdSG+t5IF/U4xaypXl9Aojy5wPvhMoEq10btdEKf9uiXlAeMVb bgEVLD+HsnCFRp7P2MHAcKLOoLc9OhxzYkFXuH+Z0PG22MiZtBXq2X5yAo9coYwgh8DLOxnYjSebs5 BEOBSTJBJvQil2RU= X-HalOne-Cookie: 42e29632b19af5fc0a6bf3677d5b307c029f5290 X-HalOne-ID: dc5c80b3-5b43-11e6-9f37-b82a72d06996 Received: from solar (unknown [92.89.73.211]) by smtpfilter3.public.one.com (Halon Mail Gateway) with ESMTPSA; Fri, 5 Aug 2016 19:36:09 +0000 (UTC) Date: Fri, 5 Aug 2016 21:36:08 +0200 From: Andreas Enge To: ng0 Subject: Re: [PATCH] gnu: libextractor: Update inputs. Message-ID: <20160805193608.GA1542@solar> References: <871t26x8lq.fsf@we.make.ritual.n0.is> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <871t26x8lq.fsf@we.make.ritual.n0.is> User-Agent: Mutt/1.6.1 (2016-04-27) X-detected-operating-system: by eggs.gnu.org: FreeBSD 9.x X-Received-From: 91.198.169.200 X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: guix-devel@gnu.org Errors-To: guix-devel-bounces+patchwork=sourceware.org@gnu.org Sender: "Guix-devel" Hello, On Wed, Aug 03, 2016 at 01:52:49PM +0000, ng0 wrote: > This patch updates (input) of libextractor, adding some optional > dependencies we packaged already. thanks! I could not resist to order the inputs alphabetically, updated patch attached... Unfortunately, it fails a test for me: PASS: test_zip Did not get expected meta data of type 2 and format 1 with value `test.html' from plugin `archive' Did not get expected meta data of type 2 and format 1 with value `test.jpg' from plugin `archive' Did not get expected meta data of type 54 and format 1 with value `GNU tar format' from plugin `archive' FAIL: test_archive ... ========================================= 1 of 28 tests failed Please report to bug-libextractor@gnu.org ========================================= Besides doing as the test suggests, a first measure could be to not add libarchive for the time being :-) Andreas From 1a16986771f1c818e431ddf5077da775ff652e61 Mon Sep 17 00:00:00 2001 From: ng0 Date: Wed, 3 Aug 2016 13:42:27 +0000 Subject: [PATCH] gnu: libextractor: Add inputs. * gnu/packages/gnunet.scm (libextractor)[inputs]: Add gtk+, libarchive, libgsf, libmpeg2. * [arguments](configure-flags): Add flag to configure with libltdl. --- gnu/packages/gnunet.scm | 28 ++++++++++++++++------------ 1 file changed, 16 insertions(+), 12 deletions(-) diff --git a/gnu/packages/gnunet.scm b/gnu/packages/gnunet.scm index 4d888bd..bce12b3 100644 --- a/gnu/packages/gnunet.scm +++ b/gnu/packages/gnunet.scm @@ -50,6 +50,7 @@ #:use-module (gnu packages tls) #:use-module (gnu packages video) #:use-module (gnu packages xiph) + #:use-module (gnu packages backup) #:use-module ((guix licenses) #:prefix license:) #:use-module (guix packages) #:use-module (guix download) @@ -81,17 +82,12 @@ ;; FIXME: ;; The following dependencies are all optional, but should be ;; available for maximum coverage: - ;; * libarchive - ;; * libgif (giflib) - ;; * libgtk+ >= 3.0.0 (may probably drop glib then as a propagated input of - ;; gtk) - ;; * libgsf ;; * libmagic (file) - ;; * libmpeg2 - ;; * libmp4v2 - ;; * librpm - ;; * libsmf - ;; * libtidy + ;; * libmp4v2 ; package it + ;; * librpm ; package it + ;; * libsmf ; package it + ;; * libtidy ; package it + ;; * libgif (giflib) ; investigate failure (inputs `(("exiv2" ,exiv2) ("flac" ,flac) @@ -100,14 +96,22 @@ ("glib" ,glib) ("gstreamer" ,gstreamer) ("gst-plugins-base" ,gst-plugins-base) + ("gtk+" ,gtk+) + ("libarchive" ,libarchive) + ("libgsf" ,libgsf) ("libjpeg" ,libjpeg) + ("libltdl" ,libltdl) + ("libmpeg2" ,libmpeg2) ("libogg" ,libogg) ("libtiff" ,libtiff) - ("libltdl" ,libltdl) ("libvorbis" ,libvorbis) ("zlib" ,zlib))) (native-inputs - `(("pkg-config" ,pkg-config))) + `(("pkg-config" ,pkg-config))) + (arguments + `(#:configure-flags + (list (string-append "--with-ltdl=" + (assoc-ref %build-inputs "libltdl"))))) (synopsis "Library to extract meta-data from media files") (description "GNU libextractor is a library for extracting metadata from files. It