[v2] gnu: Add lrzip.

  * gnu/packages/compression.scm (lrzip): New variable.
---

V2:
- Add 'nasm' input only on x86 systems.
- Correct licencing information.

 gnu/packages/compression.scm | 36 ++++++++++++++++++++++++++++++++++++
 1 file changed, 36 insertions(+)
  

Talking to myself,

On 2016-07-21 22:24, Tobias Geerinckx-Rice wrote:
> +    (native-inputs
> +     `(,@(if (string-prefix? "i686" (or (%current-target-system)
> +                                        (%current-system)))
> +             `(("nasm" ,nasm))
> +             '())

Hmm. Not sure where this falls on the ‘let the code speak for itself’
to ‘should have added a comment’ scale.

Guess I'll wait for another review + patch or a very friendly committer.

Kind regards,

T G-R
  

Hi Tobias,

Tobias Geerinckx-Rice <me@tobias.gr> skribis:

> On 2016-07-21 22:24, Tobias Geerinckx-Rice wrote:
>> +    (native-inputs
>> +     `(,@(if (string-prefix? "i686" (or (%current-target-system)
>> +                                        (%current-system)))
>> +             `(("nasm" ,nasm))
>> +             '())
>
> Hmm. Not sure where this falls on the ‘let the code speak for itself’
> to ‘should have added a comment’ scale.
>
> Guess I'll wait for another review + patch or a very friendly committer.

I have another idea: could you create a Savannah account and tell me
your user name?  :-)

Thanks,
Ludo’.
  

Hi Tobias,

ludo@gnu.org (Ludovic Courtès) skribis:

> Tobias Geerinckx-Rice <me@tobias.gr> skribis:
>
>> On 2016-07-21 22:24, Tobias Geerinckx-Rice wrote:
>>> +    (native-inputs
>>> +     `(,@(if (string-prefix? "i686" (or (%current-target-system)
>>> +                                        (%current-system)))
>>> +             `(("nasm" ,nasm))
>>> +             '())
>>
>> Hmm. Not sure where this falls on the ‘let the code speak for itself’
>> to ‘should have added a comment’ scale.
>>
>> Guess I'll wait for another review + patch or a very friendly committer.
>
> I have another idea: could you create a Savannah account and tell me
> your user name?  :-)

I’ve added you to the Savannah group so you can commit directly.

Please see the ‘HACKING’ file on how to be a good citizen.  ;-)
In particular, make sure to configure commit signing as noted at
<http://debbugs.gnu.org/cgi/bugreport.cgi?bug=22883#16>.

So I think the last iteration of this patch, with a comment regarding
the i686 case as you wrote above, will be a good thing to push.

Happy hacking!

Ludo’.
  

Ludo',

On 23/07/2016 12:45, Ludovic Courtès wrote:
> I’ve added you to the Savannah group so you can commit directly.

Thanks!

> Please see the ‘HACKING’ file on how to be a good citizen.  ;-) In 
> particular, make sure to configure commit signing

Done and (already) done.

I spent about an hour trying to get Guix's gpg2, gpg-agent and
pinentry-tty to play nicely with git, but gave up. They work fine on
their own. Back to gpg@1 for now.

> as noted at <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=22883#16>.
>> I invite everyone to do the same.  Hopefully, within a few weeks, 
>> we can add a commit hook to reject unsigned commits.

Has this since been put in place?

> So I think the last iteration of this patch, with a comment regarding
> the i686 case as you wrote above, will be a good thing to push.

Done as 389eb3f.

Kind regards,

T G-R
  

Hello!

Tobias Geerinckx-Rice <me@tobias.gr> skribis:

> On 23/07/2016 12:45, Ludovic Courtès wrote:
>> I’ve added you to the Savannah group so you can commit directly.
>
> Thanks!
>
>> Please see the ‘HACKING’ file on how to be a good citizen.  ;-) In 
>> particular, make sure to configure commit signing
>
> Done and (already) done.
>
> I spent about an hour trying to get Guix's gpg2, gpg-agent and
> pinentry-tty to play nicely with git, but gave up. They work fine on
> their own. Back to gpg@1 for now.

OK.  Commit bc85b127df622575988f8e760f72d608d0900a75 adds the ‘gpg’ and
‘gpgv’ commands to gnupg@2.0, so it should work flawlessly for you (I’ve
been using 2.0 forever, but I had a ‘gpg’ script that would call ‘gpg2’;
this is no longer needed.)

>> as noted at <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=22883#16>.
>>> I invite everyone to do the same.  Hopefully, within a few weeks, 
>>> we can add a commit hook to reject unsigned commits.
>
> Has this since been put in place?

No, I’ll try and adjust what’s available at:
<https://raw.githubusercontent.com/isislovecruft/scripts/master/check-commit-signature>.
(Suggestions welcome, though!)

Ludo’.
  

On Sun, Jul 24, 2016 at 11:36:24PM +0200, Ludovic Courtès wrote:
> No, I’ll try and adjust what’s available at:
> <https://raw.githubusercontent.com/isislovecruft/scripts/master/check-commit-signature>.
> (Suggestions welcome, though!)

I will also review this script.
  

Ludo',

Thanks, but...

On 2016-07-24 23:36, ludo@gnu.org wrote:
> Tobias Geerinckx-Rice <me@tobias.gr> skribis:
>> I spent about an hour
> I had a ‘gpg’ script that would call ‘gpg2’

So did I.

Now, maybe *my* script was so bad that it caused segfaults and IPC
errors, but that would shatter my fragile ego, so no.

Kind regards,

T G-R
  

Leo Famulari <leo@famulari.name> skribis:

> On Sun, Jul 24, 2016 at 11:36:24PM +0200, Ludovic Courtès wrote:
>> No, I’ll try and adjust what’s available at:
>> <https://raw.githubusercontent.com/isislovecruft/scripts/master/check-commit-signature>.
>> (Suggestions welcome, though!)
>
> I will also review this script.

I submitted something simpler, because we don’t want to have a list of
allowed keys set in stone:

  https://savannah.gnu.org/support/?109104

Eventually I think we’ll do proper checks against a list of authorized
keys stored in the repo itself.  Needs more thought!

Ludo’.