From patchwork Fri Jul 7 14:41:28 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Mike FABIAN X-Patchwork-Id: 21470 Received: (qmail 77395 invoked by alias); 7 Jul 2017 14:41:35 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 76382 invoked by uid 89); 7 Jul 2017 14:41:33 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=AC_HTML_NONSENSE_TAGS, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RP_MATCHES_RCVD, SPF_HELO_PASS, T_FILL_THIS_FORM_SHORT autolearn=ham version=3.3.2 spammy=pm X-HELO: mx1.redhat.com DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 905C1267CE Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=mfabian@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 905C1267CE From: Mike FABIAN To: Akhilesh Kumar Cc: libc-alpha@sourceware.org, pankaj.m@samsung.com Subject: Re: [PATCH 1/1] Added Samoan language locale for Samoa References: <1499232622-21049-1-git-send-email-akhilesh.k@samsung.com> Date: Fri, 07 Jul 2017 16:41:28 +0200 In-Reply-To: <1499232622-21049-1-git-send-email-akhilesh.k@samsung.com> (Akhilesh Kumar's message of "Wed, 5 Jul 2017 11:00:22 +0530") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Akhilesh Kumar wrote: > [BZ #21710] > diff --git a/localedata/locales/sm_WS b/localedata/locales/sm_WS > new file mode 100644 > index 0000000..47a2b34 > --- /dev/null > +++ b/localedata/locales/sm_WS > @@ -0,0 +1,220 @@ [...] > +% Equivalent of AM PM > +% AM PM > +% Fix Me > +am_pm "";/ > + "i" The “i” seems to be a typo. And this is just “AM” and “PM”, no Samoan translations. I guess that is why you still have the “Fix Me” there. Can you get the real AM/PM strings for Samoan? On top of the the AM/PM problem, I suggest the attached changes. diff --git a/localedata/locales/sm_WS b/localedata/locales/sm_WS index 47a2b34a64..8f2a89083d 100644 --- a/localedata/locales/sm_WS +++ b/localedata/locales/sm_WS @@ -1,35 +1,35 @@ comment_char % escape_char / -% samoan language locale for Samoa. +% Samoan language locale for Samoa. % Contributed by Akhilesh Kumar . -% Wrods translated from https://glosbe.com/sm/en/asu +% Words translated from https://glosbe.com/sm/en/asu LC_IDENTIFICATION -title "samoan language locale for Samoa" +title "Samoan language locale for Samoa" source "Samsung Electronics Co., Ltd." address "" contact "" email "akhilesh.k@samsung.com" -tel "" -fax "" +tel "" +fax "" language "Samoan" territory "Samoa" revision "0.1" date "2017-03-21" -category "i18n:2017";LC_IDENTIFICATION -category "i18n:2017";LC_CTYPE -category "i18n:2017";LC_COLLATE -category "i18n:2017";LC_TIME -category "i18n:2017";LC_NUMERIC -category "i18n:2017";LC_MONETARY -category "i18n:2017";LC_PAPER -category "i18n:2017";LC_MEASUREMENT -category "i18n:2017";LC_MESSAGES -category "i18n:2017";LC_NAME -category "i18n:2017";LC_ADDRESS -category "i18n:2017";LC_TELEPHONE +category "i18n:2012";LC_IDENTIFICATION +category "i18n:2012";LC_CTYPE +category "i18n:2012";LC_COLLATE +category "i18n:2012";LC_TIME +category "i18n:2012";LC_NUMERIC +category "i18n:2012";LC_MONETARY +category "i18n:2012";LC_PAPER +category "i18n:2012";LC_MEASUREMENT +category "i18n:2012";LC_MESSAGES +category "i18n:2012";LC_NAME +category "i18n:2012";LC_ADDRESS +category "i18n:2012";LC_TELEPHONE END LC_IDENTIFICATION LC_CTYPE @@ -42,17 +42,17 @@ END LC_CTYPE LC_COLLATE % Copy the template from ISO/IEC 3166 -copy "iso14651_t1" +copy "iso14651_t1" END LC_COLLATE LC_TIME % Full month names -% Ianuari, Fepuari, Mati, Aperila, Me, Iuni,Iulai, Auguso, Setema,Oketopa,Novema, Tesema +% Ianuari, Fepuari, Mati, Aperila, Me, Iuni, Iulai, Auguso, Setema, Oketopa, Novema, Tesema % http://samoan.manuatele.net/times.html mon "";/ "";/ "";/ - "U0061>";/ + "";/ "";/ "";/ "";/ @@ -63,7 +63,7 @@ mon "";/ "" % Abbreviated month names -% Ian, Fep, Mat, Ape, Me, Iun,Iul, Aug, Set,Oke,Nov, Tes +% Ian, Fep, Mat, Ape, Me, Iun, Iul, Aug, Set, Oke, Nov, Tes abmon "";/ "";/ "";/ @@ -79,7 +79,7 @@ abmon "";/ % % Full Weekday names % http://samoan.manuatele.net/times.html -% Aso Sa,Aso Gafua,Aso Lua,Aso Lulu,Aso Tofi,Aso Faraile,Aso To'ana'i +% Aso Sa, Aso Gafua, Aso Lua, Aso Lulu, Aso Tofi, Aso Faraile, Aso To'ana'i day "";/ "";/ "";/ @@ -89,7 +89,7 @@ day "";/ "" % % Abbreviated Weekday names -% Aso Sa,Aso Gaf,Aso Lua,Aso Lul,Aso Tof,Aso Far,Aso To' +% Aso Sa, Aso Gaf, Aso Lua, Aso Lul, Aso Tof, Aso Far, Aso To' abday "";/ "";/ "";/ @@ -112,10 +112,10 @@ d_fmt "" t_fmt "" % % Equivalent of AM PM -% AM PM +% AM PM % Fix Me am_pm "";/ - "i" + "" % % Appropriate 12 h time representation % %I:%M:%S %p %Z @@ -129,22 +129,22 @@ decimal_point "" thousands_sep "" grouping 3 END LC_NUMERIC -% -% WST -% WS$ + LC_MONETARY -int_curr_symbol "" -currency_symbol "" +% WST +int_curr_symbol "" +% WS$ +currency_symbol "" mon_decimal_point "" mon_thousands_sep "" mon_grouping 3 positive_sign "" negative_sign "" -int_frac_digits 2 +int_frac_digits 2 frac_digits 2 p_cs_precedes 1 int_p_sep_by_space 1 -p_sep_by_space 1 +p_sep_by_space 1 n_cs_precedes 1 int_n_sep_by_space 1 n_sep_by_space 1 @@ -157,19 +157,19 @@ copy "i18n" END LC_PAPER LC_MEASUREMENT -measurement 1 +copy "i18n" END LC_MEASUREMENT LC_MESSAGES % ^[yY].* -yesexpr "" +yesexpr "" % ^[nN].* -noexpr "" +noexpr "" % https://glosbe.com/en/sm/no -% ioe +% ioe yesstr "" % leai -nostr "" +nostr "" END LC_MESSAGES LC_NAME @@ -182,7 +182,7 @@ postal_fmt "/ / / " -% Samoa +% Samoa country_name "" % %a %N %f %N %d %N %b %N %h %s %e %r %N %T, %c %N country_post "/ @@ -200,18 +200,18 @@ country_ab3 "" % locale/iso-3166.def country_num 882 % http://www.nationsonline.org/oneworld/international-calling-codes.htm -% Samoan -lang_name "" +% Gagana faÊ»a Sāmoa +lang_name "" % https://en.wikipedia.org/wiki/Samoan_language -% ISO 639-1 sm. ISO 639-2 smo , ISO 639-3 smo +% ISO 639-1 sm, ISO 639-2 smo, ISO 639-3 smo lang_ab "" lang_term "" lang_lib "" END LC_ADDRESS LC_TELEPHONE -% +%c ;%a ;%l -tel_int_fmt "" +% +%c %a %l +tel_int_fmt "" % 00 int_select "" % https://en.wikipedia.org/wiki/Samoa