From patchwork Thu Jul 13 16:30:50 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Mike FABIAN X-Patchwork-Id: 21605 Received: (qmail 62653 invoked by alias); 13 Jul 2017 16:36:58 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 62641 invoked by uid 89); 13 Jul 2017 16:36:57 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=AC_HTML_NONSENSE_TAGS, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RP_MATCHES_RCVD, SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 1C7C44E03F Authentication-Results: ext-mx09.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx09.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=mfabian@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 1C7C44E03F From: Mike FABIAN To: Akhilesh Kumar Cc: libc-alpha@sourceware.org, pankaj.m@samsung.com, maninder1.s@samsung.com Subject: Re: [PATCH 1/1] New locale for bi_VU References: <1499939026-33225-1-git-send-email-akhilesh.k@samsung.com> Date: Thu, 13 Jul 2017 18:30:50 +0200 In-Reply-To: <1499939026-33225-1-git-send-email-akhilesh.k@samsung.com> (Akhilesh Kumar's message of "Thu, 13 Jul 2017 15:13:46 +0530") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Akhilesh Kumar wrote: > [BZ #21767] > * locales/bi_VU: New file. > * SUPPORTED: Add bi_VU/UTF-8. > > Signed-off-by: Akhilesh Kumar > Signed-off-by: Maninder Singh Suggested changes: diff --git a/localedata/locales/bi_VU b/localedata/locales/bi_VU index ed450eafe5..19d1aff25a 100755 --- a/localedata/locales/bi_VU +++ b/localedata/locales/bi_VU @@ -3,7 +3,7 @@ escape_char / % Bislama language locale for Vanuatu. % Contributed by Akhilesh Kumar , Maninder Singh . -% Wrods translated from http://bislama.org/dbquery2.php +% Words translated from http://bislama.org/dbquery2.php You are making the typo “Wrods” instead of “Words” again and again. If you are copying this from somewhere, better fix it where you are copying it from ... % http://www.bislama.org/translate % http://wikitravel.org/en/Bislama_phrasebook @@ -84,7 +84,7 @@ day "";/ "";/ "";/ "";/ - ">";/ + "";/ One closing > too much, this would not compile. "";/ "" % @@ -109,13 +109,10 @@ d_t_fmt "/ d_fmt "" % % Appropriate time representation -% %I:%M:%S %Z -t_fmt "" - +% %I:%M:%S %Z +t_fmt "" % Equivalent of AM PM -am_pm "";/ -"" -% +am_pm "";"" You have Devanagari here in am_pm! That cannot be right for Bismali. Bismali uses Latin script. My patch replaces it with English AM/PM. But maybe you can find the real AM/PM strings for Bismali? % % Appropriate 12 h time representation (%r) % %I:%M:%S %p %Z @@ -151,7 +148,7 @@ p_sep_by_space 0 n_cs_precedes 1 int_n_sep_by_space 1 n_sep_by_space 0 -p_sign_posn 1 +p_sign_posn 1 n_sign_posn 1 END LC_MONETARY @@ -190,15 +187,20 @@ country_name "" country_ab2 "" % VUT country_ab3 "" +% https://en.wikipedia.org/wiki/List_of_international_vehicle_registration_codes +% VU +country_car "" I think country_car should be "VU" +% https://en.wikipedia.org/wiki/ISO_3166-1_numeric country_num 548 % https://en.wikipedia.org/wiki/Bislama % Bislama lang_name "" -% bi +% iso-639-1 "bi" lang_ab "" -% bis +% iso-639-3 "bis" lang_term "" -country_car "" country_car did congain "bis" here, which seems wrong. +% iso-639-2 "bis" +lang_lib "" lang_lib was missing. END LC_ADDRESS LC_TELEPHONE diff --git a/localedata/locales/bi_VU b/localedata/locales/bi_VU index ed450eafe5..19d1aff25a 100755 --- a/localedata/locales/bi_VU +++ b/localedata/locales/bi_VU @@ -3,7 +3,7 @@ escape_char / % Bislama language locale for Vanuatu. % Contributed by Akhilesh Kumar , Maninder Singh . -% Wrods translated from http://bislama.org/dbquery2.php +% Words translated from http://bislama.org/dbquery2.php % http://www.bislama.org/translate % http://wikitravel.org/en/Bislama_phrasebook @@ -84,7 +84,7 @@ day "";/ "";/ "";/ "";/ - ">";/ + "";/ "";/ "" % @@ -109,13 +109,10 @@ d_t_fmt "/ d_fmt "" % % Appropriate time representation -% %I:%M:%S %Z -t_fmt "" - +% %I:%M:%S %Z +t_fmt "" % Equivalent of AM PM -am_pm "";/ -"" -% +am_pm "";"" % % Appropriate 12 h time representation (%r) % %I:%M:%S %p %Z @@ -151,7 +148,7 @@ p_sep_by_space 0 n_cs_precedes 1 int_n_sep_by_space 1 n_sep_by_space 0 -p_sign_posn 1 +p_sign_posn 1 n_sign_posn 1 END LC_MONETARY @@ -190,15 +187,20 @@ country_name "" country_ab2 "" % VUT country_ab3 "" +% https://en.wikipedia.org/wiki/List_of_international_vehicle_registration_codes +% VU +country_car "" +% https://en.wikipedia.org/wiki/ISO_3166-1_numeric country_num 548 % https://en.wikipedia.org/wiki/Bislama % Bislama lang_name "" -% bi +% iso-639-1 "bi" lang_ab "" -% bis +% iso-639-3 "bis" lang_term "" -country_car "" +% iso-639-2 "bis" +lang_lib "" END LC_ADDRESS LC_TELEPHONE