diff mbox

[1/1] For Breton yesstr/nostr locale are missing

Message ID s9d7ezo3036.fsf@redhat.com
State Committed
Headers

Commit Message

Mike FABIAN July 4, 2017, 11:36 a.m. UTC 
  Akhilesh Kumar <akhilesh.k@samsung.com> wrote:

> [BZ #21706] 
> During Locale verification i observed that
> yesstr and nostr  are missing for Breton [LC_MESSAGES] locale
>
> Signed-off-by: Akhilesh Kumar <akhilesh.k@samsung.com>
> ---
>  localedata/locales/br_FR | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/localedata/locales/br_FR b/localedata/locales/br_FR
> index 3444cde..84c52eb 100644
> --- a/localedata/locales/br_FR
> +++ b/localedata/locales/br_FR
> @@ -99,6 +99,8 @@ END LC_CTYPE
>  LC_MESSAGES
>  yesexpr "<U005E><U005B><U002B><U0031><U006F><U004F><U0079><U0059><U005D>"
>  noexpr  "<U005E><U005B><U002D><U0030><U006E><U004E><U005D>"
> +yesstr  "<U0059><U0061>"
> +nostr   "<U004E><U0061><U006E><U006E>"
>  END LC_MESSAGES
>  
>  LC_MONETARY

Decoded, this looks like:


"Ya" and "Nann" indeed seem to be the words for "Yes" and "No" in
Breton. So this looks correct to me.

Comments

Rafal Luzynski July 4, 2017, 10:27 p.m. UTC | #1 
4.07.2017 13:36 Mike FABIAN <mfabian@redhat.com> wrote:
>
>
> Akhilesh Kumar <akhilesh.k@samsung.com> wrote:
>
> > [BZ #21706]
> > During Locale verification i observed that
> > yesstr and nostr are missing for Breton [LC_MESSAGES] locale
> >
> > Signed-off-by: Akhilesh Kumar <akhilesh.k@samsung.com>
> > ---
> > localedata/locales/br_FR | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/localedata/locales/br_FR b/localedata/locales/br_FR
> > index 3444cde..84c52eb 100644
> > --- a/localedata/locales/br_FR
> > +++ b/localedata/locales/br_FR
> > @@ -99,6 +99,8 @@ END LC_CTYPE
> > LC_MESSAGES
> > yesexpr "<U005E><U005B><U002B><U0031><U006F><U004F><U0079><U0059><U005D>"
> > noexpr "<U005E><U005B><U002D><U0030><U006E><U004E><U005D>"
> > +yesstr "<U0059><U0061>"
> > +nostr "<U004E><U0061><U006E><U006E>"
> > END LC_MESSAGES
> >
> > LC_MONETARY
> [...]
> Decoded, this looks like:
>
> diff --git a/localedata/locales/br_FR b/localedata/locales/br_FR
> index 3444cde..84c52eb 100644
> --- a/localedata/locales/br_FR
> +++ b/localedata/locales/br_FR
> @@ -99,6 +99,8 @@ END LC_CTYPE
> LC_MESSAGES
> yesexpr "^[+1oOyY]"
> noexpr "^[-0nN]"
> +yesstr "Ya"
> +nostr "Nann"
> END LC_MESSAGES
>
> LC_MONETARY
>
> "Ya" and "Nann" indeed seem to be the words for "Yes" and "No" in
> Breton. So this looks correct to me.

Akhilesh, where do these strings come from?  CLDR (sadly) does not
provide them for Breton.

Is this correct to always capitalize them?  I mean: do the Breton
language rules say that "Ya" and "Nann" should always start with
the uppercase (so "ya" and "nann" are always incorrect)? See:
https://sourceware.org/bugzilla/show_bug.cgi?id=16975

Regards,

Rafal
Mike FABIAN July 5, 2017, 6:30 a.m. UTC | #2 
Rafal Luzynski <digitalfreak@lingonborough.com> さんはかきました:

> 4.07.2017 13:36 Mike FABIAN <mfabian@redhat.com> wrote:
>>
>>
>> Akhilesh Kumar <akhilesh.k@samsung.com> wrote:
>>
>> > [BZ #21706]
>> > During Locale verification i observed that
>> > yesstr and nostr are missing for Breton [LC_MESSAGES] locale
>> >
>> > Signed-off-by: Akhilesh Kumar <akhilesh.k@samsung.com>
>> > ---
>> > localedata/locales/br_FR | 2 ++
>> > 1 file changed, 2 insertions(+)
>> >
>> > diff --git a/localedata/locales/br_FR b/localedata/locales/br_FR
>> > index 3444cde..84c52eb 100644
>> > --- a/localedata/locales/br_FR
>> > +++ b/localedata/locales/br_FR
>> > @@ -99,6 +99,8 @@ END LC_CTYPE
>> > LC_MESSAGES
>> > yesexpr "<U005E><U005B><U002B><U0031><U006F><U004F><U0079><U0059><U005D>"
>> > noexpr "<U005E><U005B><U002D><U0030><U006E><U004E><U005D>"
>> > +yesstr "<U0059><U0061>"
>> > +nostr "<U004E><U0061><U006E><U006E>"
>> > END LC_MESSAGES
>> >
>> > LC_MONETARY
>> [...]
>> Decoded, this looks like:
>>
>> diff --git a/localedata/locales/br_FR b/localedata/locales/br_FR
>> index 3444cde..84c52eb 100644
>> --- a/localedata/locales/br_FR
>> +++ b/localedata/locales/br_FR
>> @@ -99,6 +99,8 @@ END LC_CTYPE
>> LC_MESSAGES
>> yesexpr "^[+1oOyY]"
>> noexpr "^[-0nN]"
>> +yesstr "Ya"
>> +nostr "Nann"
>> END LC_MESSAGES
>>
>> LC_MONETARY
>>
>> "Ya" and "Nann" indeed seem to be the words for "Yes" and "No" in
>> Breton. So this looks correct to me.
>
> Akhilesh, where do these strings come from?  CLDR (sadly) does not
> provide them for Breton.

I verified this with online dictionaries for Breton.

> Is this correct to always capitalize them?  I mean: do the Breton
> language rules say that "Ya" and "Nann" should always start with
> the uppercase (so "ya" and "nann" are always incorrect)? See:
> https://sourceware.org/bugzilla/show_bug.cgi?id=16975

I don’t know, but I checked the other locales and the capitalization of
these strings is unfortunatly inconsistent. I am not sure what to do
about that:

~$ LC_ALL=zh_SG.UTF-8 locale -k yesstr
yesstr="Yes"
~$ LC_ALL=en_US.UTF-8 locale -k yesstr
yesstr="yes"
~$ 

> Regards,
>
> Rafal
Rafal Luzynski July 6, 2017, 8:16 p.m. UTC | #3 
5.07.2017 08:30 Mike FABIAN <mfabian@redhat.com> wrote:
>
>
> Rafal Luzynski <digitalfreak@lingonborough.com> さんはかきました:
>
> > 4.07.2017 13:36 Mike FABIAN <mfabian@redhat.com> wrote:
> >> [...]
> >> "Ya" and "Nann" indeed seem to be the words for "Yes" and "No" in
> >> Breton. So this looks correct to me.
> >
> > Akhilesh, where do these strings come from? CLDR (sadly) does not
> > provide them for Breton.
>
> I verified this with online dictionaries for Breton.

OK, seems to be credible.

> > Is this correct to always capitalize them? I mean: do the Breton
> > language rules say that "Ya" and "Nann" should always start with
> > the uppercase (so "ya" and "nann" are always incorrect)? See:
> > https://sourceware.org/bugzilla/show_bug.cgi?id=16975
>
> I don’t know, but I checked the other locales and the capitalization of
> these strings is unfortunatly inconsistent.

I think that incorrectly used uppercase is a smaller bug than incorrectly
used lowercase, and incorrectly used lowercase is a smaller bug than
wrong or no translation at all.  Also from another mail: 

5.07.2017 05:38 AKHILESH KUMAR <akhilesh.k@samsung.com> wrote:
> [...]
> Rafal, Ya and Nann should Start with uppercase

So my suggestion is to leave it as it is.  If this is wrong then I hope
someone with a better knowledge of Breton language will come to us
directly or to CLDR and report the problem.

The same about other locales which use the capitalization
inconsistently.

Regards,

Rafal
diff mbox

Patch

diff --git a/localedata/locales/br_FR b/localedata/locales/br_FR
index 3444cde..84c52eb 100644
--- a/localedata/locales/br_FR
+++ b/localedata/locales/br_FR
@@ -99,6 +99,8 @@  END LC_CTYPE
 LC_MESSAGES
 yesexpr "^[+1oOyY]"
 noexpr  "^[-0nN]"
+yesstr  "Ya"
+nostr   "Nann"
 END LC_MESSAGES
 
 LC_MONETARY