From patchwork Fri Nov 7 08:16:08 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexandre Oliva X-Patchwork-Id: 3602 Received: (qmail 25548 invoked by alias); 7 Nov 2014 08:16:34 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 25538 invoked by uid 89); 7 Nov 2014 08:16:33 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.3 required=5.0 tests=AWL, BAYES_00, RP_MATCHES_RCVD, SPF_HELO_PASS, SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com From: Alexandre Oliva To: libc-alpha@sourceware.org Subject: enable MTASC-safety sanity check in manual generation Date: Fri, 07 Nov 2014 06:16:08 -0200 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) MIME-Version: 1.0 I meant to post this shortly after the 2.19 release, but I forgot. This is not expected to have any visible effect, but if anyone gets the build to fail because of the error that was previously ignored, please let me know, and I'll look into it. Ok to install? From: Alexandre Oliva for ChangeLog * manual/check-safety.sh: Check that each @deftypefn or @deftypefun is followed by a @safety remark. * manual/Makefile ($(objpfx)stamp-summary): Require check-safety.sh to pass. --- manual/Makefile | 2 +- manual/check-safety.sh | 5 +++++ 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/manual/Makefile b/manual/Makefile index 62217a2..1f481f2 100644 --- a/manual/Makefile +++ b/manual/Makefile @@ -84,7 +84,7 @@ $(objpfx)libc/index.html: $(addprefix $(objpfx),$(libc-texi-generated)) $(objpfx)summary.texi: $(objpfx)stamp-summary ; $(objpfx)stamp-summary: summary.awk $(filter-out $(objpfx)summary.texi, \ $(texis-path)) - -$(SHELL) ./check-safety.sh $(filter-out $(objpfx)%, $(texis-path)) + $(SHELL) ./check-safety.sh $(filter-out $(objpfx)%, $(texis-path)) $(AWK) -f $^ | sort -t' ' -df -k 1,1 | tr '\014' '\012' \ > $(objpfx)summary-tmp $(move-if-change) $(objpfx)summary-tmp $(objpfx)summary.texi diff --git a/manual/check-safety.sh b/manual/check-safety.sh index 701624d..aaad313 100644 --- a/manual/check-safety.sh +++ b/manual/check-safety.sh @@ -30,6 +30,11 @@ success=: # If no arguments are given, take all *.texi files in the current directory. test $# != 0 || set *.texi +# FIXME: check that each @deftypefu?n is followed by a @safety note, +# with nothing but @deftypefu?nx and comment lines in between. (There +# might be more stuff too). + + # Check that all safety remarks have entries for all of MT, AS and AC, # in this order, with an optional prelim note before them. grep -n '^@safety' "$@" |