diff mbox

strfmon_l: Use specified locale for number formatting [BZ #19633]

Message ID ne0k6s$f4c$1@ger.gmane.org
State Committed
Headers show

Commit Message

Stefan Liebler April 5, 2016, 3:05 p.m. UTC
On 04/05/2016 02:50 PM, Andreas Schwab wrote:
> Stefan Liebler <stli@linux.vnet.ibm.com> writes:
>
>> diff --git a/stdio-common/printf_fp.c b/stdio-common/printf_fp.c
>> index baada9e..fb2a763 100644
>> --- a/stdio-common/printf_fp.c
>> +++ b/stdio-common/printf_fp.c
>> @@ -1248,8 +1248,8 @@ ___printf_fp_l (FILE *fp, locale_t loc,
>>     }
>>     return done;
>>   }
>> -ldbl_hidden_def (___printf_fp_l, __printf_fp_l)
>> -ldbl_strong_alias (___printf_fp_l, __printf_fp_l)
>> +libc_hidden_def (__printf_fp_l)
>> +strong_alias (___printf_fp_l, __printf_fp_l)
>
> Please rename ___printf_fp_l to __printf_fp_l, no need for the alias.
> Otherwise looks ok.
>
> Andreas.
>
Here is an updated patch to reflect the mentioned changes.
Okay to commit?

ChangeLog:

2016-04-05  Stefan Liebler  <stli@linux.vnet.ibm.com>

	* stdio-common/printf_fp.c (__printf_fp_l):
	Rename ___printf_fp_l to __printf_fp_l and
	remove strong alias. Use libc_hidden_def instead
	of ldbl_hidden_def macro.

Comments

Stefan Liebler April 11, 2016, 8:22 a.m. UTC | #1
@Andreas:
Just to be sure. Is this second patch okay? Then I`ll commit it.

Bye Stefan

On 04/05/2016 05:05 PM, Stefan Liebler wrote:
> On 04/05/2016 02:50 PM, Andreas Schwab wrote:
>> Stefan Liebler <stli@linux.vnet.ibm.com> writes:
>>
>>> diff --git a/stdio-common/printf_fp.c b/stdio-common/printf_fp.c
>>> index baada9e..fb2a763 100644
>>> --- a/stdio-common/printf_fp.c
>>> +++ b/stdio-common/printf_fp.c
>>> @@ -1248,8 +1248,8 @@ ___printf_fp_l (FILE *fp, locale_t loc,
>>>     }
>>>     return done;
>>>   }
>>> -ldbl_hidden_def (___printf_fp_l, __printf_fp_l)
>>> -ldbl_strong_alias (___printf_fp_l, __printf_fp_l)
>>> +libc_hidden_def (__printf_fp_l)
>>> +strong_alias (___printf_fp_l, __printf_fp_l)
>>
>> Please rename ___printf_fp_l to __printf_fp_l, no need for the alias.
>> Otherwise looks ok.
>>
>> Andreas.
>>
> Here is an updated patch to reflect the mentioned changes.
> Okay to commit?
>
> ChangeLog:
>
> 2016-04-05  Stefan Liebler  <stli@linux.vnet.ibm.com>
>
>      * stdio-common/printf_fp.c (__printf_fp_l):
>      Rename ___printf_fp_l to __printf_fp_l and
>      remove strong alias. Use libc_hidden_def instead
>      of ldbl_hidden_def macro.
Stefan Liebler April 14, 2016, 10:34 a.m. UTC | #2
On 04/05/2016 05:05 PM, Stefan Liebler wrote:
> On 04/05/2016 02:50 PM, Andreas Schwab wrote:
>> Stefan Liebler <stli@linux.vnet.ibm.com> writes:
>>
>>> diff --git a/stdio-common/printf_fp.c b/stdio-common/printf_fp.c
>>> index baada9e..fb2a763 100644
>>> --- a/stdio-common/printf_fp.c
>>> +++ b/stdio-common/printf_fp.c
>>> @@ -1248,8 +1248,8 @@ ___printf_fp_l (FILE *fp, locale_t loc,
>>>     }
>>>     return done;
>>>   }
>>> -ldbl_hidden_def (___printf_fp_l, __printf_fp_l)
>>> -ldbl_strong_alias (___printf_fp_l, __printf_fp_l)
>>> +libc_hidden_def (__printf_fp_l)
>>> +strong_alias (___printf_fp_l, __printf_fp_l)
>>
>> Please rename ___printf_fp_l to __printf_fp_l, no need for the alias.
>> Otherwise looks ok.
>>
>> Andreas.
>>
> Here is an updated patch to reflect the mentioned changes.
> Okay to commit?
>
> ChangeLog:
>
> 2016-04-05  Stefan Liebler  <stli@linux.vnet.ibm.com>
>
>      * stdio-common/printf_fp.c (__printf_fp_l):
>      Rename ___printf_fp_l to __printf_fp_l and
>      remove strong alias. Use libc_hidden_def instead
>      of ldbl_hidden_def macro.
Commited
diff mbox

Patch

diff --git a/stdio-common/printf_fp.c b/stdio-common/printf_fp.c
index baada9e..fdfe06b 100644
--- a/stdio-common/printf_fp.c
+++ b/stdio-common/printf_fp.c
@@ -209,9 +209,9 @@  hack_digit (struct hack_digit_param *p)
 }
 
 int
-___printf_fp_l (FILE *fp, locale_t loc,
-		const struct printf_info *info,
-		const void *const *args)
+__printf_fp_l (FILE *fp, locale_t loc,
+	       const struct printf_info *info,
+	       const void *const *args)
 {
   /* The floating-point value to output.  */
   union
@@ -1248,14 +1248,13 @@  ___printf_fp_l (FILE *fp, locale_t loc,
   }
   return done;
 }
-ldbl_hidden_def (___printf_fp_l, __printf_fp_l)
-ldbl_strong_alias (___printf_fp_l, __printf_fp_l)
+libc_hidden_def (__printf_fp_l)
 
 int
 ___printf_fp (FILE *fp, const struct printf_info *info,
 	      const void *const *args)
 {
-  return ___printf_fp_l (fp, _NL_CURRENT_LOCALE, info, args);
+  return __printf_fp_l (fp, _NL_CURRENT_LOCALE, info, args);
 }
 ldbl_hidden_def (___printf_fp, __printf_fp)
 ldbl_strong_alias (___printf_fp, __printf_fp)