Remove last remnants of have-protected

Message ID mvmwn1izzsp.fsf@suse.de
State Committed
Commit ea08d8dceab27ef464b9c00a03b5c61a741a634d
Headers
Series Remove last remnants of have-protected |

Checks

Context Check Description
dj/TryBot-apply_patch success Patch applied to master at the time it was sent
dj/TryBot-32bit success Build for i686

Commit Message

Andreas Schwab May 8, 2023, 2:02 p.m. UTC
  ---
 sysdeps/hppa/Makefile                     | 3 ---
 sysdeps/powerpc/powerpc32/Makefile        | 3 ---
 sysdeps/powerpc/powerpc32/libgcc-compat.S | 4 +---
 3 files changed, 1 insertion(+), 9 deletions(-)
  

Comments

Adhemerval Zanella Netto May 18, 2023, 12:37 p.m. UTC | #1
LGTM, thanks.

Reviewed-by: Adhemerval Zanella  <adhemerval.zanella@linaro.org>

On 08/05/23 11:02, Andreas Schwab via Libc-alpha wrote:
> ---
>  sysdeps/hppa/Makefile                     | 3 ---
>  sysdeps/powerpc/powerpc32/Makefile        | 3 ---
>  sysdeps/powerpc/powerpc32/libgcc-compat.S | 4 +---
>  3 files changed, 1 insertion(+), 9 deletions(-)
> 
> diff --git a/sysdeps/hppa/Makefile b/sysdeps/hppa/Makefile
> index 9531504c4b..b7765c31ec 100644
> --- a/sysdeps/hppa/Makefile
> +++ b/sysdeps/hppa/Makefile
> @@ -30,9 +30,6 @@ endif
>  ifeq ($(subdir),csu)
>  ifeq (yes,$(build-shared))
>  # Compatibility
> -ifeq (yes,$(have-protected))
> -CPPFLAGS-libgcc-compat.c = -DHAVE_DOT_HIDDEN
> -endif
>  sysdep_routines += libgcc-compat
>  shared-only-routines += libgcc-compat
>  endif
> diff --git a/sysdeps/powerpc/powerpc32/Makefile b/sysdeps/powerpc/powerpc32/Makefile
> index cf620c8269..1fff5b83bf 100644
> --- a/sysdeps/powerpc/powerpc32/Makefile
> +++ b/sysdeps/powerpc/powerpc32/Makefile
> @@ -35,9 +35,6 @@ CFLAGS-gmon-start.o = -G0
>  
>  ifeq (yes,$(build-shared))
>  # Compatibility
> -ifeq (yes,$(have-protected))
> -CPPFLAGS-libgcc-compat.S = -DHAVE_DOT_HIDDEN
> -endif
>  sysdep_routines += libgcc-compat
>  shared-only-routines += libgcc-compat
>  endif
> diff --git a/sysdeps/powerpc/powerpc32/libgcc-compat.S b/sysdeps/powerpc/powerpc32/libgcc-compat.S
> index ffa8f0a44a..6beac24039 100644
> --- a/sysdeps/powerpc/powerpc32/libgcc-compat.S
> +++ b/sysdeps/powerpc/powerpc32/libgcc-compat.S
> @@ -36,20 +36,18 @@
>  	.symver __floatdisf_v_glibc20,__floatdisf@GLIBC_2.0
>  #endif
>  
> -#ifdef HAVE_DOT_HIDDEN
>  	.hidden __ashldi3
>  	.hidden __ashrdi3
>  	.hidden __lshrdi3
>  	.hidden __cmpdi2
>  	.hidden __ucmpdi2
> -# if !defined _SOFT_FLOAT && !defined __NO_FPRS__
> +#if !defined _SOFT_FLOAT && !defined __NO_FPRS__
>  	.hidden __fixdfdi
>  	.hidden __fixsfdi
>  	.hidden __fixunsdfdi
>  	.hidden __fixunssfdi
>  	.hidden __floatdidf
>  	.hidden __floatdisf
> -# endif
>  #endif
>  
>  	.section	".text"
  

Patch

diff --git a/sysdeps/hppa/Makefile b/sysdeps/hppa/Makefile
index 9531504c4b..b7765c31ec 100644
--- a/sysdeps/hppa/Makefile
+++ b/sysdeps/hppa/Makefile
@@ -30,9 +30,6 @@  endif
 ifeq ($(subdir),csu)
 ifeq (yes,$(build-shared))
 # Compatibility
-ifeq (yes,$(have-protected))
-CPPFLAGS-libgcc-compat.c = -DHAVE_DOT_HIDDEN
-endif
 sysdep_routines += libgcc-compat
 shared-only-routines += libgcc-compat
 endif
diff --git a/sysdeps/powerpc/powerpc32/Makefile b/sysdeps/powerpc/powerpc32/Makefile
index cf620c8269..1fff5b83bf 100644
--- a/sysdeps/powerpc/powerpc32/Makefile
+++ b/sysdeps/powerpc/powerpc32/Makefile
@@ -35,9 +35,6 @@  CFLAGS-gmon-start.o = -G0
 
 ifeq (yes,$(build-shared))
 # Compatibility
-ifeq (yes,$(have-protected))
-CPPFLAGS-libgcc-compat.S = -DHAVE_DOT_HIDDEN
-endif
 sysdep_routines += libgcc-compat
 shared-only-routines += libgcc-compat
 endif
diff --git a/sysdeps/powerpc/powerpc32/libgcc-compat.S b/sysdeps/powerpc/powerpc32/libgcc-compat.S
index ffa8f0a44a..6beac24039 100644
--- a/sysdeps/powerpc/powerpc32/libgcc-compat.S
+++ b/sysdeps/powerpc/powerpc32/libgcc-compat.S
@@ -36,20 +36,18 @@ 
 	.symver __floatdisf_v_glibc20,__floatdisf@GLIBC_2.0
 #endif
 
-#ifdef HAVE_DOT_HIDDEN
 	.hidden __ashldi3
 	.hidden __ashrdi3
 	.hidden __lshrdi3
 	.hidden __cmpdi2
 	.hidden __ucmpdi2
-# if !defined _SOFT_FLOAT && !defined __NO_FPRS__
+#if !defined _SOFT_FLOAT && !defined __NO_FPRS__
 	.hidden __fixdfdi
 	.hidden __fixsfdi
 	.hidden __fixunsdfdi
 	.hidden __fixunssfdi
 	.hidden __floatdidf
 	.hidden __floatdisf
-# endif
 #endif
 
 	.section	".text"