From patchwork Tue Mar 25 11:44:21 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andreas Schwab X-Patchwork-Id: 268 Return-Path: X-Original-To: siddhesh@wilcox.dreamhost.com Delivered-To: siddhesh@wilcox.dreamhost.com Received: from homiemail-mx20.g.dreamhost.com (caibbdcaaahc.dreamhost.com [208.113.200.72]) by wilcox.dreamhost.com (Postfix) with ESMTP id 88511360166 for ; Tue, 25 Mar 2014 04:44:27 -0700 (PDT) Received: by homiemail-mx20.g.dreamhost.com (Postfix, from userid 14307373) id 1AA4840A1DA6E; Tue, 25 Mar 2014 04:44:27 -0700 (PDT) X-Original-To: glibc@patchwork.siddhesh.in Delivered-To: x14307373@homiemail-mx20.g.dreamhost.com Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by homiemail-mx20.g.dreamhost.com (Postfix) with ESMTPS id ECCD440B27A5F for ; Tue, 25 Mar 2014 04:44:26 -0700 (PDT) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:cc:subject:references:date:in-reply-to :message-id:mime-version:content-type; q=dns; s=default; b=uXit8 jcDIT61KNIPAmCjGImMUk2AtIRf38mY3eTXfEZATQcyfB8xnpqWHru74lc92SQHA Zwm7Yw0VobqpwUsnbm2RTfyMToEews9Xx8Lfea+Ozky6nzDocfv/6lBd/OXrhWrZ ym0luktjAPn8TZ4rjOELqQ/5eGHS9lesxKa7ys= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:cc:subject:references:date:in-reply-to :message-id:mime-version:content-type; s=default; bh=AqUFH8eu0D/ JHibybEjkfVY7+Vw=; b=YiSq3rVmwugFM/8+5zfH8CU7HKCWfjBdhSzXGF/jV99 PausW2sfsbj/8v9gmenI679/TZecHoUGAloBOiTVpSYfbwkGYPO/aV5yS+OACe5o uwzMkRHk8EgLJnOhZ6+L1JMcqQPOYau5FQ/m7G41uYyQlgSe1JKpRgznQHlyhvNE = Received: (qmail 6744 invoked by alias); 25 Mar 2014 11:44:25 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 6735 invoked by uid 89); 25 Mar 2014 11:44:24 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL, BAYES_20, RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx2.suse.de From: Andreas Schwab To: Siddhesh Poyarekar Cc: "Carlos O'Donell" , libc-alpha@sourceware.org Subject: Re: [PATCH 1/2] Separate ftell from fseek logic and avoid modifying FILE data (#16532) References: <20140220172904.GC16378@spoyarek.pnq.redhat.com> <53150D21.6090104@redhat.com> <20140304031330.GJ1722@spoyarek.pnq.redhat.com> X-Yow: Hello. I know the divorce rate among unmarried Catholic Alaskan females!! Date: Tue, 25 Mar 2014 12:44:21 +0100 In-Reply-To: <20140304031330.GJ1722@spoyarek.pnq.redhat.com> (Siddhesh Poyarekar's message of "Tue, 4 Mar 2014 08:43:30 +0530") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 X-DH-Original-To: glibc@patchwork.siddhesh.in Siddhesh Poyarekar writes: > diff --git a/libio/Makefile b/libio/Makefile > index 22dbcae..488ee51 100644 > --- a/libio/Makefile > +++ b/libio/Makefile > @@ -60,7 +60,7 @@ tests = tst_swprintf tst_wprintf tst_swscanf tst_wscanf tst_getwc tst_putwc \ > tst-wmemstream1 tst-wmemstream2 \ > bug-memstream1 bug-wmemstream1 \ > tst-setvbuf1 tst-popen1 tst-fgetwc bug-wsetpos tst-fseek \ > - tst-fwrite-error tst-ftell-partial-wide > + tst-fwrite-error tst-ftell-partial-wide tst-ftell-active-handler > ifeq (yes,$(build-shared)) > # Add test-fopenloc only if shared library is enabled since it depends on > # shared localedata objects. You need to set up LOCPATH so that the tests can find their locales. Installed as obvious. Andreas. * libio/Makefile (tst-ftell-partial-wide-ENV) (tst-ftell-active-handler-ENV): Define. diff --git a/libio/Makefile b/libio/Makefile index 69c25c0..cca0345 100644 --- a/libio/Makefile +++ b/libio/Makefile @@ -158,6 +158,8 @@ tst-swscanf-ENV = LOCPATH=$(common-objpfx)localedata bug-ftell-ENV = LOCPATH=$(common-objpfx)localedata tst-fgetwc-ENV = LOCPATH=$(common-objpfx)localedata tst-fseek-ENV = LOCPATH=$(common-objpfx)localedata +tst-ftell-partial-wide-ENV = LOCPATH=$(common-objpfx)localedata +tst-ftell-active-handler-ENV = LOCPATH=$(common-objpfx)localedata generated += tst-fopenloc.mtrace tst-fopenloc.check