From patchwork Tue Mar 25 12:00:46 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andreas Schwab X-Patchwork-Id: 269 Return-Path: X-Original-To: siddhesh@wilcox.dreamhost.com Delivered-To: siddhesh@wilcox.dreamhost.com Received: from homiemail-mx20.g.dreamhost.com (caibbdcaaahc.dreamhost.com [208.113.200.72]) by wilcox.dreamhost.com (Postfix) with ESMTP id 92F85360166 for ; Tue, 25 Mar 2014 05:00:54 -0700 (PDT) Received: by homiemail-mx20.g.dreamhost.com (Postfix, from userid 14307373) id 4480D40B27A00; Tue, 25 Mar 2014 05:00:54 -0700 (PDT) X-Original-To: glibc@patchwork.siddhesh.in Delivered-To: x14307373@homiemail-mx20.g.dreamhost.com Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by homiemail-mx20.g.dreamhost.com (Postfix) with ESMTPS id 257B940E9CCDA for ; Tue, 25 Mar 2014 05:00:54 -0700 (PDT) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:subject:date:message-id:mime-version :content-type; q=dns; s=default; b=MDq2E87ZZFRjZ+WdC0tEixCKUTJYz iwmkesHRpUSgX66Q8dcQH0ty1u1y3HvgVcDlw1SrgW78Vs0WV7D3iKG8ISMg2QA9 kU4jhy8zmW/4rb/mNmFE0cNSdnFwmpcQxu18mpNKCGVSkMfnDgsSeiqyKYcu89Q2 z6Zo5+vg2QkrwA= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:subject:date:message-id:mime-version :content-type; s=default; bh=pGR6vnW7fnUI4TLGMv9c1Tay7EM=; b=E8q I266rYQOedRfwbmLeuQ4FS8MoHDo8EcJ2QtaPdh7KTrmP0ED1lut+FjVWIpSSWd0 WYhIe29QbUCS66jIfdWm/RCLGMTI1RyjLoFJoFFHNnfuhHLW1uHG1uES8oH5MM3y bZ36KB6ytb57POElJGUv8wIPlLuEZc2isdFQNmnU= Received: (qmail 24109 invoked by alias); 25 Mar 2014 12:00:52 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 24099 invoked by uid 89); 25 Mar 2014 12:00:51 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.1 required=5.0 tests=AWL, BAYES_00, RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx2.suse.de From: Andreas Schwab To: libc-alpha@sourceware.org Subject: [PATCH] Fix -Wundef warning for ONE_DIRECTION in iconv/skeleton.c X-Yow: What I want to find out is -- do parrots know much about Astro-Turf? Date: Tue, 25 Mar 2014 13:00:46 +0100 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 X-DH-Original-To: glibc@patchwork.siddhesh.in All places that define ONE_DIRECTION define it to 1, so I think this is the right way to fix the warning. Andreas. * iconv/skeleton.c (ONE_DIRECTION): Check for definedness, not value. --- iconv/skeleton.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/iconv/skeleton.c b/iconv/skeleton.c index 14318a6..d1b89b0 100644 --- a/iconv/skeleton.c +++ b/iconv/skeleton.c @@ -564,7 +564,7 @@ FUNCTION_NAME (struct __gconv_step *step, struct __gconv_step_data *data, outend, lirreversiblep EXTRA_LOOP_ARGS); # endif -# if !ONE_DIRECTION +# ifndef ONE_DIRECTION # if FROM_LOOP_MAX_NEEDED_FROM > 1 && TO_LOOP_MAX_NEEDED_FROM > 1 else # endif