From patchwork Thu Jul  9 08:23:46 2015
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-Patchwork-Submitter: Stefan Liebler <stli@linux.vnet.ibm.com>
X-Patchwork-Id: 7605
Received: (qmail 41614 invoked by alias); 9 Jul 2015 08:25:10 -0000
Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <libc-alpha.sourceware.org>
List-Unsubscribe: <mailto:libc-alpha-unsubscribe-##L=##H@sourceware.org>
List-Subscribe: <mailto:libc-alpha-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/libc-alpha/>
List-Post: <mailto:libc-alpha@sourceware.org>
List-Help: <mailto:libc-alpha-help@sourceware.org>,
	<http://sourceware.org/ml/#faqs>
Sender: libc-alpha-owner@sourceware.org
Delivered-To: mailing list libc-alpha@sourceware.org
Received: (qmail 41597 invoked by uid 89); 9 Jul 2015 08:25:09 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-2.7 required=5.0 tests=AWL, BAYES_00,
	RCVD_IN_DNSWL_LOW, RP_MATCHES_RCVD, SPF_HELO_PASS,
	SPF_PASS autolearn=ham version=3.3.2
X-HELO: plane.gmane.org
To: libc-alpha@sourceware.org
From: Stefan Liebler <stli@linux.vnet.ibm.com>
Subject: Re: [PATCH][BZ #18508] S390: Fix "backtrace() returns infinitely
	deep stack frames with makecontext()".
Date: Thu, 09 Jul 2015 10:23:46 +0200
Lines: 72
Message-ID: <mnlb2i$md$2@ger.gmane.org>
References: <ml71gu$et2$1@ger.gmane.org>	<557AA306.4090208@redhat.com>
	<mleq97$5v2$1@ger.gmane.org>	<87eglhvsst.fsf@igel.home>
	<mlm3f3$bbu$1@ger.gmane.org>	<559651D0.1030704@redhat.com>
	<CAMe9rOqs_DPaN=h_dnskMEyvSkG6PrVhr2vXJp7+_sejKenXBg@mail.gmail.com>
	<CAMe9rOr+tMWUN8ruaLoA9wT_bEcgJx4dfzjXSEVqSwRh-LK7ng@mail.gmail.com>
	<559C224F.2090600@redhat.com> <mnj3c8$npj$1@ger.gmane.org>
	<559D372C.9070105@redhat.com> <559D3794.3020408@redhat.com>
Mime-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64;
	rv:31.0) Gecko/20100101 Thunderbird/31.7.0
In-Reply-To: <559D3794.3020408@redhat.com>

On 07/08/2015 04:45 PM, Carlos O'Donell wrote:
> On 07/08/2015 10:43 AM, Carlos O'Donell wrote:
>> On 07/08/2015 08:00 AM, Stefan Liebler wrote:
>>> On 07/07/2015 09:02 PM, Carlos O'Donell wrote:
>>>> On 07/07/2015 01:47 PM, H.J. Lu wrote:
>>>>> I opened:
>>>>> https://sourceware.org/bugzilla/show_bug.cgi?id=18635
>>>>
>>>> Stefan,
>>>>
>>>> Please fix this promptly as glibc 2.22 will be released
>>>> shortly and the test results should be clean. If we can't
>>>> fix it promptly, then we should revert the test changes.
>>>>
>>>> Cheers,
>>>> Carlos.
>>>>
>>> Hi,
>>>
>>> the testcase seems to be okay, but there is a bug in i686 backtrace handling if the context was set via makecontext.
>>> If we revert the test changes, the test case will pass, but the bug is only hidden.
>>
>> If that's the case then please file a bug on sourceware for
>> this particular failure, mark the test as XFAIL for i686 and
>> use a comment to reference the bug when you mark it XFAIL.
>
> Bug 18635 was already filed by H.J, so use that.
>
> c.
>
>

This patch marks stdlib/tst-makecontext as XFAIL for i686.
Ok to commit?

Bye
Stefan
---
2015-07-09  Stefan Liebler  <stli@linux.vnet.ibm.com>

	* sysdeps/i386/i686/Makefile (test-xfail-tst-makecontext):
	New variable.

diff --git a/sysdeps/i386/i686/Makefile b/sysdeps/i386/i686/Makefile
index 5ce9fc6..83517c4 100644
--- a/sysdeps/i386/i686/Makefile
+++ b/sysdeps/i386/i686/Makefile
@@ -18,3 +18,9 @@ ASFLAGS-.op += -Wa,-mtune=i686
 ASFLAGS-.og += -Wa,-mtune=i686
 ASFLAGS-.oS += -Wa,-mtune=i686
 endif
+
+ifeq ($(subdir),stdlib)
+# _Unwind_Backtrace from libgcc produces a segmentation fault if it was
+# called within a context created by makecontext. See Bug 18635.
+test-xfail-tst-makecontext = yes
+endif