From patchwork Thu Dec 11 11:58:58 2014
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Patchwork-Submitter: Stefan Liebler <stli@linux.vnet.ibm.com>
X-Patchwork-Id: 4178
X-Patchwork-Delegate: azanella@linux.vnet.ibm.com
Received: (qmail 9455 invoked by alias); 11 Dec 2014 11:59:16 -0000
Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <libc-alpha.sourceware.org>
List-Unsubscribe: <mailto:libc-alpha-unsubscribe-##L=##H@sourceware.org>
List-Subscribe: <mailto:libc-alpha-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/libc-alpha/>
List-Post: <mailto:libc-alpha@sourceware.org>
List-Help: <mailto:libc-alpha-help@sourceware.org>,
	<http://sourceware.org/ml/#faqs>
Sender: libc-alpha-owner@sourceware.org
Delivered-To: mailing list libc-alpha@sourceware.org
Received: (qmail 9443 invoked by uid 89); 11 Dec 2014 11:59:15 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL, BAYES_00,
	RCVD_IN_DNSWL_LOW, SPF_HELO_PASS, SPF_PASS,
	T_RP_MATCHES_RCVD autolearn=ham version=3.3.2
X-HELO: plane.gmane.org
To: libc-alpha@sourceware.org
From: Stefan Liebler <stli@linux.vnet.ibm.com>
Subject: Re: [PATCH] powerpc: Fix unitialized variable
Date: Thu, 11 Dec 2014 12:58:58 +0100
Lines: 58
Message-ID: <m6c0u2$o15$1@ger.gmane.org>
References: <54889AAC.3060404@linux.vnet.ibm.com>
	<alpine.DEB.2.10.1412102119230.26602@digraph.polyomino.org.uk>
	<5488DA58.9010505@linux.vnet.ibm.com>
	<m6bvp4$tus$1@ger.gmane.org> <mvmsigmpfku.fsf@hawking.suse.de>
Mime-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64;
	rv:31.0) Gecko/20100101 Thunderbird/31.2.0
In-Reply-To: <mvmsigmpfku.fsf@hawking.suse.de>

On 12/11/2014 12:54 PM, Andreas Schwab wrote:
> Stefan Liebler <stli@linux.vnet.ibm.com> writes:
>
>> +	/* There´s the following warning on S390:
>
> Please avoid non-ascii.
>
> Andreas.
>
Oh. Ok. Here is it without ´.
---
2014-12-11  Stefan Liebler  <stli@linux.vnet.ibm.com>

	resolv/res_send.c (send_vc): Disable warning resplen may
	be used uninitialized.

diff --git a/resolv/res_send.c b/resolv/res_send.c
index af42b8a..22b322c 100644
--- a/resolv/res_send.c
+++ b/resolv/res_send.c
@@ -96,6 +96,7 @@ static const char rcsid[] = "$BINDId: res_send.c,v 8.38 2000/03/30 20:16:51 vixi
 #include <string.h>
 #include <unistd.h>
 #include <kernel-features.h>
+#include <libc-internal.h>
 
 #if PACKETSZ > 65536
 #define MAXPACKET       PACKETSZ
@@ -668,7 +669,17 @@ send_vc(res_state statp,
 	// int anssiz = *anssizp;
 	HEADER *anhp = (HEADER *) ans;
 	struct sockaddr_in6 *nsap = EXT(statp).nsaddrs[ns];
-	int truncating, connreset, resplen, n;
+	int truncating, connreset, n;
+	/* There is the following warning on S390:
+	   'resplen' may be used uninitialized in this function
+	   [-Wmaybe-uninitialized]
+	   This is a false positive according to:
+	   https://www.sourceware.org/ml/libc-alpha/2014-12/msg00323.html
+	 */
+	DIAG_PUSH_NEEDS_COMMENT;
+	DIAG_IGNORE_NEEDS_COMMENT (5, "-Wmaybe-uninitialized");
+	int resplen;
+	DIAG_POP_NEEDS_COMMENT;
 	struct iovec iov[4];
 	u_short len;
 	u_short len2;
@@ -788,8 +799,11 @@ send_vc(res_state statp,
 			   reply.  We can try to use the rest
 			   of the user-provided buffer.  */
 #if _STRING_ARCH_unaligned
+			DIAG_PUSH_NEEDS_COMMENT;
+			DIAG_IGNORE_NEEDS_COMMENT (5, "-Wmaybe-uninitialized");
 			*anssizp2 = orig_anssizp - resplen;
 			*ansp2 = *ansp + resplen;
+			DIAG_POP_NEEDS_COMMENT;
 #else
 			int aligned_resplen
 			  = ((resplen + __alignof__ (HEADER) - 1)