Message ID | liom5p$b8e$2@ger.gmane.org |
---|---|
State | Committed |
Headers |
Return-Path: <x14307373@homiemail-mx23.g.dreamhost.com> X-Original-To: siddhesh@wilcox.dreamhost.com Delivered-To: siddhesh@wilcox.dreamhost.com Received: from homiemail-mx23.g.dreamhost.com (mx2.sub5.homie.mail.dreamhost.com [208.113.200.128]) by wilcox.dreamhost.com (Postfix) with ESMTP id A8903360060 for <siddhesh@wilcox.dreamhost.com>; Thu, 17 Apr 2014 06:50:11 -0700 (PDT) Received: by homiemail-mx23.g.dreamhost.com (Postfix, from userid 14307373) id 58C6462B0F933; Thu, 17 Apr 2014 06:50:10 -0700 (PDT) X-Original-To: glibc@patchwork.siddhesh.in Delivered-To: x14307373@homiemail-mx23.g.dreamhost.com Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by homiemail-mx23.g.dreamhost.com (Postfix) with ESMTPS id C1F2162B0F922 for <glibc@patchwork.siddhesh.in>; Thu, 17 Apr 2014 06:50:10 -0700 (PDT) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:to:from:subject:date:message-id:references :mime-version:content-type:in-reply-to; q=dns; s=default; b=W34y ABF/5A8g1Knmkb2IYTza1CNKiBZtErbL1WkLFQAUL2z3H9C6yhZr+4W/B85yztH7 0msAoGHiR8idIB9W/4kWGDFtEB5aZK3X2S8poTQBqr92OwUvaRl0ZuqsOii1h/SY 7Bd3J91C8r7b3kVUmtryYtnsRE4Olv0qlAmJO48= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:to:from:subject:date:message-id:references :mime-version:content-type:in-reply-to; s=default; bh=0rmXQkxHxg +TwNfrXoFT6UU8PVg=; b=d8iJh6MrfeMLa/DZADHpa/8xHWKB1/foASFZg/duLX PFVv+b3sf6peiCx6CyCUFDKTLDDOl6wMh39GhhAVO2ZxfY9dV4mRsGnsXk040UqF AWRxWJtBaGtDsRUsW10RLFz+q/iwxfngvXwZkd4x5o+xHO8W4rW9CCR/4STyiqg+ 0= Received: (qmail 13146 invoked by alias); 17 Apr 2014 13:50:09 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: <libc-alpha.sourceware.org> List-Unsubscribe: <mailto:libc-alpha-unsubscribe-glibc=patchwork.siddhesh.in@sourceware.org> List-Subscribe: <mailto:libc-alpha-subscribe@sourceware.org> List-Archive: <http://sourceware.org/ml/libc-alpha/> List-Post: <mailto:libc-alpha@sourceware.org> List-Help: <mailto:libc-alpha-help@sourceware.org>, <http://sourceware.org/ml/#faqs> Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 13134 invoked by uid 89); 17 Apr 2014 13:50:08 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL, BAYES_00, RCVD_IN_DNSWL_NONE, RP_MATCHES_RCVD, SPF_HELO_PASS, SPF_PASS autolearn=ham version=3.3.2 X-HELO: plane.gmane.org To: libc-alpha@sourceware.org From: Stefan Liebler <stli@linux.vnet.ibm.com> Subject: Re: [PATCH] Do not run timezone tests in parallel. Date: Thu, 17 Apr 2014 15:49:45 +0200 Lines: 59 Message-ID: <liom5p$b8e$2@ger.gmane.org> References: <lijgrq$f8s$1@ger.gmane.org> <mvmioq937c5.fsf@hawking.suse.de> <lim753$h6c$1@ger.gmane.org> <mvmd2gh2t08.fsf@hawking.suse.de> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------020901050606020009030801" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 In-Reply-To: <mvmd2gh2t08.fsf@hawking.suse.de> X-DH-Original-To: glibc@patchwork.siddhesh.in |
Commit Message
Stefan Liebler
April 17, 2014, 1:49 p.m. UTC
On 04/16/2014 05:28 PM, Andreas Schwab wrote: > That has nothing to do with parallel execution, but only with the fact > that the pattern rule creates two targets with a single command, but it > is unspecified which target triggers it. There are no races involved. > > Andreas. > Yes you are right. The rule creates two targets, should it create also two test-result files? The attached patch generates the second test-result file as a copy of the generated one. Thus the testsuite can rely on the existence of the test-result files regardless of which target has triggered the rule. Is this the right way? What is your idea? Bye --- 2014-04-17 Stefan Liebler <stli@linux.vnet.ibm.com> * timezone/Makefile (%/UTC %/Universal): Generate test-result files for UTC and Universal. ---
Comments
ping On 04/17/2014 03:49 PM, Stefan Liebler wrote: > On 04/16/2014 05:28 PM, Andreas Schwab wrote: >> That has nothing to do with parallel execution, but only with the fact >> that the pattern rule creates two targets with a single command, but it >> is unspecified which target triggers it. There are no races involved. >> >> Andreas. >> > > Yes you are right. > The rule creates two targets, should it create also two test-result > files? The attached patch generates the second test-result file as a > copy of the generated one. > Thus the testsuite can rely on the existence of the test-result files > regardless of which target has triggered the rule. > > Is this the right way? > What is your idea? > > Bye > > --- > 2014-04-17 Stefan Liebler <stli@linux.vnet.ibm.com> > > * timezone/Makefile (%/UTC %/Universal): > Generate test-result files for UTC and Universal. > --- >
On Thu, 17 Apr 2014, Stefan Liebler wrote: > On 04/16/2014 05:28 PM, Andreas Schwab wrote: > > That has nothing to do with parallel execution, but only with the fact > > that the pattern rule creates two targets with a single command, but it > > is unspecified which target triggers it. There are no races involved. > > > > Andreas. > > > > Yes you are right. > The rule creates two targets, should it create also two test-result files? The > attached patch generates the second test-result file as a copy of the > generated one. > Thus the testsuite can rely on the existence of the test-result files > regardless of which target has triggered the rule. > > Is this the right way? > What is your idea? > > Bye > > --- > 2014-04-17 Stefan Liebler <stli@linux.vnet.ibm.com> > > * timezone/Makefile (%/UTC %/Universal): > Generate test-result files for UTC and Universal. This patch <https://sourceware.org/ml/libc-alpha/2014-04/msg00359.html> is OK, please commit.
On Fri, Jun 12, 2015 at 08:59:10PM +0000, Joseph Myers wrote: > > 2014-04-17 Stefan Liebler <stli@linux.vnet.ibm.com> > > > > * timezone/Makefile (%/UTC %/Universal): > > Generate test-result files for UTC and Universal. > > This patch <https://sourceware.org/ml/libc-alpha/2014-04/msg00359.html> is > OK, please commit. Applied. Thanks! -Andreas-
diff --git a/timezone/Makefile b/timezone/Makefile index 998cd14..47129e8 100644 --- a/timezone/Makefile +++ b/timezone/Makefile @@ -106,6 +106,12 @@ $(testdata)/Etc/UTC: etcetera $(zic-deps) # Two separate targets built separately can collide if in parallel. %/UTC %/Universal: simplebackw $(zic-deps) %/Etc/UTC $(build-testdata) + { test -r $(@D)/Universal.test-result \ + && cp $(@D)/Universal.test-result $(@D)/UTC.test-result \ + && sed -i 's/Universal/UTC/' $(@D)/UTC.test-result ; exit 0; } + { test -r $(@D)/UTC.test-result \ + && cp $(@D)/UTC.test-result $(@D)/Universal.test-result \ + && sed -i 's/UTC/Universal/' $(@D)/Universal.test-result ; exit 0; } $(testdata)/%/Berlin $(testdata)/%/London: europe $(zic-deps) $(build-testdata) $(testdata)/Australia/Melbourne: australasia $(zic-deps)