From patchwork Tue Apr 15 14:48:26 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Liebler X-Patchwork-Id: 562 Return-Path: X-Original-To: siddhesh@wilcox.dreamhost.com Delivered-To: siddhesh@wilcox.dreamhost.com Received: from homiemail-mx23.g.dreamhost.com (mx2.sub5.homie.mail.dreamhost.com [208.113.200.128]) by wilcox.dreamhost.com (Postfix) with ESMTP id 4BBB9360072 for ; Tue, 15 Apr 2014 07:48:51 -0700 (PDT) Received: by homiemail-mx23.g.dreamhost.com (Postfix, from userid 14307373) id D978062B2423C; Tue, 15 Apr 2014 07:48:50 -0700 (PDT) X-Original-To: glibc@patchwork.siddhesh.in Delivered-To: x14307373@homiemail-mx23.g.dreamhost.com Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by homiemail-mx23.g.dreamhost.com (Postfix) with ESMTPS id 6F88662B02957 for ; Tue, 15 Apr 2014 07:48:50 -0700 (PDT) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:to:from:subject:date:message-id:mime-version :content-type; q=dns; s=default; b=SyXn5N4choJ+zUjxd8lA9MGKmQNUJ n1h0BsWxUGxYFkRe+rX2I5fAUCsb3RIcgBatLOmkYBPmAPgJ/r4RTAvZ3rtZmazP sIWA6lBdHNPIcjOS/+Kk/tPrW5TrPU8IHniDmEQxGYby5hhXEeAolRuI3LJBttMB em0aIpoIu2eWp8= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:to:from:subject:date:message-id:mime-version :content-type; s=default; bh=FkmxnbJHxgED4oZn/49Yk6EhH7Q=; b=VWS nZisa6ff3gG9eIleT621jVW3fBm/mrdSOQRJBN4yuOlOf+Pr++FOGZzbjYksloln s04R29Ai9+rxW/+p9cfzcUgAs+Hj4UhpZnE53xwZxbZfX5KERy1X2v9YN6aRLfr1 ndO+yKHT9ktj1QuxaPAfj8e0cTtvBoN4YqeczL+8= Received: (qmail 10396 invoked by alias); 15 Apr 2014 14:48:47 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 10382 invoked by uid 89); 15 Apr 2014 14:48:45 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL, BAYES_00, RCVD_IN_DNSWL_NONE, RP_MATCHES_RCVD, SPF_HELO_PASS, SPF_PASS autolearn=ham version=3.3.2 X-HELO: plane.gmane.org To: libc-alpha@sourceware.org From: Stefan Liebler Subject: [PATCH] Do not run timezone tests in parallel. Date: Tue, 15 Apr 2014 16:48:26 +0200 Lines: 57 Message-ID: Mime-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 X-DH-Original-To: glibc@patchwork.siddhesh.in Hi, running the testsuite with PARALLELMFLAGS="-j2" leads to an UNRESOLVED test: timezone/testdata/UTC. -> The timezone/testdata/UTC.test-result file does not exist and timezone/testdata/Etc/UTC.test-result exists. According to the output of make, Etc/UTC is called directly before UTC and both targets collide in parallel execution. Thus we should not execute the timezone-tests in parallel. Ok to commit? Bye --- 2014-04-15 Stefan Liebler * timezone/Makefile: Do nothing in parallel. --- diff --git a/timezone/Makefile b/timezone/Makefile index 998cd14..2f6e80e 100644 --- a/timezone/Makefile +++ b/timezone/Makefile @@ -85,6 +85,9 @@ GCONV_PATH=${common-objpfx}iconvdata LANGUAGE=C LC_ALL=C \ $(evaluate-test) endef + +.NOTPARALLEL: + $(objpfx)test-tz.out: $(addprefix $(testdata)/, America/New_York Etc/UTC UTC) $(objpfx)tst-timezone.out: $(addprefix $(testdata)/, \ Europe/Berlin Universal \ @@ -102,7 +105,6 @@ $(testdata)/America/New_York: northamerica $(zic-deps) $(build-testdata) $(testdata)/Etc/UTC: etcetera $(zic-deps) $(build-testdata) -# Use a pattern rule to indicate the command produces both targets at once. # Two separate targets built separately can collide if in parallel. %/UTC %/Universal: simplebackw $(zic-deps) %/Etc/UTC $(build-testdata)