S/390:

Message ID	lfuu4e$uam$3@ger.gmane.org
State	Superseded
Headers	DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:to:from:subject:date:message-id:mime-version :content-type; q=dns; s=default; b=RL5BV2FpvuJDrsfKtByEsGB3tBjB5 WFv81VlWbQBcMMWMmPauR6HjsN/WqXYv3CSvSh0YLAnyu8taQcXIaYrTrx2vHGa2 YQDkM3fb5CkuQoLemAfqzCtFq+CuJmN/GcDWHf4/pQ9+A5XhhfhPkpaqeGImkPSn 9+jWe/P4Yqwywo= Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk Sender: libc-alpha-owner@sourceware.org To: libc-alpha@sourceware.org From: Stefan Liebler <stli@linux.vnet.ibm.com> Subject: [PATCH] S/390: Date: Fri, 14 Mar 2014 13:53:48 +0100 Lines: 65 Message-ID: <lfuu4e$uam$3@ger.gmane.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------020402090400070007020500" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0

Message ID

lfuu4e$uam$3@ger.gmane.org

State

Superseded

Headers

DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id
	:list-unsubscribe:list-subscribe:list-archive:list-post
	:list-help:sender:to:from:subject:date:message-id:mime-version
	:content-type; q=dns; s=default; b=RL5BV2FpvuJDrsfKtByEsGB3tBjB5
	WFv81VlWbQBcMMWMmPauR6HjsN/WqXYv3CSvSh0YLAnyu8taQcXIaYrTrx2vHGa2
	YQDkM3fb5CkuQoLemAfqzCtFq+CuJmN/GcDWHf4/pQ9+A5XhhfhPkpaqeGImkPSn
	9+jWe/P4Yqwywo=
Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm
Precedence: bulk
Sender: libc-alpha-owner@sourceware.org
To: libc-alpha@sourceware.org
From: Stefan Liebler <stli@linux.vnet.ibm.com>
Subject: [PATCH] S/390:
Date: Fri, 14 Mar 2014 13:53:48 +0100
Lines: 65
Message-ID: <lfuu4e$uam$3@ger.gmane.org>
Mime-Version: 1.0
Content-Type: multipart/mixed;
	boundary="------------020402090400070007020500"
User-Agent: Mozilla/5.0 (X11; Linux x86_64;
	rv:24.0) Gecko/20100101 Thunderbird/24.3.0

Commit Message

Stefan Liebler March 14, 2014, 12:53 p.m. UTC

  Hi,

The conformance tests for ISO99, ISO11, XOPEN2K, POSIX2008 and XOPEN2K8
are failing on S390 for the inttypes.h and stdint.h headers.
The problem is that on S390 size_t / __SIZE_TYPE__
are defined as long unsigned int,
which has the same size as unsigned int (on S390).
SIZE_MAX is defined in sysdeps/generic/stdint.h as 4294967295U.
The conformance-test checks the type of SIZE_MAX,
which should be promoted to __SIZE_TYPE__, but it is unsigned int.

Bye

---
2014-03-14  Stefan Liebler  <stli@linux.vnet.ibm.com>

	* sysdeps/s390/s390-32/Makefile
	(test-xfail-ISO99/inttypes.h/conform): New Variable.
	(test-xfail-ISO99/stdint.h/conform): Likewise.
	(test-xfail-ISO11/inttypes.h/conform): Likewise.
	(test-xfail-ISO11/stdint.h/conform): Likewise.
	(test-xfail-XOPEN2K/inttypes.h/conform): Likewise.
	(test-xfail-XOPEN2K/stdint.h/conform): Likewise.
	(test-xfail-POSIX2008/inttypes.h/conform): Likewise.
	(test-xfail-POSIX2008/stdint.h/conform): Likewise.
	(test-xfail-XOPEN2K8/inttypes.h/conform): Likewise.
	(test-xfail-XOPEN2K8/stdint.h/conform): Likewise.
---
\ No newline at end of file

Comments

Joseph Myers March 14, 2014, 2:18 p.m. UTC | #1

On Fri, 14 Mar 2014, Stefan Liebler wrote:

> Hi,
> 
> The conformance tests for ISO99, ISO11, XOPEN2K, POSIX2008 and XOPEN2K8
> are failing on S390 for the inttypes.h and stdint.h headers.
> The problem is that on S390 size_t / __SIZE_TYPE__
> are defined as long unsigned int,
> which has the same size as unsigned int (on S390).
> SIZE_MAX is defined in sysdeps/generic/stdint.h as 4294967295U.
> The conformance-test checks the type of SIZE_MAX,
> which should be promoted to __SIZE_TYPE__, but it is unsigned int.

You should fix the header rather than marking these tests as expected to 
fail.  (Of course, file a bug in Bugzilla before fixing it, as usual.)  To 
avoid duplicating the whole header, maybe add a macro <bits/wordsize.h> 
can define such as __WORDSIZE32_SIZE_ULONG, and then test that macro in 
<stdint.h>.

(You have two identical bits/wordsize.h files for S/390.  Just one should 
suffice.)

diff mbox

Patch

diff --git a/sysdeps/s390/s390-32/Makefile b/sysdeps/s390/s390-32/Makefile
index 057862d..e7f3934 100644
--- a/sysdeps/s390/s390-32/Makefile
+++ b/sysdeps/s390/s390-32/Makefile
@@ -9,3 +9,16 @@  CFLAGS-rtld.c += -Wno-uninitialized -Wno-unused
 CFLAGS-dl-load.c += -Wno-unused
 CFLAGS-dl-reloc.c += -Wno-unused
 endif
+
+ifeq ($(subdir),conform)
+test-xfail-ISO99/inttypes.h/conform = yes
+test-xfail-ISO99/stdint.h/conform = yes
+test-xfail-ISO11/inttypes.h/conform = yes
+test-xfail-ISO11/stdint.h/conform = yes
+test-xfail-XOPEN2K/inttypes.h/conform = yes
+test-xfail-XOPEN2K/stdint.h/conform = yes
+test-xfail-POSIX2008/inttypes.h/conform = yes
+test-xfail-POSIX2008/stdint.h/conform = yes
+test-xfail-XOPEN2K8/inttypes.h/conform = yes
+test-xfail-XOPEN2K8/stdint.h/conform = yes
+endif