diff mbox series

[v2,10/23] nscd: Use uint8_t instead of bitfield in struct hashentry

Message ID f50f77798e80eb5692678ac9c87e5ac05e9bfea6.1774037705.git.fweimer@redhat.com (mailing list archive)
State Failed CI
Headers
Series NSS, nscd updates (for group merging and more) |

Checks

Context Check Description
redhat-pt-bot/TryBot-apply_patch success Patch applied to master at the time it was sent
linaro-tcwg-bot/tcwg_glibc_build--master-arm success Build passed
linaro-tcwg-bot/tcwg_glibc_build--master-aarch64 success Build passed
linaro-tcwg-bot/tcwg_glibc_check--master-aarch64 fail Test failed
linaro-tcwg-bot/tcwg_glibc_check--master-arm fail Test failed

Commit Message

Florian Weimer March 20, 2026, 8:42 p.m. UTC 
  This enables access through <concurrent_buffer.h>
---
 nscd/nscd-client.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Carlos O'Donell March 24, 2026, 5:53 p.m. UTC | #1 
On 3/20/26 4:42 PM, Florian Weimer wrote:
> This enables access through <concurrent_buffer.h>

LGTM.

Reviewed-by: Carlos O'Donell <carlos@redhat.com>

> ---
>   nscd/nscd-client.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/nscd/nscd-client.h b/nscd/nscd-client.h
> index dd7421c5d1..c507933acb 100644
> --- a/nscd/nscd-client.h
> +++ b/nscd/nscd-client.h
> @@ -283,7 +283,7 @@ datahead_init_neg (struct datahead *head, nscd_ssize_t allocsize,
>   /* Structure for one hash table entry.  */
>   struct hashentry
>   {
> -  request_type type:8;		/* Which type of dataset.  */
> +  uint8_t type;			/* Type of dataset; see request_type.  */
>     bool first;			/* True if this was the original key.  */
>     nscd_ssize_t len;		/* Length of key.  */
>     ref_t key;			/* Pointer to key.  */
diff mbox series

Patch

diff --git a/nscd/nscd-client.h b/nscd/nscd-client.h
index dd7421c5d1..c507933acb 100644
--- a/nscd/nscd-client.h
+++ b/nscd/nscd-client.h
@@ -283,7 +283,7 @@  datahead_init_neg (struct datahead *head, nscd_ssize_t allocsize,
 /* Structure for one hash table entry.  */
 struct hashentry
 {
-  request_type type:8;		/* Which type of dataset.  */
+  uint8_t type;			/* Type of dataset; see request_type.  */
   bool first;			/* True if this was the original key.  */
   nscd_ssize_t len;		/* Length of key.  */
   ref_t key;			/* Pointer to key.  */