From patchwork Thu Oct 31 20:53:00 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paul Eggert X-Patchwork-Id: 35539 Received: (qmail 114982 invoked by alias); 31 Oct 2019 20:53:05 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 114974 invoked by uid 89); 31 Oct 2019 20:53:05 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-15.2 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, KAM_LOTSOFHASH, SPF_PASS autolearn=ham version=3.3.1 spammy=singapore, Singapore, H*i:sk:8170c7c, H*MI:sk:8170c7c X-HELO: zimbra.cs.ucla.edu Subject: Re: [PATCH 1/2] Sync intprops.h with gnulib To: Adhemerval Zanella Cc: libc-alpha@sourceware.org References: <20191031182527.26933-1-adhemerval.zanella@linaro.org> <8170c7c9-d405-dfdc-325c-c8f1438926f8@linaro.org> From: Paul Eggert Message-ID: Date: Thu, 31 Oct 2019 13:53:00 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.1 MIME-Version: 1.0 In-Reply-To: <8170c7c9-d405-dfdc-325c-c8f1438926f8@linaro.org> On 10/31/19 12:37 PM, Adhemerval Zanella wrote: > > > On 31/10/2019 15:46, Paul Eggert wrote: >> Thanks for syncing intprops.h, timespec-add.c and timespec-sub.c with Gnulib. These changes all look good. > > Btw, do you recall any gnulib change that it would be profitable > to sync? Thanks for asking. The regex code should be brought back into sync, by merging these Gnulib changes into glibc: https://git.savannah.gnu.org/cgit/gnulib.git/commit/?id=e58796ff7110de26254fc06afdff21461462be72 https://git.savannah.gnu.org/cgit/gnulib.git/commit/?id=7ce5f5c77f679f0da1fa15f4fb7c9e103685d079 https://git.savannah.gnu.org/cgit/gnulib.git/commit/?id=32915b2a8a43825720755113bdffe9f67a591748 https://git.savannah.gnu.org/cgit/gnulib.git/commit/?id=48f07576b8cd935b48e1050551f45ab1a79b9f01 https://git.savannah.gnu.org/cgit/gnulib.git/commit/?id=5e407aba1f775d51b25481cb55f324c9868f62d7 https://git.savannah.gnu.org/cgit/gnulib.git/commit/?id=4e02b30c761c76d04057fa5f6bba71401f9310cd https://git.savannah.gnu.org/cgit/gnulib.git/commit/?id=79f8ee4e389f8cb1339f8abed9a7d29816e2a2d4 and while we're on the topic of regex, Andreas's patch for Bug#25149 should be merged in too; see: https://sourceware.org/ml/libc-alpha/2019-10/msg00907.html Also, there's a URL in a mktime.c comment that I should have synced last month; I fixed that in glibc just now by installing the attached trivial patch. There's almost surely more stuff, but the regex code ought to be top priority in this area, since I'd like Andreas's patch in time for the next GNU grep release. From ee7f39078460fb243a4d3a5cfd4140cc0ef22eaa Mon Sep 17 00:00:00 2001 From: Paul Eggert Date: Thu, 31 Oct 2019 13:15:57 -0700 Subject: [PATCH] Sync time/mktime.c with gnulib This syncs with gnulib commit 9e78024bad107fe786cc3e5e328a475921ea0873. * time/mktime.c: Update URL in comment. --- time/mktime.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/time/mktime.c b/time/mktime.c index 8fe2f963ae..11b0d5353b 100644 --- a/time/mktime.c +++ b/time/mktime.c @@ -78,7 +78,7 @@ my_tzset (void) - Time zone names based on geography, without slashes, e.g. "Singapore". - Time zone names that contain explicit DST rules. Syntax: see - + The Microsoft CRT understands only the first kind. It produces incorrect results if the value of TZ is of the other kinds. But in a Cygwin environment, /etc/profile.d/tzset.sh sets TZ to a value -- 2.23.0