[1/2] Define __libc_initial for the static libc

Message ID f03ead9525f1bfb0c1ff740196d649157390f93b.1722071588.git.fweimer@redhat.com (mailing list archive)
State Committed
Commit eb0e50e9a1cf80a2ba6f33f990a08ef37a3267fb
Delegated to: Simon Chopin
Headers
Series [1/2] Define __libc_initial for the static libc |

Checks

Context Check Description
redhat-pt-bot/TryBot-apply_patch success Patch applied to master at the time it was sent
linaro-tcwg-bot/tcwg_glibc_build--master-arm success Build passed
linaro-tcwg-bot/tcwg_glibc_build--master-aarch64 success Build passed
linaro-tcwg-bot/tcwg_glibc_check--master-aarch64 success Test passed
linaro-tcwg-bot/tcwg_glibc_check--master-arm success Test passed

Commit Message

Florian Weimer July 27, 2024, 9:13 a.m. UTC
  ---
 include/libc-internal.h | 3 +++
 1 file changed, 3 insertions(+)


base-commit: f6f904745942540c7ea99c403b75b695ee560035
  

Comments

Florian Weimer Aug. 9, 2024, 10:50 a.m. UTC | #1
* Florian Weimer:

> ---
>  include/libc-internal.h | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/include/libc-internal.h b/include/libc-internal.h
> index 87ac591835..1ef43ffe67 100644
> --- a/include/libc-internal.h
> +++ b/include/libc-internal.h
> @@ -53,6 +53,9 @@ extern __typeof (__profile_frequency) __profile_frequency attribute_hidden;
>     is not for an audit module, not loaded via dlmopen, and not loaded
>     via static dlopen either).  */
>  extern _Bool __libc_initial attribute_hidden;
> +#else
> +/* The static libc is always the initial namespace.  */
> +# define __libc_initial ((_Bool) 1)
>  #endif
>  
>  #endif /* _LIBC_INTERNAL  */
>
> base-commit: f6f904745942540c7ea99c403b75b695ee560035

Ping?  This patch is still missing review.

Thanks,
Florian
  
Adhemerval Zanella Netto Aug. 9, 2024, 12:16 p.m. UTC | #2
LGTM, thanks.

Reviewed-by: Adhemerval Zanella  <adhemerval.zanella@linaro.org>

On 27/07/24 06:13, Florian Weimer wrote:
> ---
>  include/libc-internal.h | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/include/libc-internal.h b/include/libc-internal.h
> index 87ac591835..1ef43ffe67 100644
> --- a/include/libc-internal.h
> +++ b/include/libc-internal.h
> @@ -53,6 +53,9 @@ extern __typeof (__profile_frequency) __profile_frequency attribute_hidden;
>     is not for an audit module, not loaded via dlmopen, and not loaded
>     via static dlopen either).  */
>  extern _Bool __libc_initial attribute_hidden;
> +#else
> +/* The static libc is always the initial namespace.  */
> +# define __libc_initial ((_Bool) 1)
>  #endif
>  
>  #endif /* _LIBC_INTERNAL  */
> 
> base-commit: f6f904745942540c7ea99c403b75b695ee560035
  

Patch

diff --git a/include/libc-internal.h b/include/libc-internal.h
index 87ac591835..1ef43ffe67 100644
--- a/include/libc-internal.h
+++ b/include/libc-internal.h
@@ -53,6 +53,9 @@  extern __typeof (__profile_frequency) __profile_frequency attribute_hidden;
    is not for an audit module, not loaded via dlmopen, and not loaded
    via static dlopen either).  */
 extern _Bool __libc_initial attribute_hidden;
+#else
+/* The static libc is always the initial namespace.  */
+# define __libc_initial ((_Bool) 1)
 #endif
 
 #endif /* _LIBC_INTERNAL  */