| Message ID | ee142507fe416492b087df65a77ef33e05936082.1649767418.git.szabolcs.nagy@arm.com |
|---|---|
| State | Committed |
| Headers |
Return-Path: <libc-alpha-bounces+patchwork=sourceware.org@sourceware.org>
X-Original-To: patchwork@sourceware.org
Delivered-To: patchwork@sourceware.org
Received: from server2.sourceware.org (localhost [IPv6:::1])
by sourceware.org (Postfix) with ESMTP id 3B2A4385801E
for <patchwork@sourceware.org>; Tue, 12 Apr 2022 12:56:40 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 3B2A4385801E
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org;
s=default; t=1649768200;
bh=Tv6vrk4t0pFVT+906oL+or0qsSiwfNCO8vCRfPBu948=;
h=To:Subject:Date:In-Reply-To:References:List-Id:List-Unsubscribe:
List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:
From;
b=PIV8IcZeM3i4sDTqN5hfbi75a0+Ot+m4UpN+1htQpdbqwY5tiU+z2Ia9JInqAz/fd
ESdcVayuENZ7yCiucmccM9SdkK5CDd4rbCIFy3ZAw74sWpdL+Gzl7/+Yv6UxoV6o5r
DTFjUi4y0N73T1BnwGC5Ad5AZo1Hm8tNz0CQxL5E=
X-Original-To: libc-alpha@sourceware.org
Delivered-To: libc-alpha@sourceware.org
Received: from EUR02-VE1-obe.outbound.protection.outlook.com
(mail-eopbgr20075.outbound.protection.outlook.com [40.107.2.75])
by sourceware.org (Postfix) with ESMTPS id 889753858D37
for <libc-alpha@sourceware.org>; Tue, 12 Apr 2022 12:55:34 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 889753858D37
Received: from DB6PR07CA0055.eurprd07.prod.outlook.com (2603:10a6:6:2a::17) by
VI1PR08MB4320.eurprd08.prod.outlook.com (2603:10a6:803:100::10) with
Microsoft SMTP Server (version=TLS1_2,
cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.29; Tue, 12 Apr
2022 12:55:30 +0000
Received: from DB5EUR03FT010.eop-EUR03.prod.protection.outlook.com
(2603:10a6:6:2a:cafe::3f) by DB6PR07CA0055.outlook.office365.com
(2603:10a6:6:2a::17) with Microsoft SMTP Server (version=TLS1_2,
cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.18 via Frontend
Transport; Tue, 12 Apr 2022 12:55:30 +0000
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
smtp.mailfrom=arm.com; dkim=pass (signature was verified)
header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
63.35.35.123 as permitted sender) receiver=protection.outlook.com;
client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
DB5EUR03FT010.mail.protection.outlook.com (10.152.20.96) with
Microsoft SMTP
Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
15.20.5144.21 via Frontend Transport; Tue, 12 Apr 2022 12:55:30 +0000
Received: ("Tessian outbound 9613c00560a5:v118");
Tue, 12 Apr 2022 12:55:30 +0000
X-CheckRecipientChecked: true
X-CR-MTA-CID: d7559a4d6b603fbb
X-CR-MTA-TID: 64aa7808
Received: from c0c90e66d799.1
by 64aa7808-outbound-1.mta.getcheckrecipient.com id
066BA564-8A0E-4D68-8A49-03B474A57B74.1;
Tue, 12 Apr 2022 12:55:23 +0000
Received: from EUR03-DB5-obe.outbound.protection.outlook.com
by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id
c0c90e66d799.1
(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
Tue, 12 Apr 2022 12:55:23 +0000
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
b=mzIDieRXBMV9vLCzfbbs3mn8MbEJ7nlQu09Td+BJZXy3nmQ3DJQjt/XgdKi1lsj+/LA86zVFvUYDu4xBZ9rlMMKvEGG/1goKVTzvupe3xIz80rBMDYWHpw37PQrVBGzq25v1XPr/f8GJoKLG1YKSTLS1rvQknTlPPJUnLqLRbvtft0oF4NX+5f2ZqkIyXj6n+Rhs+HlzOHGmXslORKZYU0ZSxxUtqVOtH6Kg6G0amZBOqXQueLGkUZqbcEBqQzu3NKapQGLnhrxAKDKgTlnt/ql4WaMfOmwqbdRdc23x33eARJyDQym5H+fNmFvgsLGtplP1F6iSRyA1i0l8w7P0tg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
s=arcselector9901;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
bh=Tv6vrk4t0pFVT+906oL+or0qsSiwfNCO8vCRfPBu948=;
b=lB37vXwqmRC9iKcEv0CwO859+y9XvBb3XUZS2YKq3m5sE2ZaXDkSAtDGtFU8V6cPUf4c5/U18VBVmgKQej7jj2yAzb8/LJDxRzCqXXdxoy8gP2e6cgsfvtV3pp6o1SJsPvAgB/PiPkw3CbnoRo0r+wrhLzIDc1QC9Pt51eofAw9G2C4yGMOBUwnKDiZazDGrEYzK7y4TJiz2KXrlQYE/VNFIDCCkVcnUqtkm/aAgwn/UKrK7N48fjpuZZ85FuJuOMCsQE/t/vhNIsaE/Erj0TgiWITZOBDhb6YXT/NF7oGOabN1IrHqPVkfVwEtx9qBA7xkZI/9lCjZqNOT5XTJyBg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
40.67.248.234) smtp.rcpttodomain=sourceware.org smtp.mailfrom=arm.com;
dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
dkim=none (message not signed); arc=none
Received: from AS8PR07CA0011.eurprd07.prod.outlook.com (2603:10a6:20b:451::29)
by HE1PR0802MB2571.eurprd08.prod.outlook.com (2603:10a6:3:e2::7) with
Microsoft SMTP Server (version=TLS1_2,
cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.29; Tue, 12 Apr
2022 12:55:22 +0000
Received: from AM5EUR03FT003.eop-EUR03.prod.protection.outlook.com
(2603:10a6:20b:451:cafe::9f) by AS8PR07CA0011.outlook.office365.com
(2603:10a6:20b:451::29) with Microsoft SMTP Server (version=TLS1_2,
cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.18 via Frontend
Transport; Tue, 12 Apr 2022 12:55:22 +0000
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234)
smtp.mailfrom=arm.com; dkim=none (message not signed)
header.d=none;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
40.67.248.234 as permitted sender) receiver=protection.outlook.com;
client-ip=40.67.248.234; helo=nebula.arm.com;
Received: from nebula.arm.com (40.67.248.234) by
AM5EUR03FT003.mail.protection.outlook.com (10.152.16.149) with Microsoft SMTP
Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
15.20.5144.21 via Frontend Transport; Tue, 12 Apr 2022 12:55:21 +0000
Received: from AZ-NEU-EX03.Arm.com (10.251.24.31) by AZ-NEU-EX03.Arm.com
(10.251.24.31) with Microsoft SMTP Server (version=TLS1_2,
cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Tue, 12 Apr
2022 12:55:27 +0000
Received: from armchair.cambridge.arm.com (10.2.80.71) by mail.arm.com
(10.251.24.31) with Microsoft SMTP Server id 15.1.2308.27 via Frontend
Transport; Tue, 12 Apr 2022 12:55:27 +0000
To: <libc-alpha@sourceware.org>
Subject: [PATCH 1/3] Remove _dl_skip_args_internal declaration
Date: Tue, 12 Apr 2022 13:55:19 +0100
Message-ID:
<ee142507fe416492b087df65a77ef33e05936082.1649767418.git.szabolcs.nagy@arm.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <cover.1649767418.git.szabolcs.nagy@arm.com>
References: <cover.1649767418.git.szabolcs.nagy@arm.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
X-EOPAttributedMessage: 1
X-MS-Office365-Filtering-Correlation-Id: 002bd145-c922-4eb7-f184-08da1c83b97d
X-MS-TrafficTypeDiagnostic:
HE1PR0802MB2571:EE_|DB5EUR03FT010:EE_|VI1PR08MB4320:EE_
X-Microsoft-Antispam-PRVS:
<VI1PR08MB43202DD0C542E79FC801579FEDED9@VI1PR08MB4320.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
NoDisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
7WW/B6VwiMwNpbbWigrifcfa77COsU2vSjtvtGYipKb0R+U65dOWrF+k2PxNZ6cdZyODHGnIy0sd66G5wcK6rjMe/GYW4VAVgjNF0Fks++b8Nm/efCCOrjDrHFxWHZVpcelIvPRmq4QG7fvzIc+xGWxeUXG/7PgUoWYtzRq+5RrIypsNKN0aRIFO2bQYI0Um6vN/wi4DiK+BZM4QKU+KRKmO6cbRxHj0fB1aoGlc8KgBv6pwOMpdGk68rnOsLSiCWzzVqMD1i1V2ZWq3wMEh42jE179k5n4x/naLzb4w/EIuWa2MgntudjA/ONkgA/YyVh/GrBoUYB34GJK7WfSPP1xwALz68RP26NUzfFx7OMx7UPBhDXYRwfrSEoaZxnGYSbXo85/rUXQGUvuQUaCfU63tz6WJ4J9FO7vFdFMXtZ46wXm1t5HLzaOdHCKNYt6ntYwsUlJ4IcKfVWZkECcVvNjC81QU5r0bUEuMZkoZRDRvve2SCEERwr3Afnxx1QNkL9PcXuPtjhbeSxeJkw+kdHLK1tAMd8fIbSzY6NcqjS0zl4oKdxXX2SwynhJGMmByeypLh1UtSck0kLTxoZBkMmstbvtLlAXRz6UN6zJd/1u79eOGcpbymI3u0H9PzTt7FIjELx7kof6hchstjZtMmaJxoc35SZLT7ScG725ny3o6nEAkwPQ1wCn4uRhj7ArlJuLMnqoo0tMe1lTyK7SScg==
X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234; CTRY:IE; LANG:en;
SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:nebula.arm.com; PTR:InfoDomainNonexistent;
CAT:NONE;
SFS:(13230001)(4636009)(36840700001)(46966006)(40470700004)(2616005)(6666004)(40460700003)(7696005)(426003)(86362001)(70586007)(70206006)(6916009)(47076005)(81166007)(356005)(44832011)(4744005)(316002)(8676002)(82310400005)(36860700001)(8936002)(336012)(36756003)(5660300002)(508600001)(26005)(186003)(2906002)(83380400001)(36900700001);
DIR:OUT; SFP:1101;
X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0802MB2571
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
DB5EUR03FT010.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
ce3d5068-3b70-4d64-cf11-08da1c83b463
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
MnbJ60RTshNqhHWkLZA7wu8xaxs0Hz0D27dM45hXxQHG0F6Y8gawChQm4rGCh/JWSonj/ErU5+AQ48lPkhi9BV+EtDz7zqAi8S3cWibI+PpEUt6jbRAiUh0qRC0BaAxGyLdgXF877h3nCKxaT754v4MH7u/9RfCt3v88XFmCF3+UFDJkapQUzMHAeu5qEkb2WOd9CE9lef0zlXMpGth6n939fawtAbgLNe+9BuXu1SVJ6LaJLqK0/uVBJGmF1RTZpRtpZXsbpGGG8BEbJflD/q+KE9VmP/SUoto/q8an3Bsbta3pd52wASOlgU51N/nkdbyDiTDVu0w9rXb4HMjnqJ231S5SJ/lK3A1cTDflrNgws3EkrK5VzcHh83PTNL6pGvAJN741ykx1sOKhc+PWVETi/uVXY3sUepz/viWj04gahAEHq2PjlvgNF+GEQ6OUdRGxTvvJnIPsHVE7pcwz0+M3cffiCBix6Fra+ekc4ZzwCsvuFtiMWumWItxjuisUm3QWiyURIEQ6EuQeQJK2VM4tg8eLT/g4bVHgsT4hrExnx7nGaUoMaonB7e+Iq0ryStlugqUcB90b9OpYtsWqdAu6nZbMfspoivwub7lnAdWJ7MtShiJB/vnuPOTaJB+jd7AJY3tXDEHBGmjdU5XELilzBd7UY9SA930e9uwevB1gAo3wfEonTL390GnbsEg7
X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:;
IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com;
PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE;
SFS:(13230001)(4636009)(46966006)(36840700001)(40470700004)(86362001)(82310400005)(36860700001)(2906002)(508600001)(426003)(2616005)(47076005)(336012)(26005)(186003)(6666004)(83380400001)(70206006)(70586007)(7696005)(36756003)(8936002)(40460700003)(4744005)(316002)(5660300002)(44832011)(6916009)(81166007)(8676002);
DIR:OUT; SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Apr 2022 12:55:30.4678 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id:
002bd145-c922-4eb7-f184-08da1c83b97d
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp:
TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123];
Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
DB5EUR03FT010.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB4320
X-Spam-Status: No, score=-12.9 required=5.0 tests=BAYES_00, DKIM_SIGNED,
DKIM_VALID, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,
SPF_HELO_PASS,
SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE,
UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.4
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on
server2.sourceware.org
X-BeenThere: libc-alpha@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Libc-alpha mailing list <libc-alpha.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/libc-alpha>,
<mailto:libc-alpha-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/libc-alpha/>
List-Post: <mailto:libc-alpha@sourceware.org>
List-Help: <mailto:libc-alpha-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/libc-alpha>,
<mailto:libc-alpha-request@sourceware.org?subject=subscribe>
From: Szabolcs Nagy via Libc-alpha <libc-alpha@sourceware.org>
Reply-To: Szabolcs Nagy <szabolcs.nagy@arm.com>
Errors-To: libc-alpha-bounces+patchwork=sourceware.org@sourceware.org
Sender: "Libc-alpha"
<libc-alpha-bounces+patchwork=sourceware.org@sourceware.org>
|
| Series |
Args adjustment with ./ld.so exe [BZ #23293]
|
|
Checks
| Context | Check | Description |
|---|---|---|
| dj/TryBot-apply_patch | success | Patch applied to master at the time it was sent |
Commit Message
Szabolcs Nagy
April 12, 2022, 12:55 p.m. UTC
It does not seem to be used. --- sysdeps/generic/ldsodefs.h | 5 ----- 1 file changed, 5 deletions(-)
Comments
* Szabolcs Nagy via Libc-alpha: > It does not seem to be used. > --- > sysdeps/generic/ldsodefs.h | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/sysdeps/generic/ldsodefs.h b/sysdeps/generic/ldsodefs.h > index 44750461a9..29f005499b 100644 > --- a/sysdeps/generic/ldsodefs.h > +++ b/sysdeps/generic/ldsodefs.h > @@ -781,11 +781,6 @@ extern char **_dl_argv > rtld_hidden_proto (_dl_argv) > #if IS_IN (rtld) > extern unsigned int _dl_skip_args attribute_hidden > -# ifndef DL_ARGV_NOT_RELRO > - attribute_relro > -# endif > - ; > -extern unsigned int _dl_skip_args_internal attribute_hidden > # ifndef DL_ARGV_NOT_RELRO > attribute_relro > # endif Looks okay. Reviewed-by: Florian Weimer <fweimer@redhat.com> Thanks, Florian
On Apr 12 2022, Szabolcs Nagy via Libc-alpha wrote:
> It does not seem to be used.
Ok. Looks like it has never been defined even when it was added.
diff --git a/sysdeps/generic/ldsodefs.h b/sysdeps/generic/ldsodefs.h index 44750461a9..29f005499b 100644 --- a/sysdeps/generic/ldsodefs.h +++ b/sysdeps/generic/ldsodefs.h @@ -781,11 +781,6 @@ extern char **_dl_argv rtld_hidden_proto (_dl_argv) #if IS_IN (rtld) extern unsigned int _dl_skip_args attribute_hidden -# ifndef DL_ARGV_NOT_RELRO - attribute_relro -# endif - ; -extern unsigned int _dl_skip_args_internal attribute_hidden # ifndef DL_ARGV_NOT_RELRO attribute_relro # endif