From patchwork Mon Nov 14 19:28:49 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Zack Weinberg X-Patchwork-Id: 17477 Received: (qmail 26123 invoked by alias); 14 Nov 2016 19:28:54 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 25160 invoked by uid 89); 14 Nov 2016 19:28:53 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL, BAYES_00, FREEMAIL_FROM, RCVD_IN_DNSWL_LOW, SPF_PASS autolearn=ham version=3.3.2 spammy=H*MI:panix, 2336, 233, 6, incremental X-HELO: mail-qt0-f195.google.com X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:to:from:subject:message-id:date:user-agent :mime-version:content-transfer-encoding; bh=umdhpBfFREDphUAa6W6KIfgMstcrE/d9oz9Q9jo5hFc=; b=Q66PH6QPx5JsmDKFGGfHEuJ0LxU1NRdD36zDpmEf34E/e/uTWivbL3OuHqrmROcZ9v xTIqrhdSWWLzj5hOAnfFecHfNOo4g/GO+6jKr0PG5SF+AlPegPh4ID8MvUVSD0LcvO2r kOHV1LY7X+XXSTR2N+Bjc/wKILuAoBRDQvaoTB9Mv+olQ6NL7gDAWeYvGYDCwjU4sCHa H4rmCTPGIYGAGZG/qgwfTcsCF0bWE1/iTkcSPsxr0GexE9icOKxwYl/gveGEzWB5LvqX YtXCBF7IhPOvpPvfhjHUk+L0/Rs+PH/5ATJZFiO/Q6w1ejK6kILx4OLiPke4d+W/qBew 16Wg== X-Gm-Message-State: ABUngvcgxrfEfLc6k2AAImxHS1hfNgvIqESLv2Ktn7s1CIctXxfOf5khdOuhamd2KgMwXQ== X-Received: by 10.200.58.65 with SMTP id w59mr11590534qte.54.1479151730592; Mon, 14 Nov 2016 11:28:50 -0800 (PST) To: GNU C Library From: Zack Weinberg Subject: [patch committed] Fix build-and-build-again bug in sunrpc tests. Message-ID: Date: Mon, 14 Nov 2016 14:28:49 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Icedove/45.4.0 MIME-Version: 1.0 rpcgen will error out if the file it's asked to create already exists. Several other rules in sunrpc/Makefile take care to delete rpcgen- generated files before creating them, but rpcgen-tests doesn't, which can lead to spurious test failures in an incremental rebuild. Tested on x86_64-linux-gnu, committed as obvious. zw * sunrpc/Makefile (rpcgen-tests): Delete the .out file before creating or re-creating it. endif diff --git a/sunrpc/Makefile b/sunrpc/Makefile index 99e5c3c..9e805fb 100644 --- a/sunrpc/Makefile +++ b/sunrpc/Makefile @@ -233,6 +233,7 @@ $(objpfx)thrsvc: $(common-objpfx)linkobj/libc.so $(shared-thread-library) ifeq ($(run-built-tests),yes) $(rpcgen-tests): $(objpfx)%.out: %.x $(objpfx)rpcgen + -rm -f $@ $(built-program-cmd) -c $< -o $@; \ $(evaluate-test)