diff mbox

[committed] Fix build-and-build-again bug in sunrpc tests.

Message ID e60397c1-0813-2aac-ff9d-c28aeb8314b1@panix.com
State Committed
Headers

Commit Message

Zack Weinberg Nov. 14, 2016, 7:28 p.m. UTC 
  rpcgen will error out if the file it's asked to create already exists.
Several other rules in sunrpc/Makefile take care to delete rpcgen-
generated files before creating them, but rpcgen-tests doesn't, which
can lead to spurious test failures in an incremental rebuild.

Tested on x86_64-linux-gnu, committed as obvious.

zw

	* sunrpc/Makefile (rpcgen-tests): Delete the .out file before
	creating or re-creating it.

 endif
diff mbox

Patch

diff --git a/sunrpc/Makefile b/sunrpc/Makefile
index 99e5c3c..9e805fb 100644
--- a/sunrpc/Makefile
+++ b/sunrpc/Makefile
@@ -233,6 +233,7 @@  $(objpfx)thrsvc: $(common-objpfx)linkobj/libc.so
$(shared-thread-library)

 ifeq ($(run-built-tests),yes)
 $(rpcgen-tests): $(objpfx)%.out: %.x $(objpfx)rpcgen
+       -rm -f $@
        $(built-program-cmd) -c $< -o $@; \
        $(evaluate-test)