diff mbox series

[02/16] Remove PR_TAGGED_ADDR_ENABLE from sys/prctl.h

Message ID e204f44a0d5882e37910833f882c01586f728ba2.1614874816.git.szabolcs.nagy@arm.com
State Committed
Commit f4596d9540021265a99697fceef8a434c47e8bcf
Headers show
Series memory tagging improvements | expand

Commit Message

Szabolcs Nagy March 4, 2021, 4:30 p.m. UTC
The value of PR_TAGGED_ADDR_ENABLE was incorrect in the installed
headers and the prctl command macros were missing that are needed
for it to be useful (PR_SET_TAGGED_ADDR_CTRL).  Linux headers have
the definitions since 5.4 so it's widely available, we don't need
to repeat these definitions.  The remaining definitions are from
Linux 5.10.

To build glibc with --enable-memory-tagging, Linux 5.4 headers and
binutils 2.33.1 or newer is needed.
---
 sysdeps/unix/sysv/linux/sys/prctl.h | 4 ----
 1 file changed, 4 deletions(-)

Comments

Szabolcs Nagy March 26, 2021, 11:29 a.m. UTC | #1
The 03/04/2021 16:30, Szabolcs Nagy via Libc-alpha wrote:
> The value of PR_TAGGED_ADDR_ENABLE was incorrect in the installed
> headers and the prctl command macros were missing that are needed
> for it to be useful (PR_SET_TAGGED_ADDR_CTRL).  Linux headers have
> the definitions since 5.4 so it's widely available, we don't need
> to repeat these definitions.  The remaining definitions are from
> Linux 5.10.
> 
> To build glibc with --enable-memory-tagging, Linux 5.4 headers and
> binutils 2.33.1 or newer is needed.

ping.

i now committed all the other memtag patches (thanks
DJ for the reviews) only this one needs a review
(i would like to back port it too).


> ---
>  sysdeps/unix/sysv/linux/sys/prctl.h | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/sysdeps/unix/sysv/linux/sys/prctl.h b/sysdeps/unix/sysv/linux/sys/prctl.h
> index 00817ff0f1..c9048c7cdb 100644
> --- a/sysdeps/unix/sysv/linux/sys/prctl.h
> +++ b/sysdeps/unix/sysv/linux/sys/prctl.h
> @@ -25,10 +25,6 @@
>     we're picking up...  */
>  
>  /* Memory tagging control operations (for AArch64).  */
> -#ifndef PR_TAGGED_ADDR_ENABLE
> -# define PR_TAGGED_ADDR_ENABLE	(1UL << 8)
> -#endif
> -
>  #ifndef PR_MTE_TCF_SHIFT
>  # define PR_MTE_TCF_SHIFT	1
>  # define PR_MTE_TCF_NONE	(0UL << PR_MTE_TCF_SHIFT)
> -- 
> 2.17.1
> 

--
Szabolcs Nagy April 13, 2021, 8:37 a.m. UTC | #2
The 03/26/2021 11:29, Szabolcs Nagy via Libc-alpha wrote:
> The 03/04/2021 16:30, Szabolcs Nagy via Libc-alpha wrote:
> > The value of PR_TAGGED_ADDR_ENABLE was incorrect in the installed
> > headers and the prctl command macros were missing that are needed
> > for it to be useful (PR_SET_TAGGED_ADDR_CTRL).  Linux headers have
> > the definitions since 5.4 so it's widely available, we don't need
> > to repeat these definitions.  The remaining definitions are from
> > Linux 5.10.
> > 
> > To build glibc with --enable-memory-tagging, Linux 5.4 headers and
> > binutils 2.33.1 or newer is needed.
> 
> ping.
> 
> i now committed all the other memtag patches (thanks
> DJ for the reviews) only this one needs a review
> (i would like to back port it too).


ping.

DJ: can you please do the review of this header change?
(others seems to be less interested looking at it)

> > ---
> >  sysdeps/unix/sysv/linux/sys/prctl.h | 4 ----
> >  1 file changed, 4 deletions(-)
> > 
> > diff --git a/sysdeps/unix/sysv/linux/sys/prctl.h b/sysdeps/unix/sysv/linux/sys/prctl.h
> > index 00817ff0f1..c9048c7cdb 100644
> > --- a/sysdeps/unix/sysv/linux/sys/prctl.h
> > +++ b/sysdeps/unix/sysv/linux/sys/prctl.h
> > @@ -25,10 +25,6 @@
> >     we're picking up...  */
> >  
> >  /* Memory tagging control operations (for AArch64).  */
> > -#ifndef PR_TAGGED_ADDR_ENABLE
> > -# define PR_TAGGED_ADDR_ENABLE	(1UL << 8)
> > -#endif
> > -
> >  #ifndef PR_MTE_TCF_SHIFT
> >  # define PR_MTE_TCF_SHIFT	1
> >  # define PR_MTE_TCF_NONE	(0UL << PR_MTE_TCF_SHIFT)
> > -- 
> > 2.17.1
> >
diff mbox series

Patch

diff --git a/sysdeps/unix/sysv/linux/sys/prctl.h b/sysdeps/unix/sysv/linux/sys/prctl.h
index 00817ff0f1..c9048c7cdb 100644
--- a/sysdeps/unix/sysv/linux/sys/prctl.h
+++ b/sysdeps/unix/sysv/linux/sys/prctl.h
@@ -25,10 +25,6 @@ 
    we're picking up...  */
 
 /* Memory tagging control operations (for AArch64).  */
-#ifndef PR_TAGGED_ADDR_ENABLE
-# define PR_TAGGED_ADDR_ENABLE	(1UL << 8)
-#endif
-
 #ifndef PR_MTE_TCF_SHIFT
 # define PR_MTE_TCF_SHIFT	1
 # define PR_MTE_TCF_NONE	(0UL << PR_MTE_TCF_SHIFT)