From patchwork Wed Jul 5 18:15:43 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Carlos O'Donell X-Patchwork-Id: 21442 Received: (qmail 32671 invoked by alias); 5 Jul 2017 18:16:02 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 27035 invoked by uid 89); 5 Jul 2017 18:15:54 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-23.0 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, KAM_LAZY_DOMAIN_SECURITY, RCVD_IN_DNSWL_NONE, RCVD_IN_SORBS_SPAM autolearn=ham version=3.3.2 spammy= X-HELO: mail-qk0-f177.google.com X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=ZBKiMM7EEp/DpdD0ANXhkTl4r/S289jh7UXNq7SEB/M=; b=MEPKS5UpG9NLYxAKe261rWLP3xUrXhvd1ZnMdqi54n5xCpFw0nIqF5ZMq9zquUhbf1 XGlI1MtEZab8Gr0uIjgTGMl9aT09C0N/QZX8ZNq1oDJTAABk0fG8/+MoKzIy2Q2bBLxJ CikcyPYzbX3Y+nyU/UJr0desEClYhn6NJCmbBg+Bcw2dc651V8Y4SkildpGLOXdDR1A8 4lc2+0rxTR7814FW6fpeyPyoT7Kr5UFFm/3iuaXDhVe39uQOvgU0hGaiyiFg0bA3jjJ1 BAcsq81p2/VmH04RnM2HgsPeiUK2mBzTwgmT2R8Ym5Tnn8kVWyLSJ9xJ+zxL+kKUH7hb EjDg== X-Gm-Message-State: AIVw112SfdoSQ5dPyZGkMhiS2wbFHrRb3H4ZNrpE50Wjgqp12pLe555d nta+qZEybDSW3Ebg X-Received: by 10.55.86.5 with SMTP id k5mr24448265qkb.70.1499278551213; Wed, 05 Jul 2017 11:15:51 -0700 (PDT) Subject: Re: [PATCH 1/1] Added Tok-Pisin locale. To: Mike FABIAN , Akhilesh Kumar Cc: libc-alpha@sourceware.org, pankaj.m@samsung.com, hakbong5.lee@samsung.com, maninder1.s@samsung.com References: <1499255563-30123-1-git-send-email-akhilesh.k@samsung.com> From: Carlos O'Donell Message-ID: Date: Wed, 5 Jul 2017 14:15:43 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.0 MIME-Version: 1.0 In-Reply-To: On 07/05/2017 12:39 PM, Mike FABIAN wrote: > Akhilesh Kumar wrote: > >> +category "i18n:2017";LC_IDENTIFICATION >> +category "i18n:2017";LC_CTYPE >> +category "i18n:2017";LC_COLLATE >> +category "i18n:2017";LC_TIME >> +category "i18n:2017";LC_NUMERIC >> +category "i18n:2017";LC_MONETARY >> +category "i18n:2017";LC_PAPER >> +category "i18n:2017";LC_MEASUREMENT >> +category "i18n:2017";LC_MESSAGES >> +category "i18n:2017";LC_NAME >> +category "i18n:2017";LC_ADDRESS >> +category "i18n:2017";LC_TELEPHONE >> +END LC_IDENTIFICATION > > This causes an error when building the locale: > > tpi_PG.UTF-8...LC_IDENTIFICATION: unknown standard `i18n:2017' for category `LC_CTYPE' > LC_IDENTIFICATION: unknown standard `i18n:2017' for category `LC_NUMERIC' > LC_IDENTIFICATION: unknown standard `i18n:2017' for category `LC_TIME' > LC_IDENTIFICATION: unknown standard `i18n:2017' for category `LC_COLLATE' > LC_IDENTIFICATION: unknown standard `i18n:2017' for category `LC_MONETARY' > LC_IDENTIFICATION: unknown standard `i18n:2017' for category `LC_MESSAGES' > LC_IDENTIFICATION: unknown standard `i18n:2017' for category `LC_PAPER' > LC_IDENTIFICATION: unknown standard `i18n:2017' for category `LC_NAME' > LC_IDENTIFICATION: unknown standard `i18n:2017' for category `LC_ADDRESS' > LC_IDENTIFICATION: unknown standard `i18n:2017' for category `LC_TELEPHONE' > LC_IDENTIFICATION: unknown standard `i18n:2017' for category `LC_MEASUREMENT' > LC_IDENTIFICATION: unknown standard `i18n:2017' for category `LC_IDENTIFICATION' > > > All the other locales have `i18n:2012'. > > I’ll change it to `i18n:2012' before committing your patch. I cleaned up the ChangeLog for this. Please keep an eye on GNU ChangeLog convention. It should be present tense, and explain which files are being changed and how. You can add a leading paragraph that explains the change too. Carlos. diff --git a/localedata/ChangeLog b/localedata/ChangeLog index d291642..fab25f0 100644 --- a/localedata/ChangeLog +++ b/localedata/ChangeLog @@ -1,7 +1,10 @@ 2017-07-05 Akhilesh Kumar + Added tok-pisin language locale for Papua New Guinea. + [BZ #21694] - * Added tok-pisin language locale for Papua New Guinea. + * locales/tpi_PG: New file. + * SUPPORTED: Add tpi_PG/UTF-8. --- -- Cheers,