mbox

[v5,0/4] Args adjustment with ./ld.so exe [BZ #23293]

Message ID cover.1651732417.git.szabolcs.nagy@arm.com
Headers show

Message

Szabolcs Nagy May 5, 2022, 6:58 a.m. UTC
The Hurd ld.so start code had to be adjusted. This revealed that
the fix actually cuts across abstraction layers: fiddles with
ELF entry stack layout in generic code, skipping the intermediate
OS sysdep layer. I don't see a clean solution without more code
changes.

I run cross tests for i686-gnu, but not execution tests, so the
changes in sysdeps/mach/hurd/dl-sysdep.c require a review.

The patches are in the nsz/bug23293-v5 branch.

Szabolcs Nagy (4):
  rtld: Use generic argv adjustment in ld.so [BZ #23293]
  rtld: Remove DL_ARGV_NOT_RELRO
  linux: Add a getauxval test [BZ #23293]
  aarch64: Move ld.so _start to separate file and drop _dl_skip_args

 elf/rtld.c                               | 90 ++++++++++++++++++------
 sysdeps/aarch64/Makefile                 |  1 +
 sysdeps/aarch64/dl-machine.h             | 77 +-------------------
 sysdeps/aarch64/dl-start.S               | 53 ++++++++++++++
 sysdeps/aarch64/dl-sysdep.h              |  4 --
 sysdeps/alpha/dl-sysdep.h                | 23 ------
 sysdeps/arc/dl-sysdep.h                  |  4 --
 sysdeps/arm/dl-sysdep.h                  |  4 --
 sysdeps/csky/dl-sysdep.h                 | 23 ------
 sysdeps/generic/ldsodefs.h               | 15 ++--
 sysdeps/ia64/dl-sysdep.h                 | 23 ------
 sysdeps/mach/hurd/dl-sysdep.c            | 36 +++++-----
 sysdeps/nios2/dl-sysdep.h                |  4 --
 sysdeps/s390/s390-32/dl-sysdep.h         | 23 ------
 sysdeps/sparc/dl-sysdep.h                | 23 ------
 sysdeps/unix/sysv/linux/Makefile         |  1 +
 sysdeps/unix/sysv/linux/dl-sysdep.c      |  5 +-
 sysdeps/unix/sysv/linux/ia64/dl-sysdep.h |  4 --
 sysdeps/unix/sysv/linux/tst-getauxval.c  | 74 +++++++++++++++++++
 19 files changed, 223 insertions(+), 264 deletions(-)
 create mode 100644 sysdeps/aarch64/dl-start.S
 delete mode 100644 sysdeps/alpha/dl-sysdep.h
 delete mode 100644 sysdeps/csky/dl-sysdep.h
 delete mode 100644 sysdeps/ia64/dl-sysdep.h
 delete mode 100644 sysdeps/s390/s390-32/dl-sysdep.h
 delete mode 100644 sysdeps/sparc/dl-sysdep.h
 create mode 100644 sysdeps/unix/sysv/linux/tst-getauxval.c