From patchwork Thu Mar 4 16:31:18 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Szabolcs Nagy X-Patchwork-Id: 42246 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id DD4C63AA8C77; Thu, 4 Mar 2021 16:31:44 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org DD4C63AA8C77 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1614875504; bh=2zT6w33GQ+cnkbvGRG0lElvd2ZX/kHtO0DmvCS6Z+eg=; h=To:Subject:Date:In-Reply-To:References:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=oGBzfq2rVeVDTt5AvN7y64OwTH4bYFXQGmqcYdbgyZZJe810Ahcw8s9Mad5Umpbso PGlEHbelc0d//HLmazQ9wHa47JCZ1sN6uvzG/0PsFMeGg4q0C3Xzt1OEM1hiC7kLvQ HXIrgIEut1T9lwAufoM17Lr56iK7aJlNwa0mZ2q4= X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from EUR03-DB5-obe.outbound.protection.outlook.com (mail-eopbgr40045.outbound.protection.outlook.com [40.107.4.45]) by sourceware.org (Postfix) with ESMTPS id 261A8388CC0F for ; Thu, 4 Mar 2021 16:31:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 261A8388CC0F Received: from AM6PR10CA0011.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:209:89::24) by VI1PR08MB4349.eurprd08.prod.outlook.com (2603:10a6:803:101::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3890.20; Thu, 4 Mar 2021 16:31:39 +0000 Received: from AM5EUR03FT060.eop-EUR03.prod.protection.outlook.com (2603:10a6:209:89:cafe::9c) by AM6PR10CA0011.outlook.office365.com (2603:10a6:209:89::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3912.17 via Frontend Transport; Thu, 4 Mar 2021 16:31:39 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; sourceware.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;sourceware.org; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT060.mail.protection.outlook.com (10.152.16.160) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3912.17 via Frontend Transport; Thu, 4 Mar 2021 16:31:39 +0000 Received: ("Tessian outbound e9089734ffc7:v71"); Thu, 04 Mar 2021 16:31:39 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 95dfe3fa551581a2 X-CR-MTA-TID: 64aa7808 Received: from 45342c252d52.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id CBF191C9-525A-474D-AC71-8B60F9C93B72.1; Thu, 04 Mar 2021 16:31:26 +0000 Received: from EUR02-AM5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 45342c252d52.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 04 Mar 2021 16:31:26 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RKY6KnHxgkqJPNKfURoSE7m22o9CFIT95SurllQSF0wWO0PiyX4xhAqa7lxX+Y42U6JDLdcRsD1nKkhICc3NlLkrY7JgqbWEnml5A+YaiMO/KUSAGjn5zMCLZoOs8GUlC+R3eJUnZjtrMXrNhFrQhXmDqScbZs/C0AJs1RF9PbVF8Nr1dnjkGrny7GlgCFsbiXRBmxVp2sK9UsZfnTozjlcFNil2AkJ3M9Oj7PaXkHO3/0dLAtxjHvavp+JPSMYz5E3nUPxawrYL4HrD/j8ho8G2Dy5YcQ7P5ODipp7/6IOEBSh+UmUU1pKOGbwkPR3pfBDFqdG3z6dsi/UoG4t1Ng== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2zT6w33GQ+cnkbvGRG0lElvd2ZX/kHtO0DmvCS6Z+eg=; b=cJ/m33OyTCW3US4Jza5FZ9XbGfwA4BXzlbLaV/A0tjLa+oj9ODr+Axn+zAY9MJyYlXwKYPiiHSfuSo9miQPp27zjTtBmiUEavLlisNft8jwbJecCEgM7RYPMT+yqEUhsrlBNxPQoV4Y30yWJFYov2PtWieMzdmYyCNa4i3HKhySyjwDnJLIzSvOur+3Cfmm63BIiPHMwD0+gnTr0P9zuIU1O3DSfBJz8VMql0m8xkbJlc1RYtjIcGF4pUz/xJej1G33uy3d/exmG9YGfLYuFJRzLSTTTepoV/PpTk2zYMP95FaiMKipKW0dsTZHEg6MJQxr2WWd1SfAApr5RRro8Kg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none Authentication-Results-Original: sourceware.org; dkim=none (message not signed) header.d=none;sourceware.org; dmarc=none action=none header.from=arm.com; Received: from PA4PR08MB6320.eurprd08.prod.outlook.com (2603:10a6:102:e5::9) by PA4PR08MB6205.eurprd08.prod.outlook.com (2603:10a6:102:e6::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3912.17; Thu, 4 Mar 2021 16:31:25 +0000 Received: from PA4PR08MB6320.eurprd08.prod.outlook.com ([fe80::60f0:3773:69b8:e336]) by PA4PR08MB6320.eurprd08.prod.outlook.com ([fe80::60f0:3773:69b8:e336%2]) with mapi id 15.20.3912.021; Thu, 4 Mar 2021 16:31:25 +0000 To: libc-alpha@sourceware.org, Richard.Earnshaw@arm.com, DJ Delorie Subject: [PATCH 04/16] malloc: Simplify __mtag_tag_new_usable Date: Thu, 4 Mar 2021 16:31:18 +0000 Message-Id: X-Mailer: git-send-email 2.17.1 In-Reply-To: References: X-Originating-IP: [217.140.106.55] X-ClientProxiedBy: LNXP265CA0007.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:5e::19) To PA4PR08MB6320.eurprd08.prod.outlook.com (2603:10a6:102:e5::9) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from localhost.localdomain (217.140.106.55) by LNXP265CA0007.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:5e::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3890.26 via Frontend Transport; Thu, 4 Mar 2021 16:31:25 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 4d2fb433-1d5a-47b3-5929-08d8df2afccd X-MS-TrafficTypeDiagnostic: PA4PR08MB6205:|VI1PR08MB4349: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:8273;OLM:8273; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: H5CPaesBsCwSWdhlcjFaxs34wEGKudMX8pqjncmG+TYmOR4ySvpyXCaZMfAkxjW/Is1hRjCTi+1deutbtEv0rTWIkfKI/vuHMZsBQypCzdRhRrq1/6F4l2ZODLhTRGbfMx+k8ycz/4UaElGWOCq0EkMorDsSZDmVjYDXL7djCyT9mrOFMTObKVI4XBAFeHEdW0FuFV68WdTlPrcz80ThJ0/J0G0VnpkUZ/DRDR/igrchPOG7zruqPBJ8apFZI9uiQDbLZT+cZqE5HnXQJtBkSwKmqhmlvzYv0hvPCeC5D6ZineQw0YtHAI2Wi71VPiHfFS72Baxy2GyIjTvpSZCbt/D/rmXvAjFWdfVWy6SQoMKqwhuS5FW7dpQnMx40VObLl0V947qQ+Y2ydb//CyoQgbYVSiHV3vB0tgIgmUHowAO9c5WTA16KgVGtXFuPe9xw78b3V8dhBkxYd9wDK5dzcEpvPR4LWCyB5nwzacURJyCYLMDbaXi7MmKWEq2XTPnoduKtg07iH84GeXWew4shTcdMBnGgktb2p+Wy1QAaBTqkcn/vHvvCVvKwWRTZIicRhk0hoA39C3nk6/jtc1VlDw== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PA4PR08MB6320.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(136003)(376002)(346002)(396003)(366004)(39850400004)(6916009)(86362001)(956004)(52116002)(2616005)(44832011)(6512007)(316002)(69590400012)(26005)(66556008)(66476007)(186003)(66946007)(6506007)(16526019)(478600001)(6486002)(2906002)(6666004)(8936002)(36756003)(83380400001)(5660300002)(8676002)(4744005); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: prUPKvIGBbZ87R8CQSVUsiC4UuR0FduUtnvh7yV16xdB3GnjYu25K+4JhwZDifO7AqTXebEPhYoby/13jYbZ/UYS1z+P8eRLSKN2fWzk5yNpTCP7ch/02pq/BsNCltdSv7k3QEWjLagppvTnR6TI1v9uoEgMrZjqBnC46QjTmDncuQ52JJ9u273EGEL9fukggd7W5xSQd76jP4p+hNWHmTGq2xK5Bz3tR8lh6ssQG1usj3nSQ6LL/zWofF5T7HJD2+jGVd2CzzyV7u3y+U7U2P4b+UKtsdJ0/TdEojp62UyYfEdGllowiw20R5DjTTMphwS9XBGueCP+t5sSs48b3TRgEpQK864efYBa+iP40p9tNTTXdVs8El5SyC86rAcUKo0U2mNqQXQM8pnrMZLMCSy8MH3bOSOgKhZnd4LHu5IwQGg2FhAiegjLwkFkmZTVkqVNk1SlKZYU7hqOoP8kY/xg4n9eOmt6pGbQkDTqGmNV7OZAlIIyTE2duzC6VbBkv9KZKkG4Y9Qa/slHlurJjNLcAnfBXs4qx5W4YNTisn/jEmKPZKKP6gtuOhzaqKL4ph4uvUUSH+M9hlqL2lrlrpARlrZ+FVet/SIHFqTie70liLIMInP+iPD7dUdj3oQaySGPOMugudVRJQp7/4GlGkvxgNviUI5G7R7LUyKE9SKMNAJkyY19szwhMmZtbXHY2AIi+6XmVFdoMy0Wo7Ih2CRpPcJ/vl1MtpQ/mYPtP4SBCuXchDO5KB9/NhgX8Y41f9S8Oig18wlFIRkQGQ8NWvLb6BuOSy2T/OCNpA01VUol2GAIBmHOXl3gj5+Vr1qd5G3JcZMUcqyp6qt/vN8m8uxAonrMbalo56xuJ0ycUW/cPe3FRqcJpPMMbwhmDOjSwGlcOhHyp4cv68DFWmyj5VOJ/Adx0wW5WwITB4a/uthdqm3gXBa1HCo6nx+2tZ+8a1WjYYoEB/LfXlzrkcH1k5ShPDtOYNgWPo5cuI8dtJEH3aO5b0pzKLqnHbpEUVWHmCLDt0RizKZj6BTe6iS386A+REgSqYSn9BXjr8l8ZFIZShY6P8iGJZVtjs99wEsvPqU5Wx0kGapKsqyI39nmYsma74KAryb2/ugwkxHuf4L3LcJooi2/sKiz7YdjiblkfqwF/X/YAs52LthUzrjzezVbM4UauXtSXLxsvEnmZbylDPywh2crY+7NOjWi1f2YPKqQxYzFuoW6pwH7d3Z0wHL2aB2eSZYKMth5nCPHAJnAVxjG0ytTfwGTVSLEx35knXGzBEq3mKPJPUHxcSV+JxTXOXDta4DzyC5/0z8W8opcbQlECZvYvK4K2aVhCo6E X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR08MB6205 Original-Authentication-Results: sourceware.org; dkim=none (message not signed) header.d=none; sourceware.org; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT060.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: a1fb1530-894b-4719-c3fc-08d8df2af43b X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 7IHLXhiIRdPE/qCPwqwnBquu/gw9TkywDeBw9iLWvOX+4Po/ChSrtpq4abVCXvmAT39wzeauRKB7QId0O8PvN6ld7O504eX79/JxdHY2q1uh4Z6Jqr3UE6+Qc2HVzKsljsVjFCTMLVuzsyqO7b/3wWSNxU6Uhs6Dffj+mIMzWwaC63NvT0fxSHmlb/uf7GUu+Y3HhBclu5ZChaWxmLPg0/ZGaQIzVqjEPkxmTbTnqnIjsSH+Mv3c81csiuPrbjoWeuiiaPRpAYBRHr0Xq9hQ9NSEQSG01MjERYprjtnAfU1z2dqt99J2WbH3cXYyDBb10dXdADXsp2GlvE51jp9C0nNGLEZkHhfoYte64PHMfIgFpM3IVFOwnVJMwCz947MhKFBxcGOcgzI9kLYhNPrSnNaNhOBg4qiDd0fYalO2ckTzDNawE2W9OADZZOOXTMEMtyfpf0RqyjhvYLbyWt6U6Eqwpf8cL89jqEOW6R50DZnsw+3U1tsAzsHb+GcrJ8EUNnMmTIDUFw3Wiy1urGJ2PdSEAW/zmprSuAe7hUcC5bY0jW34vEge6ZZJRqlP0IFD0t6j32uij9luiI1bYr/ZMcyx0alw5Sa60WJvgTy5MTxyePD3AsB2twiWeN8lYEbGGhnIusT1yOhPbHjp4SlaPjWwMMhUcf8LvAAnDTAHM9xKLEMjdvulYGbH/+v0a8kl X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(4636009)(136003)(346002)(396003)(39850400004)(376002)(46966006)(36840700001)(8676002)(36860700001)(6512007)(69590400012)(83380400001)(82740400003)(6486002)(82310400003)(36756003)(44832011)(2616005)(8936002)(956004)(478600001)(6862004)(2906002)(47076005)(186003)(316002)(6666004)(26005)(6506007)(336012)(356005)(86362001)(16526019)(81166007)(4744005)(70206006)(70586007)(5660300002); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Mar 2021 16:31:39.5282 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 4d2fb433-1d5a-47b3-5929-08d8df2afccd X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT060.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB4349 X-Spam-Status: No, score=-13.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, GIT_PATCH_0, MSGID_FROM_MTA_HEADER, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP, UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Szabolcs Nagy via Libc-alpha From: Szabolcs Nagy Reply-To: Szabolcs Nagy Errors-To: libc-alpha-bounces@sourceware.org Sender: "Libc-alpha" The chunk cannot be a dumped one here. The only non-obvious cases are free and realloc which may be called on a dumped area chunk, but in both cases it can be verified that tagging is already avoided for dumped area chunks. --- malloc/arena.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/malloc/arena.c b/malloc/arena.c index bf17be27d4..0777dc70c6 100644 --- a/malloc/arena.c +++ b/malloc/arena.c @@ -298,11 +298,6 @@ __mtag_tag_new_usable (void *ptr) if (ptr) { mchunkptr cp = mem2chunk(ptr); - /* This likely will never happen, but we can't handle retagging - chunks from the dumped main arena. So just return the - existing pointer. */ - if (DUMPED_MAIN_ARENA_CHUNK (cp)) - return ptr; ptr = __libc_mtag_tag_region (__libc_mtag_new_tag (ptr), CHUNK_AVAILABLE_SIZE (cp) - CHUNK_HDR_SZ); }