diff mbox series

[09/34] Add hidden prototypes for fsync, fdatasync

Message ID c44ad7d758ee91c13946cfc6d4d1ae388629ad72.1623956057.git.fweimer@redhat.com
State Committed
Commit 412b05fec9323a093fe271ae01b4083ea2d1fc1f
Delegated to: Adhemerval Zanella Netto
Headers show
Series Move librt into libc | expand

Checks

Context Check Description
dj/TryBot-apply_patch success Patch applied to master at the time it was sent

Commit Message

Florian Weimer June 17, 2021, 6:57 p.m. UTC
---
 include/unistd.h                    | 2 ++
 misc/fdatasync.c                    | 1 +
 misc/fsync.c                        | 2 +-
 sysdeps/mach/hurd/fdatasync.c       | 1 +
 sysdeps/mach/hurd/fsync.c           | 1 +
 sysdeps/unix/sysv/linux/fdatasync.c | 1 +
 sysdeps/unix/sysv/linux/fsync.c     | 1 +
 7 files changed, 8 insertions(+), 1 deletion(-)

Comments

Adhemerval Zanella June 22, 2021, 12:58 a.m. UTC | #1
LGTM, thanks.

Reviewed-by: Adhemerval Zanella  <adhemerval.zanella@linaro.org>

On 17/06/2021 15:57, Florian Weimer via Libc-alpha wrote:
> ---
>  include/unistd.h                    | 2 ++
>  misc/fdatasync.c                    | 1 +
>  misc/fsync.c                        | 2 +-
>  sysdeps/mach/hurd/fdatasync.c       | 1 +
>  sysdeps/mach/hurd/fsync.c           | 1 +
>  sysdeps/unix/sysv/linux/fdatasync.c | 1 +
>  sysdeps/unix/sysv/linux/fsync.c     | 1 +
>  7 files changed, 8 insertions(+), 1 deletion(-)
> 
> diff --git a/include/unistd.h b/include/unistd.h
> index 8ed8b1ea4b..34872d8b41 100644
> --- a/include/unistd.h
> +++ b/include/unistd.h
> @@ -25,6 +25,8 @@ libc_hidden_proto (seteuid)
>  libc_hidden_proto (setegid)
>  libc_hidden_proto (tcgetpgrp)
>  libc_hidden_proto (readlinkat)
> +libc_hidden_proto (fsync)
> +libc_hidden_proto (fdatasync)
>  
>  /* Now define the internal interfaces.  */

Ok.

>  extern int __access (const char *__name, int __type);
> diff --git a/misc/fdatasync.c b/misc/fdatasync.c
> index 28474812ca..c776978bba 100644
> --- a/misc/fdatasync.c
> +++ b/misc/fdatasync.c
> @@ -25,3 +25,4 @@ fdatasync (int fildes)
>  {
>    return fsync (fildes);
>  }
> +libc_hidden_def (fdatasync)

Ok.

> diff --git a/misc/fsync.c b/misc/fsync.c
> index e1c37c6016..1961dd0cb2 100644
> --- a/misc/fsync.c
> +++ b/misc/fsync.c
> @@ -25,6 +25,6 @@ fsync (int fd)
>    __set_errno (ENOSYS);
>    return -1;
>  }
> -
> +libc_hidden_def (fsync)
>  
>  stub_warning (fsync)


Ok.

> diff --git a/sysdeps/mach/hurd/fdatasync.c b/sysdeps/mach/hurd/fdatasync.c
> index 0be8072e7f..68df551016 100644
> --- a/sysdeps/mach/hurd/fdatasync.c
> +++ b/sysdeps/mach/hurd/fdatasync.c
> @@ -41,3 +41,4 @@ fdatasync (int fd)
>      }
>    return 0;
>  }
> +libc_hidden_def (fdatasync)

Ok.

> diff --git a/sysdeps/mach/hurd/fsync.c b/sysdeps/mach/hurd/fsync.c
> index ef04ee97f9..c1d560f293 100644
> --- a/sysdeps/mach/hurd/fsync.c
> +++ b/sysdeps/mach/hurd/fsync.c
> @@ -41,3 +41,4 @@ fsync (int fd)
>      }
>    return 0;
>  }
> +libc_hidden_def (fsync)

Ok.

> diff --git a/sysdeps/unix/sysv/linux/fdatasync.c b/sysdeps/unix/sysv/linux/fdatasync.c
> index 84c07f212e..12fb3c13e5 100644
> --- a/sysdeps/unix/sysv/linux/fdatasync.c
> +++ b/sysdeps/unix/sysv/linux/fdatasync.c
> @@ -27,3 +27,4 @@ fdatasync (int fd)
>  {
>    return SYSCALL_CANCEL (fdatasync, fd);
>  }
> +libc_hidden_def (fdatasync)

Ok.

> diff --git a/sysdeps/unix/sysv/linux/fsync.c b/sysdeps/unix/sysv/linux/fsync.c
> index 234bb0049f..e4b5c8c342 100644
> --- a/sysdeps/unix/sysv/linux/fsync.c
> +++ b/sysdeps/unix/sysv/linux/fsync.c
> @@ -26,3 +26,4 @@ fsync (int fd)
>  {
>    return SYSCALL_CANCEL (fsync, fd);
>  }
> +libc_hidden_def (fsync)
> 

Ok.
diff mbox series

Patch

diff --git a/include/unistd.h b/include/unistd.h
index 8ed8b1ea4b..34872d8b41 100644
--- a/include/unistd.h
+++ b/include/unistd.h
@@ -25,6 +25,8 @@  libc_hidden_proto (seteuid)
 libc_hidden_proto (setegid)
 libc_hidden_proto (tcgetpgrp)
 libc_hidden_proto (readlinkat)
+libc_hidden_proto (fsync)
+libc_hidden_proto (fdatasync)
 
 /* Now define the internal interfaces.  */
 extern int __access (const char *__name, int __type);
diff --git a/misc/fdatasync.c b/misc/fdatasync.c
index 28474812ca..c776978bba 100644
--- a/misc/fdatasync.c
+++ b/misc/fdatasync.c
@@ -25,3 +25,4 @@  fdatasync (int fildes)
 {
   return fsync (fildes);
 }
+libc_hidden_def (fdatasync)
diff --git a/misc/fsync.c b/misc/fsync.c
index e1c37c6016..1961dd0cb2 100644
--- a/misc/fsync.c
+++ b/misc/fsync.c
@@ -25,6 +25,6 @@  fsync (int fd)
   __set_errno (ENOSYS);
   return -1;
 }
-
+libc_hidden_def (fsync)
 
 stub_warning (fsync)
diff --git a/sysdeps/mach/hurd/fdatasync.c b/sysdeps/mach/hurd/fdatasync.c
index 0be8072e7f..68df551016 100644
--- a/sysdeps/mach/hurd/fdatasync.c
+++ b/sysdeps/mach/hurd/fdatasync.c
@@ -41,3 +41,4 @@  fdatasync (int fd)
     }
   return 0;
 }
+libc_hidden_def (fdatasync)
diff --git a/sysdeps/mach/hurd/fsync.c b/sysdeps/mach/hurd/fsync.c
index ef04ee97f9..c1d560f293 100644
--- a/sysdeps/mach/hurd/fsync.c
+++ b/sysdeps/mach/hurd/fsync.c
@@ -41,3 +41,4 @@  fsync (int fd)
     }
   return 0;
 }
+libc_hidden_def (fsync)
diff --git a/sysdeps/unix/sysv/linux/fdatasync.c b/sysdeps/unix/sysv/linux/fdatasync.c
index 84c07f212e..12fb3c13e5 100644
--- a/sysdeps/unix/sysv/linux/fdatasync.c
+++ b/sysdeps/unix/sysv/linux/fdatasync.c
@@ -27,3 +27,4 @@  fdatasync (int fd)
 {
   return SYSCALL_CANCEL (fdatasync, fd);
 }
+libc_hidden_def (fdatasync)
diff --git a/sysdeps/unix/sysv/linux/fsync.c b/sysdeps/unix/sysv/linux/fsync.c
index 234bb0049f..e4b5c8c342 100644
--- a/sysdeps/unix/sysv/linux/fsync.c
+++ b/sysdeps/unix/sysv/linux/fsync.c
@@ -26,3 +26,4 @@  fsync (int fd)
 {
   return SYSCALL_CANCEL (fsync, fd);
 }
+libc_hidden_def (fsync)