From patchwork Thu Feb 3 15:18:11 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Florian Weimer X-Patchwork-Id: 50722 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id C60F43858414 for ; Thu, 3 Feb 2022 15:19:35 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C60F43858414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1643901575; bh=GsYUiSFQIDaOPK0OFTzOq0zHMgbNj3WM+MrdfM2KzzI=; h=To:Subject:In-Reply-To:References:Date:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=CgTimodOlshuoBAEz0s8wmPPY91XF/4sbDz38nk6TfrAsVSsNU1iWcv1YFMXJuTr0 ZEKkIHv2r3HrXL5gWV2fkFlYtbAAbwFl7LxqjI4mgrkTnNbWCsALUwoVHPxF/1JfXz xl6D5haas9Cp+T5WgC5VmRjPiIjtHiLKF9mtPTJ4= X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 254813858417 for ; Thu, 3 Feb 2022 15:18:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 254813858417 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-497-x9UWLXHkPrWadqy2FCoyUQ-1; Thu, 03 Feb 2022 10:18:14 -0500 X-MC-Unique: x9UWLXHkPrWadqy2FCoyUQ-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id CC73E192FDA0 for ; Thu, 3 Feb 2022 15:18:13 +0000 (UTC) Received: from oldenburg.str.redhat.com (unknown [10.39.193.205]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 1748570D46 for ; Thu, 3 Feb 2022 15:18:12 +0000 (UTC) To: libc-alpha@sourceware.org Subject: [PATCH v2 2/3] elf: Do not run constructors for proxy objects In-Reply-To: References: X-From-Line: c3a8ae220797e71c74df32fc6fed7fcf3ccdcac1 Mon Sep 17 00:00:00 2001 Message-Id: Date: Thu, 03 Feb 2022 16:18:11 +0100 User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-12.2 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Florian Weimer via Libc-alpha From: Florian Weimer Reply-To: Florian Weimer Errors-To: libc-alpha-bounces+patchwork=sourceware.org@sourceware.org Sender: "Libc-alpha" Otherwise, the ld.so constructor runs for each audit namespace and each dlmopen namespace. --- v2: New patch. elf/dl-init.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/elf/dl-init.c b/elf/dl-init.c index deefeb099a..cfeb28a2a7 100644 --- a/elf/dl-init.c +++ b/elf/dl-init.c @@ -25,6 +25,10 @@ static void call_init (struct link_map *l, int argc, char **argv, char **env) { + /* Do not run constructors for proxy objects. */ + if (l != l->l_real) + return; + /* If the object has not been relocated, this is a bug. The function pointers are invalid in this case. (Executables do not need relocation, and neither do proxy objects.) */