From patchwork Thu Nov 12 09:44:47 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shuo Wang X-Patchwork-Id: 41028 X-Patchwork-Delegate: fweimer@redhat.com Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id ADA563858028; Thu, 12 Nov 2020 09:45:04 +0000 (GMT) X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from szxga04-in.huawei.com (szxga04-in.huawei.com [45.249.212.190]) by sourceware.org (Postfix) with ESMTPS id 856C13858009 for ; Thu, 12 Nov 2020 09:45:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 856C13858009 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=huawei.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=wangshuo47@huawei.com Received: from DGGEMS409-HUB.china.huawei.com (unknown [172.30.72.60]) by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4CWxXJ68tkz15VYg; Thu, 12 Nov 2020 17:44:48 +0800 (CST) Received: from [10.174.176.87] (10.174.176.87) by DGGEMS409-HUB.china.huawei.com (10.3.19.209) with Microsoft SMTP Server id 14.3.487.0; Thu, 12 Nov 2020 17:44:47 +0800 To: "libc-alpha@sourceware.org" , From: Shuo Wang Subject: [PATCH] elf: Fix uninitialized variable for _dl_write Message-ID: Date: Thu, 12 Nov 2020 17:44:47 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 MIME-Version: 1.0 Content-Language: en-US X-Originating-IP: [10.174.176.87] X-CFilter-Loop: Reflected X-Spam-Status: No, score=-12.7 required=5.0 tests=BAYES_00, GIT_PATCH_0, KAM_DMARC_STATUS, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Hushiyuan Errors-To: libc-alpha-bounces@sourceware.org Sender: "Libc-alpha" elf: Fix uninitialized variable for _dl_write Variable ret in elf/dl-write.c is uninitialized, which should get return value from __writev. --- elf/dl-write.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/elf/dl-write.c b/elf/dl-write.c index 7350aff003..9b741c8a8f 100644 --- a/elf/dl-write.c +++ b/elf/dl-write.c @@ -41,7 +41,7 @@ _dl_write (int fd, const void *buffer, size_t length) else { __rtld_lock_lock_recursive (GL(dl_load_lock)); - __writev (fd, &iov, 1); + ret = __writev (fd, &iov, 1); if (ret < 0) ret = -errno; __rtld_lock_unlock_recursive (GL(dl_load_lock));